From d672cf518fbb45439ac25bc3967ba6feadef47ae Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Fri, 30 Jan 2026 16:13:27 +0100 Subject: [PATCH 1/2] unify first-frame-is-sid job --- includes/check-first-frame-is-sid.yml | 28 +++++++++++++++++++++++++++ main-basop.yml | 18 +---------------- main-float.yml | 27 +------------------------- 3 files changed, 30 insertions(+), 43 deletions(-) create mode 100644 includes/check-first-frame-is-sid.yml diff --git a/includes/check-first-frame-is-sid.yml b/includes/check-first-frame-is-sid.yml new file mode 100644 index 0000000..d60f2ca --- /dev/null +++ b/includes/check-first-frame-is-sid.yml @@ -0,0 +1,28 @@ +# check for crashes if first received frame on decoder side is an SID +check-first-frame-is-sid: + extends: + - .test-job-linux-needs-testv-dir + - .rules-merge-request-to-main + stage: test + needs: ["build-codec-linux-cmake"] + script: + - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/print-common-info.sh + - | + if [ "$CI_PROJECT_ID" == "$PROJECT_ID_BASOP" ]; then + bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/basop/update-scripts-repo.sh + fi + - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/update-ltv-repo.sh + # this rm makes check-for-testvectors only check for the signals we actually need in this test + - rm scripts/config/ci_linux_ltv.json scripts/config/ci_linux.json + - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/check-for-testvectors.sh + - bash ci/run-first-frame-is-sid-test.sh + artifacts: + paths: + - logs_enc + - logs_dec_msan + - logs_dec_asan + - logs_dec_usan + when: always + name: "$CI_JOB_NAME--$CI_MERGE_REQUEST_IID--sha-$CI_COMMIT_SHORT_SHA--sidstart" + expose_as: "logs-sidstart" + expire_in: "5 days" diff --git a/main-basop.yml b/main-basop.yml index b03a998..eb961ed 100644 --- a/main-basop.yml +++ b/main-basop.yml @@ -6,6 +6,7 @@ include: - local: includes/smoke-test.yml - local: includes/build-jobs.yml - local: includes/rules.yml + - local: includes/check-first-frame-is-sid.yml default: # by default, we want all jobs to be interruptible, and we need to configure this explicitly @@ -1356,23 +1357,6 @@ split-rendering-pytest-on-merge-request: - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/basop/update-scripts-repo.sh - bash ci/smoke_test.sh -# from float -# check for crashes if first received frame on decoder side is an SID -.check-first-frame-is-sid: - extends: - - .test-job-linux-needs-testv-dir - - .rules-merge-request-to-main - stage: test - needs: ["build-codec-linux-make"] - script: - - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/print-common-info.sh - - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/basop/update-scripts-repo.sh - - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/update-ltv-repo.sh - # this rm makes check-for-testvectors only check for the signals we actually need in this test - - rm scripts/config/ci_linux_ltv.json scripts/config/ci_linux.json - - python3 -m pytest ci/test_vectors_available.py - - bash ci/run-first-frame-is-sid-test.sh - # from float # needs fix to be merged from floating point repo before it can be activated .check-bitexactness-hrtf-rom-and-file: diff --git a/main-float.yml b/main-float.yml index 0c06a42..c69a1ed 100644 --- a/main-float.yml +++ b/main-float.yml @@ -6,6 +6,7 @@ include: - local: includes/smoke-test.yml - local: includes/build-jobs.yml - local: includes/rules.yml + - local: includes/check-first-frame-is-sid.yml default: # by default, we want all jobs to be interruptible, and we need to configure this explicitly @@ -988,32 +989,6 @@ clang-format-check: name: "$ARTIFACT_BASE_NAME" expose_as: "formatting patch" -# check for crashes if first received frame on decoder side is an SID -check-first-frame-is-sid: - extends: - - .test-job-linux-needs-testv-dir - - .rules-merge-request-to-main - stage: test - needs: ["build-codec-linux-cmake"] - script: - - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/print-common-info.sh - - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/update-ltv-repo.sh - # this rm makes check-for-testvectors only check for the signals we actually need in this test - - rm scripts/config/ci_linux_ltv.json scripts/config/ci_linux.json - - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/check-for-testvectors.sh - - bash ci/run-first-frame-is-sid-test.sh - - artifacts: - paths: - - logs_enc - - logs_dec_msan - - logs_dec_asan - - logs_dec_usan - when: always - name: "$CI_JOB_NAME--$CI_MERGE_REQUEST_IID--sha-$CI_COMMIT_SHORT_SHA--sidstart" - expose_as: "logs-sidstart" - expire_in: "5 days" - lc3plus-ensure-no-code-changes: extends: - .test-job-linux -- GitLab From f9fc70f8f238dcf83322f995fbaab220d39814ee Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Fri, 30 Jan 2026 17:16:04 +0100 Subject: [PATCH 2/2] set timeout for sid job --- includes/check-first-frame-is-sid.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/includes/check-first-frame-is-sid.yml b/includes/check-first-frame-is-sid.yml index d60f2ca..65029db 100644 --- a/includes/check-first-frame-is-sid.yml +++ b/includes/check-first-frame-is-sid.yml @@ -16,6 +16,7 @@ check-first-frame-is-sid: - rm scripts/config/ci_linux_ltv.json scripts/config/ci_linux.json - bash "${CI_PROJECT_DIR}"/ivas-codec-ci/snippets/check-for-testvectors.sh - bash ci/run-first-frame-is-sid-test.sh + timeout: "10 minutes" artifacts: paths: - logs_enc -- GitLab