From 762945394f09219df86f508eb2a69f8e246f1f49 Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Thu, 16 Apr 2026 12:46:20 +0200 Subject: [PATCH 1/2] check for changes in lib_lc3plus without download --- main-float.yml | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/main-float.yml b/main-float.yml index a84056a..e2954e0 100644 --- a/main-float.yml +++ b/main-float.yml @@ -1041,12 +1041,18 @@ lc3plus-ensure-no-code-changes: needs: [] timeout: "5 minutes" script: - # Replace code commited to repo with code downloaded from ETSI - - ./scripts/lc3plus_lib_setup/get_lc3plus.sh + - echo $CI_MERGE_REQUEST_TITLE > tmp.txt + - lc3plus_update_flag=$(grep -c --ignore-case "\[lc3plus[ -]update\]" tmp.txt) || true + + - git_diff_return_code=0 + - git diff --name-only --exit-code $CI_MERGE_REQUEST_TARGET_BRANCH_NAME -- lib_lc3plus || git_diff_return_code=$? - # Ensure git reports no changes - - modified_files=$(git status -su lib_lc3plus) - - if [[ $modified_files ]]; then printf 'LC3plus codebase was modified!\n\n'"$modified_files"'\n\n'; exit $EXIT_CODE_FAIL; fi + - | + if [ $git_diff_return_code != 0 ] && [ $lc3plus_update_flag == 0]; then + echo "Your MR modifies lib_lc3plus. That should not be done. If this MR is meant to update to a new LC3plus version, add '[lc3plus-update]' to your MR title." + exit 1 + fi + - exit 0 check-bitexactness-hrtf-rom-and-file: extends: -- GitLab From 5941a612e3fd06804680a7712b3226d768fbb99c Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Mon, 20 Apr 2026 08:59:40 +0200 Subject: [PATCH 2/2] Apply 1 suggestion(s) to 1 file(s) Co-authored-by: Archit Tamarapu --- main-float.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main-float.yml b/main-float.yml index e2954e0..3faeb3b 100644 --- a/main-float.yml +++ b/main-float.yml @@ -1048,7 +1048,7 @@ lc3plus-ensure-no-code-changes: - git diff --name-only --exit-code $CI_MERGE_REQUEST_TARGET_BRANCH_NAME -- lib_lc3plus || git_diff_return_code=$? - | - if [ $git_diff_return_code != 0 ] && [ $lc3plus_update_flag == 0]; then + if [ $git_diff_return_code != 0 ] && [ $lc3plus_update_flag == 0 ]; then echo "Your MR modifies lib_lc3plus. That should not be done. If this MR is meant to update to a new LC3plus version, add '[lc3plus-update]' to your MR title." exit 1 fi -- GitLab