Commit 4a6e07f1 authored by Serdar Buyuksarac's avatar Serdar Buyuksarac
Browse files

Go over ToDo's

parent 86c9d3a0

lib_rend/ivas_hrtf.c

+13 −15
Original line number Diff line number Diff line
@@ -256,7 +256,6 @@ ivas_error ivas_HRTF_statistics_binary_open( 
        return IVAS_ERROR( IVAS_ERR_FAILED_ALLOC, "Can not allocate memory for statistics HRTF tables!" );

    }



#ifdef NONBE_FIX_922_PRECOMPUTED_HRTF_PROPERTIES

    switch ( sampleRate )

    {

        case 48000:
@@ -280,7 +279,6 @@ ivas_error ivas_HRTF_statistics_binary_open( 
            ( *hHrtfStatistics )->inter_aural_coherence = NULL;

            break;

    }

#endif



    return IVAS_ERR_OK;

}

lib_rend/ivas_objectRenderer_mix.c

+1 −1
Original line number Diff line number Diff line
@@ -404,7 +404,7 @@ static ivas_error DefaultBSplineModel( 
    modelITD = &( HrFiltSet_p->ModelParamsITD );



#ifdef NONBE_FIX_922_PRECOMPUTED_HRTF_PROPERTIES

    /*Todo: Check ModelRom*/

    /*TODO(922): Check ModelRom*/

#else

    switch ( output_Fs )

    {

lib_rend/ivas_reverb.c

+1 −1
Original line number Diff line number Diff line
@@ -1002,7 +1002,7 @@ static void set_reverb_acoustic_data( 
    }



#endif

    /* ToDo: Check if interpolation is necessary. */

    /* TODO(922): Check if interpolation is necessary. */

    /* interpolate input table data for T60 and DSR to the FFT filter grid */

    ivas_reverb_interpolate_acoustic_data( nr_fc_input, pRoomAcoustics->pFc_input, pRoomAcoustics->pAcoustic_rt60, pRoomAcoustics->pAcoustic_dsr,

                                           nr_fc_fft_filter, pParams->pFc, pParams->pRt60, pParams->pDsr );

lib_util/hrtf_file_reader.c

+3 −3
Original line number Diff line number Diff line
@@ -512,7 +512,7 @@ static ivas_error set_default_reverb_iac_energy( 
#endif

    {

#ifdef NONBE_FIX_922_PRECOMPUTED_HRTF_PROPERTIES

        /* TODO: check for sample rate dependency if no three sets of data need to be handled in parallel */



        hHrtfStatistics->average_energy_l_dyn = (float *) malloc( lr_iac_len * sizeof( float ) );

        hHrtfStatistics->average_energy_r_dyn = (float *) malloc( lr_iac_len * sizeof( float ) );

        hHrtfStatistics->inter_aural_coherence_dyn = (float *) malloc( lr_iac_len * sizeof( float ) );
@@ -778,9 +778,9 @@ static ivas_error load_reverb_from_binary( 
    else

    {

#ifdef NONBE_FIX_922_PRECOMPUTED_HRTF_PROPERTIES

        /* TODO: Check for the modelROM correctness */

        /* TODO(922): Check for the modelROM correctness */



        /* TODO: Check should we call this function in other place as well? */

        /* TODO(922): Check should we call this function in other place as well? */

        set_default_reverb_iac_energy( hHrtfStatistics, sampleRate, TRUE );

#else

        set_default_reverb_iac_energy( HrFiltSet_p );