Commit 4ce18b5a authored by multrus's avatar multrus
Browse files

[cleanup] accept NONBE_FIX_736_FOA_BR_SWITCH

parent 09e12546

lib_com/options.h

+0 −1
Original line number Diff line number Diff line
@@ -175,7 +175,6 @@ 
/* all switches in this category should start with "NONBE_" */





#define NONBE_FIX_736_FOA_BR_SWITCH                           /* FhG/Dlb : Issue 736: FOA bitrate switching decoding crashes in in ivas_spar_to_dirac */

#define NONBE_FIX_746_NONDIEGETIC_MD                          /* Eri: Issue 746: The non-diegetic panning flag affects the encoder bitstream even if extended metadata is not enabled. Crashes the decoder.*/

#define NONBE_FIX_723_SBA_BR_SWITCH_MSAN                      /* Dlb: issue 723: Uninitialised value used after BR switching*/

#define NONBE_FIX_729_ASAN_2ISM_ACELP                         /* VA: issue 729: fix ASAN ACELP errors with 2 ISM coding using LTV */

lib_dec/ivas_sba_dec.c

+0 −14
Original line number Diff line number Diff line
@@ -302,11 +302,7 @@ ivas_error ivas_sba_dec_reconfigure( 


    if ( hSpar != NULL )

    {

#ifdef NONBE_FIX_736_FOA_BR_SWITCH

        if ( ( hSpar->hPCA != NULL ) && ( ( hDecoderConfig->ivas_total_brate != PCA_BRATE ) || ( st_ivas->sba_order != 1 ) ) )

#else

        if ( ( hSpar->hPCA != NULL ) && ( ( hDecoderConfig->ivas_total_brate != PCA_BRATE ) || ( sba_order_internal != 1 ) ) )

#endif

        {

            free( st_ivas->hSpar->hPCA );

            hSpar->hPCA = NULL;
@@ -336,7 +332,6 @@ ivas_error ivas_sba_dec_reconfigure( 
                return error;

            }

        }

#ifdef NONBE_FIX_736_FOA_BR_SWITCH

        if ( ( hSpar->hPCA == NULL ) &&

             ( st_ivas->hDecoderConfig->ivas_total_brate == PCA_BRATE && st_ivas->sba_order == 1 ) && ( st_ivas->ivas_format == SBA_FORMAT ) )

        {
@@ -347,7 +342,6 @@ ivas_error ivas_sba_dec_reconfigure( 


            ivas_pca_dec_init( hSpar->hPCA );

        }

#endif

        ivas_spar_config( ivas_total_brate, sba_order_internal, &st_ivas->nchan_transport, &st_ivas->nSCE, &st_ivas->nCPE, &hSpar->core_nominal_brate, st_ivas->sid_format );

    }

    else
@@ -425,18 +419,12 @@ ivas_error ivas_sba_dec_reconfigure( 
    }

#endif



#ifdef NONBE_FIX_736_FOA_BR_SWITCH

    if ( ( error = ivas_dirac_sba_config( st_ivas->hQMetaData, &st_ivas->element_mode_init, ivas_total_brate, st_ivas->sba_analysis_order, ivas_get_hodirac_flag( ivas_total_brate, st_ivas->sba_analysis_order ) ? IVAS_MAX_NUM_BANDS : ( IVAS_MAX_NUM_BANDS - SPAR_DIRAC_SPLIT_START_BAND ) ) ) != IVAS_ERR_OK )

    {

        return error;

    }

#endif



#ifndef NONBE_FIX_736_FOA_BR_SWITCH

    if ( ( ( st_ivas->renderer_type != RENDERER_DISABLE ) && ( st_ivas->renderer_type != RENDERER_SBA_LINEAR_DEC ) ) || ( ( hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_FOA ) && ( st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_STEREO ) && ( st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_MONO ) ) || ( last_ivas_total_brate > IVAS_256k && ivas_total_brate <= IVAS_256k ) || ( last_ivas_total_brate <= IVAS_256k && ivas_total_brate > IVAS_256k ) )

#else

    if ( ( ( st_ivas->renderer_type != RENDERER_DISABLE ) && ( st_ivas->renderer_type != RENDERER_SBA_LINEAR_DEC ) ) || ( ( hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_FOA ) && ( st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_STEREO ) && ( st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_MONO ) ) )

#endif

    {

        DIRAC_CONFIG_FLAG flag_config;
@@ -463,7 +451,6 @@ ivas_error ivas_sba_dec_reconfigure( 
        }

#endif

    }

#ifdef NONBE_FIX_736_FOA_BR_SWITCH

    else

    {

        int16_t band_grouping[IVAS_MAX_NUM_BANDS + 1];
@@ -486,7 +473,6 @@ ivas_error ivas_sba_dec_reconfigure( 
        }

#endif

    }

#endif



    if ( st_ivas->renderer_type == RENDERER_DISABLE )

    {