Commit a048be5f authored by multrus's avatar multrus
Browse files

Merge branch... 

Merge branch 'float-1544-assertion-errors-triggered-when-float-code-is-compiled-with-funsafe-math-optimizations-part02' into 'main'

Resolve "Assertion errors triggered when float code is compiled with "-funsafe-math-optimizations" option"

See merge request !2570
parents c987ca9e e9763a08

lib_com/ivas_dirac_com.c

+10 −0
Original line number Diff line number Diff line
@@ -385,7 +385,17 @@ void ivas_get_dirac_sba_max_md_bits( 
        *metadata_max_bits = MAX16B; /* no limit */

    }



#ifdef FIX_FLOAT_1544_SBA_META_IMPRECISION_UNSAFE_MATH

    /*

      original formula was:

      *metadata_max_bits = (int16_t) min( (float) MAX16B, ceilf( (float) *metadata_max_bits * nbands / 5 ) );

      The division by 5 is replaced by a multiplication by 0.2f, since the division is causing problems for

      certain optimizations using -funsafe-math-optimizations

    */

    *metadata_max_bits = (int16_t) min( (float) MAX16B, ceilf( *metadata_max_bits * nbands * 0.2f ) );

#else

    *metadata_max_bits = (int16_t) min( (float) MAX16B, ceilf( (float) *metadata_max_bits * nbands / 5 ) );

#endif

    *qmetadata_max_bit_req = QMETADATA_MAXBIT_REQ_SBA >> 1;



    return;

lib_com/options.h

+1 −0
Original line number Diff line number Diff line
@@ -163,6 +163,7 @@ 
#define NONBE_1122_KEEP_EVS_MODE_UNCHANGED              /* FhG: Disables fix for issue 1122 in EVS mode to keep BE tests green. This switch should be removed once the 1122 fix is added to EVS via a CR.  */

#define FIX_BASOP_2469_OBJ_EDIT_TD_REND_GAIN            /* Eri: Basop issue 2469: TD renderer gain has wrong Q. In float this is just a synch of the cleanup done in BASOP */

#define FIX_ISSUE_1546_DEAD_CODE                        /* FhG: remove dead code reported in the issue*/

#define FIX_FLOAT_1544_SBA_META_IMPRECISION_UNSAFE_MATH /* FhG: float issue 1544: imprecision in ivas_get_dirac_sba_max_md_bits() with -funsafe-math-optimizations */



/* #################### End BE switches ################################## */