Commit ab915692 authored by vaclav's avatar vaclav
Browse files

Merge branch '945-wrong-return-value-in-ivas_dec_getnumorientationsubframes' into 'main' 

Confusing use of "frame size" vs. "number of subframes" in renderer

See merge request !1642
parents fd675060 89c1de6d

apps/decoder.c

+45 −41
Original line number Diff line number Diff line
@@ -131,7 +131,7 @@ typedef struct 
    char *outputMdFilename;

    IVAS_DEC_COMPLEXITY_LEVEL complexityLevel;

    bool tsmEnabled;

    IVAS_RENDER_FRAMESIZE renderFramesize;

    IVAS_RENDER_NUM_SUBFR render_num_subframes;

    bool applyPiData;

    char *piOutputFilename;

    bool rtpOutSR;
@@ -218,7 +218,7 @@ int main( 
    Vector3PairFileReader *referenceVectorReader = NULL;

    RenderConfigReader *renderConfigReader = NULL;

    int16_t *pcmBuf = NULL;

    IVAS_RENDER_FRAMESIZE asked_frame_size;

    IVAS_RENDER_NUM_SUBFR asked_num_subframes;

    IVAS_DEC_HRTF_BINARY_WRAPPER hHrtfBinary;

    ObjectEditFileReader *objectEditFileReader = NULL;

    IVAS_ROOM_ACOUSTICS_CONFIG_DATA **pAE = NULL;
@@ -448,11 +448,11 @@ int main( 
     * Configure the decoder

     *------------------------------------------------------------------------------------------*/



    asked_frame_size = arg.renderFramesize;

    asked_num_subframes = arg.render_num_subframes;

    uint16_t aeID = arg.aeSequence.count > 0 ? arg.aeSequence.pID[0] : IVAS_DEFAULT_AEID;

    arg.enableHeadRotation = arg.enableHeadRotation || arg.outputConfig == IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_CODED || arg.outputConfig == IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_PCM;



    if ( ( error = IVAS_DEC_Configure( hIvasDec, arg.output_Fs, arg.outputConfig, arg.renderFramesize, arg.customLsOutputEnabled, arg.hrtfReaderEnabled,

    if ( ( error = IVAS_DEC_Configure( hIvasDec, arg.output_Fs, arg.outputConfig, arg.render_num_subframes, arg.customLsOutputEnabled, arg.hrtfReaderEnabled,

                                       arg.enableHeadRotation, arg.enableExternalOrientation, arg.orientation_tracking, arg.renderConfigEnabled, arg.roomSize, arg.non_diegetic_pan_enabled,

                                       arg.non_diegetic_pan_gain, arg.dpidEnabled, aeID, arg.objEditEnabled, arg.delayCompensationEnabled ) ) != IVAS_ERR_OK )

    {
@@ -460,13 +460,13 @@ int main( 
        goto cleanup;

    }



    if ( ( error = IVAS_DEC_GetRenderFramesize( hIvasDec, &arg.renderFramesize ) ) != IVAS_ERR_OK )

    if ( ( error = IVAS_DEC_GetRenderNumSubfr( hIvasDec, &arg.render_num_subframes ) ) != IVAS_ERR_OK )

    {

        fprintf( stderr, "\nConfigure failed: %s\n\n", IVAS_DEC_GetErrorMessage( error ) );

        fprintf( stderr, "\nIVAS_DEC_GetRenderNumSubfr failed: %s\n\n", IVAS_DEC_GetErrorMessage( error ) );

        goto cleanup;

    }



    if ( arg.renderFramesize != asked_frame_size )

    if ( arg.render_num_subframes != asked_num_subframes )

    {

        fprintf( stderr, "\nChanged render framesize, only 20ms are allowed for decoding to EXT!\n" );

    }
@@ -475,7 +475,7 @@ int main( 
     * Configure Split rendering

     *------------------------------------------------------------------------------------------*/



    asked_frame_size = arg.renderFramesize;

    asked_num_subframes = arg.render_num_subframes;

    if ( arg.outputConfig == IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_CODED || arg.outputConfig == IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_PCM )

    {

        if ( ( error = IVAS_DEC_EnableSplitRendering( hIvasDec ) ) != IVAS_ERR_OK )
@@ -484,14 +484,14 @@ int main( 
            goto cleanup;

        }



        if ( ( error = IVAS_DEC_GetRenderFramesize( hIvasDec, &arg.renderFramesize ) ) != IVAS_ERR_OK )

        if ( ( error = IVAS_DEC_GetRenderNumSubfr( hIvasDec, &arg.render_num_subframes ) ) != IVAS_ERR_OK )

        {

            fprintf( stderr, "\nConfigure failed: %s\n\n", IVAS_DEC_GetErrorMessage( error ) );

            fprintf( stderr, "\nIVAS_DEC_GetRenderNumSubfr failed: %s\n\n", IVAS_DEC_GetErrorMessage( error ) );

            goto cleanup;

        }



#ifdef FIX_1449_RENDERER_FRAME_SIZE_UNCLEAR_IN_ISAR

        if ( !arg.renderConfigEnabled && ( arg.renderFramesize != asked_frame_size ) )

        if ( !arg.renderConfigEnabled && ( arg.render_num_subframes != asked_num_subframes ) )

        {

            fprintf( stderr, "\nChanged render framesize, only 20ms are allowed for non-0dof split rendering!\n" );

        }
@@ -675,31 +675,33 @@ int main( 
            fprintf( stderr, "Failed to get directivity patterns for one or more of IDs: %d %d %d %d\n\n", arg.directivityPatternId[0], arg.directivityPatternId[1], arg.directivityPatternId[2], arg.directivityPatternId[3] );

            goto cleanup;

        }



        if ( ( error = RenderConfigReader_getDistanceAttenuation( renderConfigReader, renderConfig.distAtt ) ) != IVAS_ERR_OK )

        {

            fprintf( stderr, "Failed to get Distance Attenuation \n\n" );

            goto cleanup;

        }



        if ( arg.outputConfig == IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_CODED || arg.outputConfig == IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_PCM )

        {

            if ( asked_frame_size != IVAS_RENDER_FRAMESIZE_20MS &&

            if ( asked_num_subframes != IVAS_RENDER_NUM_SUBFR_20MS &&

                 ( renderConfig.split_rend_config.poseCorrectionMode == ISAR_SPLIT_REND_POSE_CORRECTION_MODE_NONE ||

                   renderConfig.split_rend_config.dof == 0 ) )

            {

                arg.renderFramesize = asked_frame_size;

                arg.render_num_subframes = asked_num_subframes;

            }

            else

            {

                arg.renderFramesize = IVAS_RENDER_FRAMESIZE_20MS;

                arg.render_num_subframes = IVAS_RENDER_NUM_SUBFR_20MS;

            }



            if ( ( error = IVAS_DEC_SetRenderFramesize( hIvasDec, arg.renderFramesize ) ) != IVAS_ERR_OK )

            if ( ( error = IVAS_DEC_SetRenderNumSubfr( hIvasDec, arg.render_num_subframes ) ) != IVAS_ERR_OK )

            {

                fprintf( stderr, "\nIVAS_DEC_PrintConfig failed: %s\n\n", IVAS_DEC_GetErrorMessage( error ) );

                goto cleanup;

            }



            if ( arg.renderFramesize != asked_frame_size )

            if ( arg.render_num_subframes != asked_num_subframes )

            {

                fprintf( stderr, "\nChanged render framesize, only 20ms are allowed for non-0dof split rendering!\n" );

            }
@@ -724,7 +726,7 @@ int main( 


        /* ISAR frame size is set from command line, not renderer config file.

         * This will be ignored if output format is not split rendering. */

        renderConfig.split_rend_config.isar_frame_size_ms = (int16_t) arg.renderFramesize /* given in number of 5ms subframes */ * 5;

        renderConfig.split_rend_config.isar_frame_size_ms = (int16_t) arg.render_num_subframes * 5;



        if ( ( error = IVAS_DEC_FeedRenderConfig( hIvasDec, renderConfig ) ) != IVAS_ERR_OK )

        {
@@ -1060,7 +1062,7 @@ static bool parseCmdlIVAS_dec( 
    arg->non_diegetic_pan_enabled = false;

    arg->non_diegetic_pan_gain = 0.f;

    arg->tsmEnabled = false;

    arg->renderFramesize = IVAS_RENDER_FRAMESIZE_20MS;

    arg->render_num_subframes = IVAS_RENDER_NUM_SUBFR_20MS;

#ifdef DEBUGGING

#ifdef VARIABLE_SPEED_DECODING

    arg->tsmScale = 100;
@@ -1292,13 +1294,13 @@ static bool parseCmdlIVAS_dec( 
                switch ( (int16_t) tmp )

                {

                    case 5:

                        arg->renderFramesize = IVAS_RENDER_FRAMESIZE_5MS;

                        arg->render_num_subframes = IVAS_RENDER_NUM_SUBFR_5MS;

                        break;

                    case 10:

                        arg->renderFramesize = IVAS_RENDER_FRAMESIZE_10MS;

                        arg->render_num_subframes = IVAS_RENDER_NUM_SUBFR_10MS;

                        break;

                    case 20:

                        arg->renderFramesize = IVAS_RENDER_FRAMESIZE_20MS;

                        arg->render_num_subframes = IVAS_RENDER_NUM_SUBFR_20MS;

                        break;

                    default:

                        fprintf( stderr, "Error: Invalid render frame size %d \n\n", tmp );
@@ -2425,10 +2427,10 @@ static ivas_error decodeG192( 
            }

        }



        int16_t num_subframes;

        if ( ( error = IVAS_DEC_GetNumOrientationSubframes( hIvasDec, &num_subframes ) ) != IVAS_ERR_OK )

        IVAS_RENDER_NUM_SUBFR num_subframes;

        if ( ( error = IVAS_DEC_GetRenderNumSubfr( hIvasDec, &num_subframes ) ) != IVAS_ERR_OK )

        {

            fprintf( stderr, "\nIVAS_DEC_GetNumOrientationSubframes failed: \n" );

            fprintf( stderr, "\nIVAS_DEC_GetRenderNumSubfr failed: %s\n", IVAS_DEC_GetErrorMessage( error ) );

            goto cleanup;

        }
@@ -2439,7 +2441,7 @@ static ivas_error decodeG192( 


            if ( headRotReader == NULL )

            {

                for ( i = 0; i < num_subframes; i++ )

                for ( i = 0; i < (int16_t) num_subframes; i++ )

                {

                    Quaternions[i].w = -3.0f;

                    Quaternions[i].x = 0.0f;
@@ -2452,7 +2454,7 @@ static ivas_error decodeG192( 
            }

            else

            {

                for ( i = 0; i < num_subframes; i++ )

                for ( i = 0; i < (int16_t) num_subframes; i++ )

                {

                    if ( ( error = HeadRotationFileReading( headRotReader, &Quaternions[i], &Pos[i] ) ) != IVAS_ERR_OK )

                    {
@@ -2462,7 +2464,7 @@ static ivas_error decodeG192( 
                }

            }



            for ( i = 0; i < num_subframes; i++ )

            for ( i = 0; i < (int16_t) num_subframes; i++ )

            {

                if ( ( error = IVAS_DEC_FeedHeadTrackData( hIvasDec, Quaternions[i], Pos[i], i, DEFAULT_AXIS ) ) != IVAS_ERR_OK )

                {
@@ -2480,7 +2482,7 @@ static ivas_error decodeG192( 
            int8_t enableRotationInterpolation[IVAS_MAX_PARAM_SPATIAL_SUBFRAMES];

            int16_t numFramesToTargetOrientation[IVAS_MAX_PARAM_SPATIAL_SUBFRAMES];



            for ( i = 0; i < num_subframes; i++ )

            for ( i = 0; i < (int16_t) num_subframes; i++ )

            {

                if ( ( error = ExternalOrientationFileReading( externalOrientationFileReader, &Quaternions[i], &enableHeadRotation[i], &enableExternalOrientation[i], &enableRotationInterpolation[i], &numFramesToTargetOrientation[i] ) ) != IVAS_ERR_OK )

                {
@@ -2488,7 +2490,8 @@ static ivas_error decodeG192( 
                    goto cleanup;

                }

            }

            for ( i = 0; i < num_subframes; i++ )



            for ( i = 0; i < (int16_t) num_subframes; i++ )

            {

                if ( ( error = IVAS_DEC_FeedExternalOrientationData( hIvasDec, Quaternions[i], enableHeadRotation[i], enableExternalOrientation[i], enableRotationInterpolation[i], numFramesToTargetOrientation[i], i ) ) != IVAS_ERR_OK )

                {
@@ -3387,10 +3390,10 @@ static ivas_error decodeVoIP( 
            }

        }



        int16_t num_subframes;

        if ( ( error = IVAS_DEC_GetNumOrientationSubframes( hIvasDec, &num_subframes ) ) != IVAS_ERR_OK )

        IVAS_RENDER_NUM_SUBFR num_subframes;

        if ( ( error = IVAS_DEC_GetRenderNumSubfr( hIvasDec, &num_subframes ) ) != IVAS_ERR_OK )

        {

            fprintf( stderr, "\nIVAS_DEC_GetNumOrientationSubframes failed: \n" );

            fprintf( stderr, "\nIVAS_DEC_GetRenderNumSubfr failed: %s\n", IVAS_DEC_GetErrorMessage( error ) );

            goto cleanup;

        }
@@ -3401,7 +3404,7 @@ static ivas_error decodeVoIP( 


            if ( headRotReader == NULL )

            {

                for ( i = 0; i < num_subframes; i++ )

                for ( i = 0; i < (int16_t) num_subframes; i++ )

                {

                    Quaternions[i].w = -3.0f;

                    Quaternions[i].x = 0.0f;
@@ -3414,7 +3417,7 @@ static ivas_error decodeVoIP( 
            }

            else

            {

                for ( i = 0; i < num_subframes; i++ )

                for ( i = 0; i < (int16_t) num_subframes; i++ )

                {

                    if ( ( error = HeadRotationFileReading( headRotReader, &Quaternions[i], &Pos[i] ) ) != IVAS_ERR_OK )

                    {
@@ -3425,7 +3428,7 @@ static ivas_error decodeVoIP( 
                }

            }



            for ( i = 0; i < num_subframes; i++ )

            for ( i = 0; i < (int16_t) num_subframes; i++ )

            {

                if ( ( error = IVAS_DEC_FeedHeadTrackData( hIvasDec, Quaternions[i], Pos[i], i, DEFAULT_AXIS ) ) != IVAS_ERR_OK )

                {
@@ -3443,7 +3446,7 @@ static ivas_error decodeVoIP( 
            int8_t enableRotationInterpolation[IVAS_MAX_PARAM_SPATIAL_SUBFRAMES];

            int16_t numFramesToTargetOrientation[IVAS_MAX_PARAM_SPATIAL_SUBFRAMES];



            for ( i = 0; i < num_subframes; i++ )

            for ( i = 0; i < (int16_t) num_subframes; i++ )

            {



                if ( ( error = ExternalOrientationFileReading( externalOrientationFileReader, &Quaternions[i], &enableHeadRotation[i], &enableExternalOrientation[i], &enableRotationInterpolation[i], &numFramesToTargetOrientation[i] ) ) != IVAS_ERR_OK )
@@ -3453,7 +3456,8 @@ static ivas_error decodeVoIP( 
                    goto cleanup;

                }

            }

            for ( i = 0; i < num_subframes; i++ )



            for ( i = 0; i < (int16_t) num_subframes; i++ )

            {

                if ( ( error = IVAS_DEC_FeedExternalOrientationData( hIvasDec, Quaternions[i], enableHeadRotation[i], enableExternalOrientation[i], enableRotationInterpolation[i], numFramesToTargetOrientation[i], i ) ) != IVAS_ERR_OK )

                {
@@ -4377,7 +4381,7 @@ static ivas_error restartDecoder( 


    IVAS_AUDIO_CONFIG outputConfig = ( decMode == IVAS_DEC_MODE_IVAS ) ? arg->outputConfig : IVAS_AUDIO_CONFIG_MONO;



    if ( ( error = IVAS_DEC_Configure( hIvasDec, arg->output_Fs, outputConfig, arg->renderFramesize, arg->customLsOutputEnabled, arg->hrtfReaderEnabled,

    if ( ( error = IVAS_DEC_Configure( hIvasDec, arg->output_Fs, outputConfig, arg->render_num_subframes, arg->customLsOutputEnabled, arg->hrtfReaderEnabled,

                                       arg->enableHeadRotation, arg->enableExternalOrientation, arg->orientation_tracking, arg->renderConfigEnabled, arg->roomSize, arg->non_diegetic_pan_enabled,

                                       arg->non_diegetic_pan_gain, arg->dpidEnabled, aeID, arg->objEditEnabled, arg->delayCompensationEnabled ) ) != IVAS_ERR_OK )

    {
@@ -4385,9 +4389,9 @@ static ivas_error restartDecoder( 
        goto cleanup;

    }



    if ( ( error = IVAS_DEC_GetRenderFramesize( hIvasDec, &arg->renderFramesize ) ) != IVAS_ERR_OK )

    if ( ( error = IVAS_DEC_GetRenderNumSubfr( hIvasDec, &arg->render_num_subframes ) ) != IVAS_ERR_OK )

    {

        fprintf( stderr, "\nConfigure failed: %s\n\n", IVAS_DEC_GetErrorMessage( error ) );

        fprintf( stderr, "\nIVAS_DEC_GetRenderNumSubfr failed: %s\n\n", IVAS_DEC_GetErrorMessage( error ) );

        goto cleanup;

    }
@@ -4410,7 +4414,7 @@ static ivas_error restartDecoder( 
     * This will be ignored if output format is not split rendering. */

    if ( renderConfig != NULL )

    {

        renderConfig->split_rend_config.isar_frame_size_ms = (int16_t) arg->renderFramesize /* given in number of 5ms subframes */ * 5;

        renderConfig->split_rend_config.isar_frame_size_ms = (int16_t) arg->render_num_subframes * 5;

    }



    if ( arg->renderConfigEnabled && renderConfig != NULL )

apps/isar_post_rend.c

+15 −15
Original line number Diff line number Diff line
@@ -31,8 +31,6 @@ 
*******************************************************************************************************/



#include "lib_isar_post_rend.h"





#include <assert.h>

#include <math.h>

#include <string.h>
@@ -113,7 +111,7 @@ typedef struct 
    bool delayCompensationEnabled;

    bool quietModeEnabled;

    bool sceneDescriptionInput;

    IVAS_RENDER_FRAMESIZE render_framesize;

    IVAS_RENDER_NUM_SUBFR render_num_subframes;

} CmdlnArgs;



typedef enum
@@ -338,28 +336,30 @@ static bool parseInConfig( 
}





static bool parseRenderFramesize(

static bool parseRenderNumSubfr(

    char *value,

    IVAS_RENDER_FRAMESIZE *render_framesize )

    IVAS_RENDER_NUM_SUBFR *render_num_subframes )

{

    int32_t tmp;



    *render_framesize = IVAS_RENDER_FRAMESIZE_UNKNOWN;

    *render_num_subframes = IVAS_RENDER_NUM_SUBFR_UNKNOWN;



    if ( !is_digits_only( value ) )

    {

        return false;

    }



    tmp = (int32_t) strtol( value, NULL, 0 );

    switch ( (int16_t) tmp )

    {

        case 5:

            *render_framesize = IVAS_RENDER_FRAMESIZE_5MS;

            *render_num_subframes = IVAS_RENDER_NUM_SUBFR_5MS;

            break;

        case 10:

            *render_framesize = IVAS_RENDER_FRAMESIZE_10MS;

            *render_num_subframes = IVAS_RENDER_NUM_SUBFR_10MS;

            break;

        case 20:

            *render_framesize = IVAS_RENDER_FRAMESIZE_20MS;

            *render_num_subframes = IVAS_RENDER_NUM_SUBFR_20MS;

            break;

        default:

            return false;
@@ -474,7 +474,7 @@ static CmdlnArgs defaultArgs( 
    args.quietModeEnabled = false;

    args.sceneDescriptionInput = false;



    args.render_framesize = IVAS_RENDER_FRAMESIZE_20MS;

    args.render_num_subframes = IVAS_RENDER_NUM_SUBFR_20MS;



    return args;

}
@@ -557,7 +557,7 @@ static void parseOption( 
            break;

        case CmdLnOptionId_framing:

            assert( numOptionValues == 1 );

            if ( !parseRenderFramesize( optionValues[0], &args->render_framesize ) )

            if ( !parseRenderNumSubfr( optionValues[0], &args->render_num_subframes ) )

            {

                fprintf( stderr, "Unknown or invalid option for frame size: %s\n", optionValues[0] );

                exit( -1 );
@@ -950,7 +950,7 @@ int main( 
        }

        audioReader = NULL;

        /* Force owerwrite of command line provided rendersize to align with codec frame size */

        args.render_framesize = bitsBuffer.config.isar_frame_size_ms / 5;

        args.render_num_subframes = bitsBuffer.config.isar_frame_size_ms / 5;

    }

    /*if split renderer is running in post renderer mode*/

    else if ( ( args.inConfig.numBinBuses > 0 ) && ( args.inConfig.binBuses[0].audioConfig == IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_CODED ) )
@@ -1022,9 +1022,9 @@ int main( 
     * Open ISAR handle

     *------------------------------------------------------------------------------------------*/



    const int16_t frameSize_smpls = (int16_t) ( ( args.render_framesize ) * args.sampleRate * 5 / ( 1000 ) );

    const int16_t frameSize_smpls = (int16_t) ( ( args.render_num_subframes ) * args.sampleRate * 5 / ( 1000 ) );

    args.outConfig.audioConfig = IVAS_AUDIO_CONFIG_BINAURAL;

    if ( ( error = ISAR_POST_REND_open( &hIsarPostRend, args.sampleRate, args.outConfig.audioConfig, true, 0, 0.0, (int16_t) args.render_framesize ) ) != IVAS_ERR_OK )

    if ( ( error = ISAR_POST_REND_open( &hIsarPostRend, args.sampleRate, args.outConfig.audioConfig, true, 0, 0.0, (int16_t) args.render_num_subframes ) ) != IVAS_ERR_OK )

    {

        fprintf( stderr, "\nError opening renderer handle: %s\n", ivas_error_to_string( error ) );

        goto cleanup;
@@ -1237,7 +1237,7 @@ int main( 
        convertInputBuffer( inpInt16Buffer, numSamplesRead, inBuffer.config.numSamplesPerChannel, num_in_channels, inFloatBuffer );



        int16_t num_subframes, sf_idx;

        num_subframes = (int16_t) args.render_framesize;

        num_subframes = (int16_t) args.render_num_subframes;



        /* Read from head rotation trajectory file if specified */

        if ( headRotReader != NULL )

apps/renderer.c

+15 −14
Original line number Diff line number Diff line
@@ -195,7 +195,7 @@ typedef struct 
    bool lfeCustomRoutingEnabled;

    char inLfePanningMatrixFile[RENDERER_MAX_CLI_ARG_LENGTH];

    int16_t syncMdDelay;

    IVAS_RENDER_FRAMESIZE render_framesize;

    IVAS_RENDER_NUM_SUBFR render_num_subframes;

    uint16_t directivityPatternId[RENDERER_MAX_ISM_INPUTS];

    AcousticEnvironmentSequence aeSequence;

    IVAS_ROOM_SIZE_T reverbRoomSize;
@@ -929,9 +929,9 @@ int main( 
        goto cleanup;

    }



    const int16_t frameSize_smpls = (int16_t) ( ( args.render_framesize ) * args.sampleRate * 5 / ( 1000 ) );

    const int16_t frameSize_smpls = (int16_t) ( ( args.render_num_subframes ) * args.sampleRate * BINAURAL_RENDERING_FRAME_SIZE_MS / ( 1000 ) );



    if ( ( error = IVAS_REND_Open( &hIvasRend, args.sampleRate, args.outConfig.audioConfig, !isEmptyString( args.customHrtfFilePath ), args.nonDiegeticPan, args.nonDiegeticPanGain, args.Opt_Headrotation, args.Opt_ExternalOrientation, (int16_t) args.render_framesize ) ) != IVAS_ERR_OK )

    if ( ( error = IVAS_REND_Open( &hIvasRend, args.sampleRate, args.outConfig.audioConfig, !isEmptyString( args.customHrtfFilePath ), args.nonDiegeticPan, args.nonDiegeticPanGain, args.Opt_Headrotation, args.Opt_ExternalOrientation, (int16_t) args.render_num_subframes ) ) != IVAS_ERR_OK )

    {

        fprintf( stderr, "\nError opening renderer handle: %s\n", ivas_error_to_string( error ) );

        goto cleanup;
@@ -1161,7 +1161,7 @@ int main( 


        /* ISAR frame size is set from command line, not renderer config file.

         * This will be ignored if output format is not split rendering. */

        renderConfig.split_rend_config.isar_frame_size_ms = (int16_t) args.render_framesize /* given in number of 5ms subframes */ * 5;

        renderConfig.split_rend_config.isar_frame_size_ms = (int16_t) args.render_num_subframes * BINAURAL_RENDERING_FRAME_SIZE_MS;



        if ( ( error = IVAS_REND_FeedRenderConfig( hIvasRend, renderConfig ) ) != IVAS_ERR_OK )

        {
@@ -1551,7 +1551,7 @@ int main( 
    {

        int16_t num_in_channels;

        num_in_channels = inBuffer.config.numChannels;

        const bool isCurrentFrameMultipleOf20ms = frame % ( 4 / args.render_framesize ) == 0;

        const bool isCurrentFrameMultipleOf20ms = frame % ( IVAS_RENDER_NUM_SUBFR_20MS / args.render_num_subframes ) == 0;



        if ( args.outConfig.audioConfig == IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB && renderConfigReader != NULL &&

             args.aeSequence.count > 0 && args.aeSequence.pValidity[args.aeSequence.selected] != 0 )
@@ -1609,7 +1609,7 @@ int main( 
        }



        int16_t num_subframes, sf_idx;

        num_subframes = (int16_t) args.render_framesize;

        num_subframes = (int16_t) args.render_num_subframes;



        if ( isCurrentFrameMultipleOf20ms && !flushRendererLastFrame )

        {
@@ -2331,28 +2331,29 @@ static bool parseDiegeticPan( 
}





static bool parseRenderFramesize(

static bool parseRenderNumSubfr(

    char *value,

    IVAS_RENDER_FRAMESIZE *render_framesize )

    IVAS_RENDER_NUM_SUBFR *render_num_subframes )

{

    int32_t tmp;



    *render_framesize = IVAS_RENDER_FRAMESIZE_UNKNOWN;

    *render_num_subframes = IVAS_RENDER_NUM_SUBFR_UNKNOWN;

    if ( !is_digits_only( value ) )

    {

        return false;

    }



    tmp = (int32_t) strtol( value, NULL, 0 );

    switch ( (int16_t) tmp )

    {

        case 5:

            *render_framesize = IVAS_RENDER_FRAMESIZE_5MS;

            *render_num_subframes = IVAS_RENDER_NUM_SUBFR_5MS;

            break;

        case 10:

            *render_framesize = IVAS_RENDER_FRAMESIZE_10MS;

            *render_num_subframes = IVAS_RENDER_NUM_SUBFR_10MS;

            break;

        case 20:

            *render_framesize = IVAS_RENDER_FRAMESIZE_20MS;

            *render_num_subframes = IVAS_RENDER_NUM_SUBFR_20MS;

            break;

        default:

            return false;
@@ -2724,7 +2725,7 @@ static CmdlnArgs defaultArgs( 


    args.lfeCustomRoutingEnabled = false;

    clearString( args.inLfePanningMatrixFile );

    args.render_framesize = IVAS_RENDER_FRAMESIZE_20MS;

    args.render_num_subframes = IVAS_RENDER_NUM_SUBFR_20MS;

    args.syncMdDelay = 0;



    for ( i = 0; i < RENDERER_MAX_ISM_INPUTS; ++i )
@@ -2896,7 +2897,7 @@ static void parseOption( 
            break;

        case CmdLnOptionId_framing:

            assert( numOptionValues == 1 );

            if ( !parseRenderFramesize( optionValues[0], &args->render_framesize ) )

            if ( !parseRenderNumSubfr( optionValues[0], &args->render_num_subframes ) )

            {

                fprintf( stderr, "Unknown or invalid option for frame size: %s\n", optionValues[0] );

                exit( -1 );

lib_com/common_api_types.h

+6 −5
Original line number Diff line number Diff line
@@ -168,12 +168,12 @@ typedef enum 


typedef enum

{

    IVAS_RENDER_FRAMESIZE_UNKNOWN = 0,

    IVAS_RENDER_FRAMESIZE_5MS = 1,

    IVAS_RENDER_FRAMESIZE_10MS = 2,

    IVAS_RENDER_FRAMESIZE_20MS = 4

    IVAS_RENDER_NUM_SUBFR_UNKNOWN = 0,

    IVAS_RENDER_NUM_SUBFR_5MS = 1,

    IVAS_RENDER_NUM_SUBFR_10MS = 2,

    IVAS_RENDER_NUM_SUBFR_20MS = 4



} IVAS_RENDER_FRAMESIZE;

} IVAS_RENDER_NUM_SUBFR;



typedef enum

{
@@ -181,6 +181,7 @@ typedef enum 
    IVAS_ROOM_SIZE_SMALL,

    IVAS_ROOM_SIZE_MEDIUM,

    IVAS_ROOM_SIZE_LARGE



} IVAS_ROOM_SIZE_T;



typedef struct ivas_masa_metadata_frame_struct *IVAS_MASA_METADATA_HANDLE;

lib_dec/ivas_init_dec.c

+2 −2
Original line number Diff line number Diff line
@@ -1306,7 +1306,7 @@ ivas_error ivas_init_decoder_front( 


    if ( st_ivas->hDecoderConfig->Opt_ExternalOrientation )

    {

        if ( ( error = ivas_external_orientation_open( &( st_ivas->hExtOrientationData ), st_ivas->hDecoderConfig->render_framesize ) ) != IVAS_ERR_OK )

        if ( ( error = ivas_external_orientation_open( &( st_ivas->hExtOrientationData ), st_ivas->hDecoderConfig->render_num_subframes ) ) != IVAS_ERR_OK )

        {

            return error;

        }
@@ -1318,7 +1318,7 @@ ivas_error ivas_init_decoder_front( 


    if ( st_ivas->hDecoderConfig->Opt_Headrotation || st_ivas->hDecoderConfig->Opt_ExternalOrientation )

    {

        if ( ( error = ivas_combined_orientation_open( &( st_ivas->hCombinedOrientationData ), st_ivas->hDecoderConfig->output_Fs, st_ivas->hDecoderConfig->render_framesize ) ) != IVAS_ERR_OK )

        if ( ( error = ivas_combined_orientation_open( &( st_ivas->hCombinedOrientationData ), st_ivas->hDecoderConfig->output_Fs, st_ivas->hDecoderConfig->render_num_subframes ) ) != IVAS_ERR_OK )

        {

            return error;

        }