Commit bdbd19ac authored by Jan Kiene's avatar Jan Kiene
Browse files

Merge branch 'increase-tolerance-for-renderer-equivalent-rotation-test-in-basop' into 'main' 

[CI] add increased tolerance in eq rotation test for BASOP

See merge request !2529
parents 5d3c7976 91f6edcd

tests/renderer_short/test_renderer.py

+10 −0
Original line number Diff line number Diff line
@@ -1863,6 +1863,15 @@ def test_multichannel_binaural_headrotation_refvec_rotating( 
    if test_info.config.option.create_ref or test_info.config.option.create_cut:

        pytest.skip("OTR tests only run for smoke test")



    # adjust tolerance for some BASOP cases where abs diff up to 4 is expected

    atol = 2

    if out_fmt in ["BINAURAL", "BINAURAL_ROOM_REVERB"] and in_fmt in [

        "5_1_2",

        "5_1_4",

        "7_1_4",

    ]:

        atol = 4



    compare_renderer_args(

        record_property,

        props_to_record,
@@ -1884,6 +1893,7 @@ def test_multichannel_binaural_headrotation_refvec_rotating( 
            "frame_size": "5",

        },

        split_comparison=split_comparison,

        atol=atol,

    )

tests/renderer_short/utils.py

+4 −1
Original line number Diff line number Diff line
@@ -499,6 +499,7 @@ def compare_renderer_args( 
    ref_kwargs: Dict,

    cut_kwargs: Dict,

    split_comparison=False,

    atol=2,

):

    out_file_ref = run_renderer(

        record_property,
@@ -520,7 +521,9 @@ def compare_renderer_args( 
        split_comparison=split_comparison,

    )

    cut, cut_fs = readfile(out_file_cut)

    [diff_found, snr, gain_b, max_diff] = check_BE(test_info, ref, ref_fs, cut, cut_fs)

    [diff_found, snr, gain_b, max_diff] = check_BE(

        test_info, ref, ref_fs, cut, cut_fs, atol

    )

    if diff_found:

        pytest.fail(

            f"CuT not BE to REF! SNR : {snr:3.2f} dB, Gain CuT: {gain_b:1.3f}, Max Diff = {int(max_diff)}"