Commit d55dc76f authored by vaclav's avatar vaclav
Browse files

revision of ToDo comments

parent 8b5159fb

apps/encoder.c

+1 −1
Original line number Diff line number Diff line
@@ -1476,7 +1476,7 @@ static bool parseCmdlIVAS_enc( 
            arg->inputFormatConfig.stereoToMonoDownmix = true;

            i++;

        }

        else if ( strcmp( argv_to_upper, "-BYPASS" ) == 0 ) // VE: should be renamed to "-pca"

        else if ( strcmp( argv_to_upper, "-BYPASS" ) == 0 ) // TODO: should be renamed to "-pca"

        {

            i++;

            if ( i < argc - 4 )

apps/renderer.c

+1 −1
Original line number Diff line number Diff line
@@ -965,7 +965,7 @@ int main( 
        else

        {

            error = IVAS_REND_SetHeadRotation( hIvasRend, NULL, NULL );

            if ( ( error != IVAS_ERR_OK ) && ( error != IVAS_ERR_INVALID_OUTPUT_FORMAT ) ) // VE: TBC

            if ( error != IVAS_ERR_OK && error != IVAS_ERR_INVALID_OUTPUT_FORMAT )

            {

                fprintf( stderr, "Error setting Head Rotation: %s\n", ivas_error_to_string( error ) );

                exit( -1 );

lib_com/bitstream.c

+0 −3
Original line number Diff line number Diff line
@@ -1839,9 +1839,6 @@ ivas_error preview_indices( 
                break;

            case SID_ISM:

                st_ivas->ivas_format = ISM_FORMAT;

                /* temporary hack to make mode signaling work with the current 1-object ISM DTX: read padding bits */

                /* Todo: how to apply this here? maybe pt_stream += ... would work? */

                /* st->bit_stream += ( IVAS_SID_4k4 - SID_2k40 ) / FRAMES_PER_SEC - SID_FORMAT_NBITS; */

                break;

            case SID_MULTICHANNEL:

                st_ivas->ivas_format = MC_FORMAT;

lib_com/ivas_cnst.h

+3 −3
Original line number Diff line number Diff line
@@ -865,7 +865,7 @@ typedef enum { 
/*----------------------------------------------------------------------------------*

 * General Parametric Coding Constants

 *----------------------------------------------------------------------------------*/

// VE: this should be renamed to e.g. N_SPATIAL_SUBFRAMES



#define MAX_PARAM_SPATIAL_SUBFRAMES             4                           /* Maximum number of subframes for parameteric spatial coding */

#define L_SPATIAL_SUBFR_48k                     (L_FRAME48k / MAX_PARAM_SPATIAL_SUBFRAMES)

#ifdef FIX_355_REFACTOR_PARAMBIN_TO_5MS
@@ -893,7 +893,7 @@ typedef enum 
{

    SBA_MODE_NONE,

    SBA_MODE_DIRAC,

    SBA_MODE_SPAR, // VE: this is actually SBA_MODE_SPAR_DIRAC

    SBA_MODE_SPAR,

} SBA_MODE;
@@ -1024,7 +1024,7 @@ typedef enum 


#define IVAS_SPAR_BR_TABLE_LEN                  20



/* TD decorr */ // VE: not all 16CH are currently supported -> t be revisited later

/* TD decorr */ // ToDo: not all 16CH are currently supported -> to be revisited later

enum

{

    IVAS_TD_DECORR_OUT_1CH = 1,

lib_com/ivas_pca_tools.c

+1 −1
Original line number Diff line number Diff line
@@ -645,7 +645,7 @@ static void norm_quat( 


    norm_q = dotp( q, q, IVAS_PCA_INTERP );



    norm_q = inv_sqrt( norm_q ); // VE: TBV: possible division by 0

    norm_q = inv_sqrt( norm_q ); // TBV: possible division by 0



    for ( i = 0; i < IVAS_PCA_INTERP; i++ )

    {