Skip to content

ToDo comments in floating-point framework

There are currently (as of April 16, 2024) the following todo comments in the floating-point framework that should be addressed:

  • lib_dec\dec_tcx.c(1551): if ( st->element_mode == EVS_MONO || L_spec < L_frameTCX ) /* todo: this is temporary to maintain EVS BE, this is a bug and should be fixed also for EVS (see issue 13) */
  • lib_dec\jbm_pcmdsp_apa.c(565): float frm_in[APA_BUF]; /* TODO(mcjbm): this buffer could be smaller - always allocates space for 16 channels */
  • lib_dec\swb_bwe_dec.c(270): /* IVAS_fmToDo: wtda() does not support L_FRAME length; thus temporarily resample the signal */
  • lib_dec\swb_bwe_dec.c(271): /* IVAS_fmToDo: delay output[] by 1.25ms ? */
  • lib_dec\swb_bwe_dec.c(589): /* todo - wtda() does not support L_FRAME length; thus temporarily resample the signal */
  • lib_dec\swb_bwe_dec.c(590): /* todo - delay output[] by 1.25ms ? */
  • lib_dec\swb_bwe_dec.c(737): /* IVAS_fmToDo: synth[] is @internal_Fs!!! */
  • lib_dec\ivas_binRenderer_internal.c(2018): /TODO : move this to a separate function/
  • lib_dec\ivas_dec.c(59): // TODO: move here function ivas_jbm_dec_tc() and rename it to ivas_dec()
  • lib_dec\ivas_ism_param_dec.c(759): // TODO tmu review when #215 is resolved
  • lib_dec\ivas_ism_param_dec.c(920): /TODO : FhG to check/
  • lib_dec\ivas_mct_dec.c(115): /* IVAS_fmToDo: more work needed for switching the number of transport channels */
  • lib_dec\ivas_objectRenderer_internal.c(310): Quat2EulerDegree( originalHeadRot[i], /* TODO tmu : fix bug with ordering*/
  • lib_dec\ivas_pca_dec.c(235): /* @@@TODO: check how ivas_total_brate is set if bfi == 1 */ // ToDo: and what happens in DTX where "ivas_total_brate" can be close to zero?
  • lib_dec\ivas_stereo_dft_dec.c(2404): /* IVAS_fmToDo: the assert has to be changed with proper bitstream error handling */
  • lib_dec\lib_dec.c(781): if ( !bfi ) /* TODO(mcjbm): Is this ok for bfi == 2 (partial frame)? Is there enough info to fully configure decoder? */
  • lib_dec\lib_dec.c(933): /* :TODO: change nSamplesAsked also if we are in 5ms 0dof split rendering... */
  • lib_dec\lib_dec.c(3691):// ToDo: currently unused
  • lib_enc\init_enc.c(714): // ToDo: reduction possible for MCT_CHAN_MODE_LFE channel
  • lib_enc\ivas_pca_enc.c(319): // ToDo: TBV
  • lib_enc\lib_enc.c(2052):#if 0 // IVAS_fmToDo: temporary disabled to keep EVS bit-exactness -> to be verified
  • lib_com\bitstream.c(3444): /* TODO: temporary hack, need to decide what to do with core-coder bitrate */
  • lib_com\ivas_stat_com.h(331): int16_t in_delay; /* TODO: JBM check if this needs to be adjusted in the dec */
  • lib_com\ivas_pca_tools.c(648): norm_q = inv_sqrt( norm_q ); // TODO: possible division by 0
  • lib_rend\ivas_objectRenderer.c(844): Quat2EulerDegree( originalHeadRot[i], /* TODO tmu : fix bug with ordering*/
  • lib_rend\ivas_splitRendererPost.c(1453): index_slot = slot_idx; /* TODO: can be cleaned up */
  • lib_rend\ivas_splitRendererPre.c(628): /TODO : change this function to real only as thats what is needed/
  • lib_rend\ivas_splitRendererPre.c(2243): /*TODO : shouldnt the delay be 7.5 ms ? 5ms + LC3plus delay */
  • lib_rend\ivas_lcld_rom_tables.h(41):#define M_PI 3.14159265358979323846264338327950288f // todo: replace by EVS_PI
  • lib_rend\ivas_prot_rend.h(1785):/* TODO(sgi): Rework interface */
  • lib_rend\lib_rend.c(4075):/* ToDo; unused function */
  • lib_rend\lib_rend.c(4194): /* TODO tmu : this function only returns the maximum delay across all inputs
  • lib_rend\lib_rend.c(4916):// ToDo: not used
  • lib_rend\lib_rend.c(4943):// ToDo: not used
  • lib_rend\lib_rend.c(5051):// ToDo: not used
  • lib_rend\lib_rend.c(5708): // TODO tmu review when #215 is resolved
  • lib_rend\lib_rend.c(5721): // TODO tmu review when #215 is resolved
  • lib_rend\lib_rend.c(5779): // TODO tmu review when #215 is resolved
  • lib_rend\lib_rend.c(5789): // TODO tmu review when #215 is resolved
  • lib_rend\lib_rend.c(7511): inAudio.config.numSamplesPerChannel * inAudio.config.numChannels ); /* TODO: the output buffer is empty at this point, should be moved to a point after decoding the split bitstream */
  • lib_util\cmdln_parser.c(76): /* TODO(sgi): Don't print out usage after this - props.match is used there */
  • lib_util\cmdln_parser.c(356): /* TODO(sgi): make matchShort optional */
  • lib_dec\ivas_stat_dec.h(931): float tc[MAX_OUTPUT_CHANNELS + MAX_NUM_OBJECTS]; / pointers into the buffer to the beginning of each tc */ // VE2SB: TBV
  • lib_dec\ivas_dirac_dec.c(1582): float output_f_local_buff[MAX_OUTPUT_CHANNELS][L_FRAME48k]; // VE2SB: TBV
  • lib_dec\ivas_objectRenderer_internal.c(255): float output_local[MAX_OUTPUT_CHANNELS][L_FRAME48k]; // VE2SB: TBV
  • lib_dec\ivas_osba_dec.c(137): float output_separated_objects[BINAURAL_CHANNELS][L_FRAME48k]; // VE2SB: TBV
  • lib_dec\ivas_sba_rendering_internal.c(361): float buffer_tmp[HOA3_CHANNELS][L_FRAME48k]; // VE2SB: TBV
  • lib_enc/ivas_dirac_enc.c(366): /* 1 bit to indicate mode MD coding : temp solution*/
  • lib_rend\ivas_stat_rend.h(40):#include "stat_com.h" /* Note: Currently needed for CLDFB. */
  • lib_rend\ivas_stat_rend.h(39):#include "ivas_stat_com.h" // note: needed for DIRAC_DEC_BIN_HANDLE until #156 (closed) is solved
  • lib_rend\ivas_prot_rend.h(41):#include "ivas_stat_dec.h" // Note: needed until #156 (closed) is resolved
  • lib_enc\lib_enc.c(374): /* Currently this is true but it is already shown in descriptive metadata that there can be inequality for this. */
  • lib_enc\lib_enc.c(577): /* Currently this is true but it is already shown in descriptive metadata that there can be inequality for this. */
  • lib_enc.c(1997): /* Currently settings can be changed only after configuration step */
  • lib_rend\ivas_reverb.c(98): /* Currently this is fixed to 2. */
  • lib_rend\ivas_reverb.c(100): /* In Matlab: [S x L] - Currently S=2, later may be more than 2 for speaker playback. */
  • [ ]
Edited by vaclav