Skip to content

MSAN/USAN: Uninitialized and Nan values in OSBA decoding to BINAURAL_ROOM_REVERB with JBM/frameloss

Basic info

Bug description

Clang USAN and MSAN sanitizer test in pipeline found an error:

USAN:

lib_com/tools.c:431:20: runtime error: -nan is outside the range of representable values of type 'short'
SUMMARY: UndefinedBehaviorSanitizer: float-cast-overflow lib_com/tools.c:431:20 in

MSAN:

==3592281==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x12215d4 in limiter_process /home/gitlab-runner/builds/EDkAKxT6/0/rep/ivas-codec-pc/ivas-codec/lib_com/ivas_limiter.c:265:18
    #1 0x1220c7e in ivas_limiter_dec /home/gitlab-runner/builds/EDkAKxT6/0/rep/ivas-codec-pc/ivas-codec/lib_com/ivas_limiter.c:207:5
    #2 0x7f8b88 in ivas_jbm_dec_render /home/gitlab-runner/builds/EDkAKxT6/0/rep/ivas-codec-pc/ivas-codec/lib_dec/ivas_jbm_dec.c:1520:13
    #3 0x4e8cc7 in IVAS_DEC_GetRenderedSamples /home/gitlab-runner/builds/EDkAKxT6/0/rep/ivas-codec-pc/ivas-codec/lib_dec/lib_dec.c:2030:13
    #4 0x4e80cb in IVAS_DEC_GetSamples /home/gitlab-runner/builds/EDkAKxT6/0/rep/ivas-codec-pc/ivas-codec/lib_dec/lib_dec.c:1613:28
    #5 0x4fe990 in IVAS_DEC_VoIP_GetSamples /home/gitlab-runner/builds/EDkAKxT6/0/rep/ivas-codec-pc/ivas-codec/lib_dec/lib_dec.c:3426:28
    #6 0x4b3df4 in decodeVoIP /home/gitlab-runner/builds/EDkAKxT6/0/rep/ivas-codec-pc/ivas-codec/apps/decoder.c:3376:28
    #7 0x4a5fdf in main /home/gitlab-runner/builds/EDkAKxT6/0/rep/ivas-codec-pc/ivas-codec/apps/decoder.c:841:17
    #8 0x7f3b33636d8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #9 0x7f3b33636e3f in __libc_start_main csu/../csu/libc-start.c:392:3
    #10 0x421534 in _start (/home/gitlab-runner/builds/EDkAKxT6/0/rep/ivas-codec-pc/ivas-codec/CLANG1/IVAS_dec+0x421534)

SUMMARY: MemorySanitizer: use-of-uninitialized-value /home/gitlab-runner/builds/EDkAKxT6/0/rep/ivas-codec-pc/ivas-codec/lib_com/ivas_limiter.c:265:18 in limiter_process
Exiting

Link to test pipeline: https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/jobs/326292

Ways to reproduce

Using the scripts:

head_rot_traj.csv

exof_traj.csv

dly_profile.dat

python3 scripts/IvasBuildAndRunChecks.py --checks CLANG3 CLANG1 -m OSBA_ISM1_FOA_b192_swb_cbr -p /path/to/my/local/ci_linux_ltv_local.json --usan_supp_file scripts/ubsan.supp -J dly_profile.dat -T head_rot_traj.csv -exof exof_traj.csv