Split rendering command line issues
The command line of the split rendering application suffers from a few issues:
1) Running an incomplete, e.g.
ISAR_post_rend.exe -i
results in an assertion.
-
A proper exit and printout of the help should be added.
2) Not all command line options are described in Readme.txt, namely -T, -no_delay_cmp, -level, -q, -l, -fr.
-
Readme.txt should be updated.
3) The output format mismatch between the decoder and post-renderer, e.g.
IVAS_dec.exe -om syn -t headrot_case00_3000_q.csv BINAURAL_SPLIT_PCM 48 bit syn.dec
IVAS_post_rend.exe -fs 48 -i syn -if BINAURAL_SPLIT_CODED -o syn.decSR -T rotate_euler_quaternion_5s.csv -fr 20
results in a crash:
Assertion failed: hSplitBin->hLc3plusDec != NULL, file ..\lib_isar\lib_isar_post_rend.c, line 1275
-
A sanity check and a proper exit should be added to prevent this crash.
4) Running the post-renderer from BINAURAL_SPLIT_CODED format without -fs X option, e.g.
IVAS_post_rend.exe -i syn.dec -if BINAURAL_SPLIT_CODED -o syn.decSR -T rotate_euler_quaternion_5s.csv -fr 20
results in an exit saying
Missing required argument: sample_rate (fs)
However, the help suggests that it is not a required option:
--sample_rate, -fs Input sampling rate in kHz (16, 32, 48) - required only with raw PCM inputs
-
Clarify -fs Xoption forBINAURAL_SPLIT_CODEDinput format
5) The command-line description in Readme.txt says
ISAR_post_rend [options]
while in TS26.258 it says
ISAR_post_rend [post-renderer options] -i < bitstream file or input file> -if < input format> -o < output file>
-
Description of the command-line should be harmonized; in addition, it would help to describe which parameters are mandatory and which are optional -
The ISAR post-renderer binary tool doesn't raise any warning or error when the error pattern file is not found. It silently continues with the processing of the input file. -
Is -T head-rotation input file mandatory? If not, listener position and head orientation should be properly reset