Binaural reverb in OMASA Disc mode
The binaural reverb module is not triggered when decoding/rendering OMASA Disc mode. I.e. for example using
ivas_cod.exe -ism_masa 1 2 NULL stv2MASA2TC48c.met 256000 48 stvOMASA_1ISM_2MASA2TC48c.wav bit
ivas_dec.exe BINAURAL_ROOM_REVERB 48 bit syn
the function ivas_reverb_open() is not entered at https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/blob/main/lib_dec/ivas_init_dec.c?ref_type=heads#L2222 (see also code coverage test at https://ivas-codec-pc.3gpp.org/ivas-codec/coverage/lib_dec/ivas_init_dec.c.gcov.html).
It is because renderer_type = RENDERER_BINAURAL_PARAMETRIC_ROOM while the function ivas_reverb_open() is within if ( renderer_type == RENDERER_BINAURAL_PARAMETRIC ) condition.
I am not sure what is the intended logic here and whether
- there is not a bug somewhere around
- it is an unused code - can it be removed?
- it is triggered only with the reverb config file parameters set to specific values - could a self-test condition to trigger the reverb module be added then?
Tagging @szczerba, @paulusj, @pihlajakuja.
Edited by vaclav