Skip to content

[CI]Renderer tests skip MASA + binaural room output

I noticed that there are some renderer cases being skipped for MASA + binaural room output, e.g. https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/blob/main/tests/renderer/test_renderer.py?ref_type=heads#L532:

    if out_fmt in ["BINAURAL_ROOM_IR", "BINAURAL_ROOM_REVERB"]:
        pytest.skip("Skipping binaural room outputs for MASA as unimplemented.")

I quickly checked

./IVAS_rend -if MASA1 -i scripts/testv/stv1MASA1TC48c.wav -im scripts/testv/stv1MASA1TC48c.met -o /tmp/out.wav -of BINAURAL_ROOM_IR
./IVAS_rend -if MASA1 -i scripts/testv/stv1MASA1TC48c.wav -im scripts/testv/stv1MASA1TC48c.met -o /tmp/out.wav -of BINAURAL_ROOM_REVERB

and both decode something reasonable.

Can these be un-skipped now?