Skip to content

Wrong indexing in ivas_masa_ext_rend_parambin_internal

Basic info

  • Commit SHA: main
  • Platform: all

Bug description

Noted in verification against ivas-float-update and BASOP, there is long persisting wrong indexing float code, see below

    ivas_dirac_dec_binaural_formulate_target_covariance_matrices( hDiracDecBin, hSpatParamRendCom, &config_data, Rmat, subframe,
                                                                  hCombinedOrientationData && hCombinedOrientationData->enableCombinedOrientation[subframe] > 0,
                                                                  subFrameTotalEne, IIReneLimiter, NULL );

    ivas_dirac_dec_binaural_determine_processing_matrices( hDiracDecBin, hSpatParamRendCom, &config_data, max_band_decorr, Rmat, subframe,
                                                           hCombinedOrientationData && hCombinedOrientationData->enableCombinedOrientation[hCombinedOrientationData->subframe_idx] > 0,
                                                           0, NULL );

Access to combinedOrientationData should follow the internal index so it works correctly with other than 20 ms output operation.