Skip to content

Memory error in (Planar)SBA with frameloss

Basic info

Bug description

Using the attached error pattern, there is a memory error found by Clang msan with the longer testvectors for SBA:

==161076==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x17a2f3e in hp20 /local/knj/ivas-codec/lib_com/hp50.c:128:14
    #1 0x6f5f1c in ivas_dec /local/knj/ivas-codec/lib_dec/ivas_dec.c:332:13
    #2 0x4c859b in IVAS_DEC_GetSamples /local/knj/ivas-codec/lib_dec/lib_dec.c:701:24
    #3 0x4b07e6 in decodeG192 /local/knj/ivas-codec/apps/decoder.c:1456:24
    #4 0x49d7f0 in main /local/knj/ivas-codec/apps/decoder.c:490:17
    #5 0x7fbee76e4d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09)
    #6 0x41f5a9 in _start (/local/knj/ivas-codec/CLANG1/IVAS_dec+0x41f5a9)

  Uninitialized value was stored to memory at
    #0 0x17a2bbe in hp20 /local/knj/ivas-codec/lib_com/hp50.c:122:12
    #1 0x6f5f1c in ivas_dec /local/knj/ivas-codec/lib_dec/ivas_dec.c:332:13
    #2 0x4c859b in IVAS_DEC_GetSamples /local/knj/ivas-codec/lib_dec/lib_dec.c:701:24
    #3 0x4b07e6 in decodeG192 /local/knj/ivas-codec/apps/decoder.c:1456:24
    #4 0x49d7f0 in main /local/knj/ivas-codec/apps/decoder.c:490:17
    #5 0x7fbee76e4d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09)

  Uninitialized value was stored to memory at
    #0 0x17a285c in hp20 /local/knj/ivas-codec/lib_com/hp50.c:119:12
    #1 0x6f5f1c in ivas_dec /local/knj/ivas-codec/lib_dec/ivas_dec.c:332:13
    #2 0x4c859b in IVAS_DEC_GetSamples /local/knj/ivas-codec/lib_dec/lib_dec.c:701:24
    #3 0x4b07e6 in decodeG192 /local/knj/ivas-codec/apps/decoder.c:1456:24
    #4 0x49d7f0 in main /local/knj/ivas-codec/apps/decoder.c:490:17
    #5 0x7fbee76e4d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09)

  Uninitialized value was stored to memory at
    #0 0x17a28d7 in hp20 /local/knj/ivas-codec/lib_com/hp50.c:120:12
    #1 0x6f5f1c in ivas_dec /local/knj/ivas-codec/lib_dec/ivas_dec.c:332:13
    #2 0x4c859b in IVAS_DEC_GetSamples /local/knj/ivas-codec/lib_dec/lib_dec.c:701:24
    #3 0x4b07e6 in decodeG192 /local/knj/ivas-codec/apps/decoder.c:1456:24
    #4 0x49d7f0 in main /local/knj/ivas-codec/apps/decoder.c:490:17
    #5 0x7fbee76e4d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09)

  Uninitialized value was stored to memory at
    #0 0x17a29e2 in hp20 /local/knj/ivas-codec/lib_com/hp50.c:121:12
    #1 0x6f5f1c in ivas_dec /local/knj/ivas-codec/lib_dec/ivas_dec.c:332:13
    #2 0x4c859b in IVAS_DEC_GetSamples /local/knj/ivas-codec/lib_dec/lib_dec.c:701:24
    #3 0x4b07e6 in decodeG192 /local/knj/ivas-codec/apps/decoder.c:1456:24
    #4 0x49d7f0 in main /local/knj/ivas-codec/apps/decoder.c:490:17
    #5 0x7fbee76e4d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09)

  Uninitialized value was stored to memory at
    #0 0xa7608c in ivas_sba_dirac_stereo_apply_td_stefi /local/knj/ivas-codec/lib_dec/ivas_sba_dirac_stereo_dec.c:617:26
    #1 0xa60a2f in ivas_sba_dirac_stereo_dec /local/knj/ivas-codec/lib_dec/ivas_sba_dirac_stereo_dec.c:994:9
    #2 0x6f5744 in ivas_dec /local/knj/ivas-codec/lib_dec/ivas_dec.c:316:13
    #3 0x4c859b in IVAS_DEC_GetSamples /local/knj/ivas-codec/lib_dec/lib_dec.c:701:24
    #4 0x4b07e6 in decodeG192 /local/knj/ivas-codec/apps/decoder.c:1456:24
    #5 0x49d7f0 in main /local/knj/ivas-codec/apps/decoder.c:490:17
    #6 0x7fbee76e4d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09)

  Uninitialized value was stored to memory at
    #0 0x1c73f82 in v_add /local/knj/ivas-codec/lib_com/tools.c:871:14
    #1 0xa606e9 in ivas_sba_dirac_stereo_dec /local/knj/ivas-codec/lib_dec/ivas_sba_dirac_stereo_dec.c:990:9
    #2 0x6f5744 in ivas_dec /local/knj/ivas-codec/lib_dec/ivas_dec.c:316:13
    #3 0x4c859b in IVAS_DEC_GetSamples /local/knj/ivas-codec/lib_dec/lib_dec.c:701:24
    #4 0x4b07e6 in decodeG192 /local/knj/ivas-codec/apps/decoder.c:1456:24
    #5 0x49d7f0 in main /local/knj/ivas-codec/apps/decoder.c:490:17
    #6 0x7fbee76e4d09 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d09)

Ways to reproduce

Using the scripts:

python3 scripts/IvasBuildAndRunChecks.py --checks CLANG1 -m PlanarSBA_b48_fb_cbr -p /path/to/my/local/ci_linux_ltv_local.json -f ep_015.g192

or directly:

make clean
make -j CLANG=1
./IVAS_cod -sba -3 -max_band fb 48000 48 ltv48_HOA3.wav bit
eid-xor -vbr -fer bit ep_015.g192 bit_fer
./IVAS_dec stereo 48 bit_fer out.wav

ep_015.g192