Skip to content

ISM metadata not used in Python based tests

Basic info

  • Commit SHA: b1ab3124
  • Platform: WSL/Ubuntu and Windows/Powershell tested

Bug description

It appears that the ISM metadata is not used in the tests based on runIvasCodec.py. This affects at least the smoke test and the complexity tests. As far as I can see, NULL metadata is used in this case which means the case of varying metadata is not included in these tests.

It seems that the setting of the metadata in e.g. https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/blob/main/scripts/config/ivas_modes.json#L2175-2180

            "in_config": "ISM4",
            "table_name": "ISM4@{table_bitrate} kbps {bandwidth}",
            "nummetadata": 4,
            "metadatafilenames": [
                "test_ISM_trajectory{mdi}.csv"
            ],

is not handled in the corresponding code in https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/blob/main/scripts/pyivastest/IvasModeRunner.py#L494-499

        metadata_file_names = []
        if isinstance(in_file_name, list):
            metadata_file_names = in_file_name[1:]
            in_file_name = in_file_name[0]
        elif self.global_metadata_file_list:
            metadata_file_names = deepcopy(self.global_metadata_file_list)

The metadata_file_names is then [] and NULL metadata is used.

Ways to reproduce

Assuming you have set up a ci_local.json to point to the eid-xor tool and the testv folder, you can run this command

./scripts/runIvasCodec.py -C ISM4 -p ci_local.json -U 1 --oc BINAURAL

Any use of the runIvasCodec.py without the flag --metadata_files should trigger the issue.