Skip to content

lib_rend.c: Leftovers of JBM_TSM_ON_TCS

In lib_rend.c, function renderIsmToBinauralReverb() there are two leftovers from the switch JBM_TSM_ON_TCS.

static ivas_error renderIsmToBinauralReverb(
    input_ism *ismInput,
    IVAS_REND_AudioBuffer outAudio )
{
#ifdef JBM_TSM_ON_TCS
    int16_t i;
#endif
    float tmpRendBuffer[MAX_OUTPUT_CHANNELS][L_FRAME48k];
    ivas_error error;
#ifdef JBM_TSM_ON_TCS
    float *p_tmpRendBuffer[MAX_OUTPUT_CHANNELS];

    for ( i = 0; i < MAX_OUTPUT_CHANNELS; i++ )
    {
        p_tmpRendBuffer[i] = tmpRendBuffer[i];
    }
#endif

    push_wmops( "renderIsmToBinauralRoom" );

    copyBufferTo2dArray( ismInput->base.inputBuffer, tmpRendBuffer );

    if ( ( error = ivas_td_binaural_renderer_ext( &ismInput->tdRendWrapper,
                                                  ismInput->base.inConfig,
                                                  NULL,
                                                  ismInput->base.ctx.pCombinedOrientationData,
                                                  &ismInput->currentPos,
                                                  ismInput->hReverb,
                                                  outAudio.config.numSamplesPerChannel,
                                                  tmpRendBuffer ) ) != IVAS_ERR_OK )
    {
        return error;
    }
    accumulate2dArrayToBuffer( tmpRendBuffer, &outAudio );
    pop_wmops();

    return IVAS_ERR_OK;
}

This was apparently already cleaned up by @multrus in a421d715 and then (I would assume by accident) introduced again by @stoutjesdijk in 468d3b1c

@bayers, @stoutjesdijk: Can we just accept this switch again?