Skip to content

add missing tables used for reverb in td renderer path

Basic info

  • Commit SHA: current main ( e.g 640e85a7)
  • Platform: all

Bug description

In the TD renderer path for reverb, rom tables for 32kHz and 16kHz are missing. The codec uses the 48kHz tables for all sampling rates which is not correct.

There was also a bug in the precomputation of the 48kHz rom tables orange53_left_avg_power, orange53_right_avg_power and orange53_coherence. These need to be updated.

Ways to reproduce

See line https://forge.3gpp.org/rep/ivas-codec-pc/ivas-codec/-/blob/main/lib_rend/ivas_reverb.c#L1001

run

IVAS_cod.exe -ISM 1 ../testv/stvISM1.csv 48000 48 ism1_speech.wav bit
IVAS_dec.exe BINAURAL_ROOM_REVERB 48 bit ism1_speech_48br_48kHz_reverb.wav

and

IVAS_cod.exe -ISM 1 ../testv/stvISM1.csv 48000 32 ism1_speech.wav bit
IVAS_dec.exe BINAURAL_ROOM_REVERB 32 bit ism1_speech_48br_32kHz_reverb.wav

The same tables are used for both 48kHz and 32kHz.