Skip to content

RenderConfigReader_read(): Mismatch definition <-> declaration

There is a mismatch between declaration and definition of the function RenderConfigReader_read():

Decaration in render_config_reader.h:

ivas_error RenderConfigReader_read(
#ifdef CONTROL_METADATA_REVERB
    RenderConfigReader *pRenderConfigReader, /* i  : RenderConfigReader handle              */
    const char *pRenderConfigPath            /* i  : Renderer configuration file path       */
#if ( defined SPLIT_REND_WITH_HEAD_ROT ) || ( defined DEBUGGING )
    ,
    IVAS_RENDER_CONFIG_HANDLE hRenderConfig /* o  : Renderer configuration handle          */
#endif
#else
    RenderConfigReader *pRenderConfigReader, /* i  : RenderConfigReader handle              */
    IVAS_RENDER_CONFIG_HANDLE hRenderConfig  /* o  : Renderer configuration handle          */
#endif
);

Definition in render_config_reader.h:

ivas_error RenderConfigReader_read(
#ifdef CONTROL_METADATA_REVERB
    RenderConfigReader *pRenderConfigReader, /* i  : RenderConfigReader handle              */
    const char *pRenderConfigPath,           /* i  : Renderer configuration file path       */
    IVAS_RENDER_CONFIG_HANDLE hRenderConfig  /* o  : Renderer configuration handle          */
#else
    RenderConfigReader *pRenderConfigReader, /* i  : RenderConfigReader handle              */
    IVAS_RENDER_CONFIG_HANDLE hRenderConfig  /* o  : Renderer configuration handle          */
#endif
)

As soon as we start to strip code within SPLIT_REND_WITH_HEAD_ROT and DEBUGGING this becomes a problem. From looking at the function calls, I believe the version of the definition to correct.