TODO Comments in Framework (Dolby)
Moving TODO comments Dolby will take a look at to this issue.
SBA
-
..\lib_dec\ivas_sba_rendering_internal.c(304): // TODO tmu review when #215 is resolved -- Keep -
..\lib_dec\ivas_sba_dec.c(158): if ( st_ivas->hDirAC == NULL && st_ivas->hSpar != NULL ) // ToDo; this never happens -
..\lib_enc\ivas_dirac_enc.c(197): /* :TODO: if the number of parameter bands change, do a meaningful mapping of parameter buffers from old to new band setting */ -
..\lib_enc\ivas_sba_enc.c(288): max_md_bits = min( st_ivas->hQMetaData->metadata_max_bits + 1, max_bits ); // TODO: remove 500 once max MD bits has been defined at all bitrates in DirAC -- Keep -
..\lib_com\ivas_dirac_com.c(172): if ( enc_dec == ENC || ( ivas_format != SBA_FORMAT && ivas_format != SBA_ISM_FORMAT ) ) /* Todo: This condition should probably be corrected in main */
Split Rendering
-
..\lib_rend\ivas_lcld_decoder.c(49):#define DECODER_ERROR_NONE ( 0 ) // todo: not really used -
..\lib_rend\ivas_lcld_encoder.c(48):#define ENCODER_ERROR_NONE ( 0 ) // todo: not really used -
..\lib_rend\ivas_lcld_encoder.c(814): float fPhase = (float) atan2( fLRCovImag, fLRCovReal ); // ToDo: replace by atan2f() -
..\lib_rend\ivas_lcld_encoder.c(1341): { // don't need // ToDo ? -
..\lib_rend\ivas_NoiseGen.c(48):// todo: not used!! -- Keep -
..\lib_rend\ivas_splitRendererPre.c(2524): /*TODO: do this inside the LCLD ENC codec */ -
..\lib_rend\ivas_cldfb_codec_bitstream.h(42):// ToDo: file can be removed if SIMPLE_PHASE is removed -
..\lib_rend\ivas_lcld_rom_tables.h(41):#define M_PI 3.14159265358979323846264338327950288f // todo: replace by EVS_PI -- Keep -
..\lib_rend\ivas_splitRendererPost.c(253):// ToDo: unused function
Edited by jtorr