Skip to content

SPAR code redundancies

I have identified several redundancies in the SBA SPAR related code and marked them by comments starting with "// VE2DB:" in MR !104 (merged).

Namely:

  • ivas_spar_md_dec.c(442): hMdDec->spar_md_cfg.gen_bs = 1; // VE2DB : always 1 - can it be removed?
  • ivas_spar_md_dec.c(670): /* SPAR to DirAC and DirAC to SPAR conversion */ // VE2DB: -> "DirAC to SPAR conversion" only?
  • ivas_spar_md_dec.c(671): if ( st_ivas->sba_mode == SBA_MODE_SPAR ) // VE2DB: this looks obsolete
  • ivas_spar_md_dec.c(1347): int16_t fb_ducking_flag = 0; // VE2DB: always 0 - can it be removed?
  • ivas_spar_encoder.c(611): dtx_silence_mode = 0; // VE2DB: this variable is always 0 - please review or remove it
  • ivas_spar_encoder.c(682): if ( st_ivas->sba_mode == SBA_MODE_SPAR ) // VE2DB: this looks obsolete

Please review them.