Skip to content

Obsolete call of ivas_ls_setup_conversion() in stereo

There is an obsolete call of function ivas_ls_setup_conversion() in ivas_jbm_dec_tc():

    else if ( st_ivas->ivas_format == STEREO_FORMAT )
    {
        . . .
        if ( st_ivas->renderer_type == RENDERER_MC && st_ivas->hDecoderConfig->nchan_out == 1 )
        {
            ivas_ls_setup_conversion( st_ivas, st_ivas->nchan_transport, output_frame, p_output, p_output );
        }
    }

The if() condition above is never true, so this call can be cleaned out. See also the code coverage at https://ivas-codec-pc.3gpp.org/ivas-codec/coverage/lib_dec/ivas_jbm_dec.c.gcov.html.

Note that this function is called later on in ivas_jbm_dec_render() as follows:

    else if ( st_ivas->ivas_format == STEREO_FORMAT )
    {
        /* Rendering */
        if ( st_ivas->renderer_type == RENDERER_MC )
        {
            *nSamplesRendered = min( st_ivas->hTcBuffer->n_samples_available, nSamplesAskedLocal );
            ivas_ls_setup_conversion( st_ivas, st_ivas->nchan_transport, *nSamplesRendered, p_tc, p_output );
        }
}