From b0fe2ae81c208c65cf6a973bf0e530fafc49a1a4 Mon Sep 17 00:00:00 2001 From: vaclav Date: Tue, 24 Oct 2023 16:47:55 +0200 Subject: [PATCH 1/8] accept FIX_820_DOUBLE_PREC_MACROS --- lib_com/ivas_prot.h | 8 -------- lib_com/options.h | 1 - 2 files changed, 9 deletions(-) diff --git a/lib_com/ivas_prot.h b/lib_com/ivas_prot.h index 1cbac362b6..c1e1264df9 100755 --- a/lib_com/ivas_prot.h +++ b/lib_com/ivas_prot.h @@ -4682,19 +4682,11 @@ void ivas_td_decorr_APD_iir_filter( out1_re = ( in1_re * in2_re ) - ( in1_im * in2_im ); MAC(1); MULT(1); \ out1_im = ( in1_re * in2_im ) + ( in2_re * in1_im ); MAC(1); MULT(1); -#ifdef FIX_820_DOUBLE_PREC_MACROS #define IVAS_CALCULATE_ABS( re, im, out ) \ out = sqrtf( ( re * re ) + ( im * im ) ); MAC(1); MULT(1); SQRT(1); #define IVAS_CALCULATE_RABS( re, out ) \ out = sqrtf( re * re ); MULT(1); SQRT(1); -#else -#define IVAS_CALCULATE_ABS( re, im, out ) \ - out = (float) sqrt( ( re * re ) + ( im * im ) ); MAC(1); MULT(1); SQRT(1); - -#define IVAS_CALCULATE_RABS( re, out ) \ - out = (float) sqrt( re * re ); MULT(1); SQRT(1); -#endif #define IVAS_CALCULATE_SQ_ABS( re, im, out ) \ out = (float) ( ( re * re ) + ( im * im ) ); MAC(1); MULT(1); diff --git a/lib_com/options.h b/lib_com/options.h index b922b13398..47bcd9a585 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -150,7 +150,6 @@ /*#define FIX_I4_OL_PITCH*/ /* fix open-loop pitch used for EVS core switching */ /*#define SPLIT_REND_WITH_HEAD_ROT */ /* Dlb,FhG: Split Rendering contributions 21 and 35 */ -#define FIX_820_DOUBLE_PREC_MACROS /* VA: issue 820: Double precision arithmetic in IVAS_CALCULATE_ABS() */ #define FIX_814_DOUBLE_PREC_IN_REVERB /* Philips: Issue 814: Replace double precision arithmetic in reverb */ #define FIX_866_MOVE_VBAP /* Nokia: Issue 866: Move VBAP to lib_rend */ #define FIX_863_REMOVE_REDUNDANCIES_OMASA /* Nokia/VA: Issue 863: Remove redundancies in stereo_classifier for OMASA */ -- GitLab From 852a2dbac341334febccbac78315967cd2c8e18b Mon Sep 17 00:00:00 2001 From: vaclav Date: Tue, 24 Oct 2023 16:48:49 +0200 Subject: [PATCH 2/8] accept FIX_814_DOUBLE_PREC_IN_REVERB --- lib_com/options.h | 1 - lib_dec/ivas_binRenderer_internal.c | 19 ------------------- lib_rend/ivas_reverb.c | 5 ----- lib_rend/ivas_reverb_filter_design.c | 8 -------- 4 files changed, 33 deletions(-) diff --git a/lib_com/options.h b/lib_com/options.h index 47bcd9a585..1e6d52ede7 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -150,7 +150,6 @@ /*#define FIX_I4_OL_PITCH*/ /* fix open-loop pitch used for EVS core switching */ /*#define SPLIT_REND_WITH_HEAD_ROT */ /* Dlb,FhG: Split Rendering contributions 21 and 35 */ -#define FIX_814_DOUBLE_PREC_IN_REVERB /* Philips: Issue 814: Replace double precision arithmetic in reverb */ #define FIX_866_MOVE_VBAP /* Nokia: Issue 866: Move VBAP to lib_rend */ #define FIX_863_REMOVE_REDUNDANCIES_OMASA /* Nokia/VA: Issue 863: Remove redundancies in stereo_classifier for OMASA */ #define FIX_879_USAN_ERROR_IN_MASA_DECODING /* FhG: Issue 879 : avoid arithmetic with NULL pointer in the DirAC decoder to fix USAN error */ diff --git a/lib_dec/ivas_binRenderer_internal.c b/lib_dec/ivas_binRenderer_internal.c index 05c81f91ed..ae8ea8cd8c 100644 --- a/lib_dec/ivas_binRenderer_internal.c +++ b/lib_dec/ivas_binRenderer_internal.c @@ -184,7 +184,6 @@ static ivas_error ivas_binRenderer_convModuleOpen( { hBinRenConvModule->numTapsArray[bandIdx] = hBinRenConvModule->numTaps; } -#ifdef FIX_814_DOUBLE_PREC_IN_REVERB for ( ; bandIdx < 10; bandIdx++ ) { hBinRenConvModule->numTapsArray[bandIdx] = (int16_t) ceilf( 0.6f * hBinRenConvModule->numTaps ); @@ -201,24 +200,6 @@ static ivas_error ivas_binRenderer_convModuleOpen( { hBinRenConvModule->numTapsArray[bandIdx] = (int16_t) ceilf( 0.3f * hBinRenConvModule->numTaps ); } -#else - for ( ; bandIdx < 10; bandIdx++ ) - { - hBinRenConvModule->numTapsArray[bandIdx] = (int16_t) ceil( 0.6f * hBinRenConvModule->numTaps ); - } - for ( ; bandIdx < 20; bandIdx++ ) - { - hBinRenConvModule->numTapsArray[bandIdx] = (int16_t) ceil( 0.5f * hBinRenConvModule->numTaps ); - } - for ( ; bandIdx < 30; bandIdx++ ) - { - hBinRenConvModule->numTapsArray[bandIdx] = (int16_t) ceil( 0.4f * hBinRenConvModule->numTaps ); - } - for ( ; bandIdx < hBinRenderer->conv_band; bandIdx++ ) - { - hBinRenConvModule->numTapsArray[bandIdx] = (int16_t) ceil( 0.3f * hBinRenConvModule->numTaps ); - } -#endif } else { diff --git a/lib_rend/ivas_reverb.c b/lib_rend/ivas_reverb.c index 8c962c11eb..537ecde2c2 100644 --- a/lib_rend/ivas_reverb.c +++ b/lib_rend/ivas_reverb.c @@ -1201,13 +1201,8 @@ ivas_error ivas_reverb_open( /* Defining appropriate windowing parameters for FFT filters to prevent aliasing */ fft_hist_size = pState->fft_size - pState->fft_subblock_size; -#ifdef FIX_814_DOUBLE_PREC_IN_REVERB transition_start = (int16_t) roundf( FFT_FILTER_WND_FLAT_REGION * fft_hist_size ); transition_length = (int16_t) roundf( FFT_FILTER_WND_TRANS_REGION * fft_hist_size ); -#else - transition_start = (int16_t) round( FFT_FILTER_WND_FLAT_REGION * fft_hist_size ); - transition_length = (int16_t) round( FFT_FILTER_WND_TRANS_REGION * fft_hist_size ); -#endif /* Compute the window used for FFT filters */ ivas_reverb_define_window_fft( pTime_window, transition_start, transition_length, nr_fc_fft_filter ); diff --git a/lib_rend/ivas_reverb_filter_design.c b/lib_rend/ivas_reverb_filter_design.c index 256b0772a0..2c4dc75303 100644 --- a/lib_rend/ivas_reverb_filter_design.c +++ b/lib_rend/ivas_reverb_filter_design.c @@ -587,11 +587,7 @@ void ivas_reverb_calc_color_levels( /* Limiting the frequency response gradients Find frequency band closest to chosen pivot frequency. */ -#ifdef FIX_814_DOUBLE_PREC_IN_REVERB idx_pivot = (int16_t) roundf( STEP_LIMIT_PIVOT_FREQ / freq_step ); -#else - idx_pivot = (int16_t) round( STEP_LIMIT_PIVOT_FREQ / freq_step ); -#endif /* Perform step limiting */ response_step_limit( pTarget_color_L, freq_count, RESPONSE_STEP_LIMIT_LF, RESPONSE_STEP_LIMIT_HF, idx_pivot ); @@ -727,11 +723,7 @@ void ivas_reverb_get_hrtf_set_properties( } else { -#ifdef FIX_814_DOUBLE_PREC_IN_REVERB base_idx = (int16_t) floorf( tbl_index ); -#else - base_idx = (int16_t) floor( tbl_index ); -#endif relative_pos = tbl_index - base_idx; if ( base_idx > ( in_freq_count - 2 ) ) /* In case of extrapolation (above last bin), choose nearest */ { -- GitLab From a8a15539f3862df1a378f656c1c7ab034c1d5649 Mon Sep 17 00:00:00 2001 From: vaclav Date: Tue, 24 Oct 2023 16:50:29 +0200 Subject: [PATCH 3/8] accept FIX_866_MOVE_VBAP --- lib_com/ivas_prot.h | 29 ++--------------------------- lib_com/options.h | 1 - lib_rend/ivas_prot_rend.h | 4 ++-- 3 files changed, 4 insertions(+), 30 deletions(-) diff --git a/lib_com/ivas_prot.h b/lib_com/ivas_prot.h index c1e1264df9..4502f8dd6a 100755 --- a/lib_com/ivas_prot.h +++ b/lib_com/ivas_prot.h @@ -5349,15 +5349,10 @@ void ivas_ism2sba_sf( const int16_t sba_order /* i : Ambisonic (SBA) order */ ); -#ifndef FIX_866_MOVE_VBAP -/*----------------------------------------------------------------------------------* - * Amplitude Panning tool prototypes - *----------------------------------------------------------------------------------*/ -#else + /*----------------------------------------------------------------------------------* * Amplitude Panning VBAP prototypes *----------------------------------------------------------------------------------*/ -#endif void panning_wrap_angles( const float azi_deg, /* i : azimuth in degrees for panning direction (positive left) */ @@ -5365,27 +5360,6 @@ void panning_wrap_angles( float *azi_wrapped, /* o : wrapped azimuth component */ float *ele_wrapped /* o : wrapped elevation component */ ); -#ifndef FIX_866_MOVE_VBAP -ivas_error vbap_init_data( - VBAP_HANDLE *hVBAPdata, /* i/o: handle for VBAP data structure that will be initialized */ - const float *speaker_node_azi_deg, /* i : vector of speaker node azimuths (positive left) */ - const float *speaker_node_ele_deg, /* i : vector of speaker node elevations (positive up) */ - const int16_t num_speaker_nodes, /* i : number of speaker nodes in the set */ - const IVAS_FORMAT ivas_format /* i : IVAS format */ -); - -void vbap_free_data( - VBAP_HANDLE *hVBAPdata /* i/o: VBAP handle to be freed */ -); - -void vbap_determine_gains( - const VBAP_HANDLE hVBAPdata, /* i : VBAP structure */ - float *gains, /* o : gain vector for speaker nodes for given direction */ - const int16_t azi_deg, /* i : azimuth in degrees for panning direction (positive left) */ - const int16_t ele_deg, /* i : elevation in degrees for panning direction (positive up) */ - const int16_t use_object_mode /* i : select between object mode panning and spatial mode panning */ -); -#endif void v_sort_ind( float *x, /* i/o: Vector to be sorted */ @@ -5393,6 +5367,7 @@ void v_sort_ind( const int16_t len /* i : vector length */ ); + /*----------------------------------------------------------------------------------* * LS Renderer prototypes *----------------------------------------------------------------------------------*/ diff --git a/lib_com/options.h b/lib_com/options.h index 1e6d52ede7..a5835e1b10 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -150,7 +150,6 @@ /*#define FIX_I4_OL_PITCH*/ /* fix open-loop pitch used for EVS core switching */ /*#define SPLIT_REND_WITH_HEAD_ROT */ /* Dlb,FhG: Split Rendering contributions 21 and 35 */ -#define FIX_866_MOVE_VBAP /* Nokia: Issue 866: Move VBAP to lib_rend */ #define FIX_863_REMOVE_REDUNDANCIES_OMASA /* Nokia/VA: Issue 863: Remove redundancies in stereo_classifier for OMASA */ #define FIX_879_USAN_ERROR_IN_MASA_DECODING /* FhG: Issue 879 : avoid arithmetic with NULL pointer in the DirAC decoder to fix USAN error */ diff --git a/lib_rend/ivas_prot_rend.h b/lib_rend/ivas_prot_rend.h index 4f2044ad50..5abd6b000d 100644 --- a/lib_rend/ivas_prot_rend.h +++ b/lib_rend/ivas_prot_rend.h @@ -133,7 +133,7 @@ void efap_determine_gains( const float ele_deg, /* i : elevation in degrees for panning direction (positive up) */ const int16_t efap_mode /* i : indicates whether EFAP or EFIP is used */ ); -#ifdef FIX_866_MOVE_VBAP + /*----------------------------------------------------------------------------------* * Amplitude Panning VBAP prototypes @@ -158,7 +158,7 @@ void vbap_determine_gains( const int16_t ele_deg, /* i : elevation in degrees for panning direction (positive up) */ const int16_t use_object_mode /* i : select between object mode panning and spatial mode panning */ ); -#endif + /*----------------------------------------------------------------------------------* * DirAC/MASA rendering -- GitLab From f571822880a9b250ff6989f7556e463daa2b7f9e Mon Sep 17 00:00:00 2001 From: vaclav Date: Tue, 24 Oct 2023 16:52:03 +0200 Subject: [PATCH 4/8] accept FIX_863_REMOVE_REDUNDANCIES_OMASA --- lib_com/options.h | 1 - lib_enc/ivas_masa_enc.c | 5 +---- lib_enc/ivas_stereo_classifier.c | 5 +---- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/lib_com/options.h b/lib_com/options.h index a5835e1b10..cf08df5396 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -150,7 +150,6 @@ /*#define FIX_I4_OL_PITCH*/ /* fix open-loop pitch used for EVS core switching */ /*#define SPLIT_REND_WITH_HEAD_ROT */ /* Dlb,FhG: Split Rendering contributions 21 and 35 */ -#define FIX_863_REMOVE_REDUNDANCIES_OMASA /* Nokia/VA: Issue 863: Remove redundancies in stereo_classifier for OMASA */ #define FIX_879_USAN_ERROR_IN_MASA_DECODING /* FhG: Issue 879 : avoid arithmetic with NULL pointer in the DirAC decoder to fix USAN error */ /* #################### End BE switches ################################## */ diff --git a/lib_enc/ivas_masa_enc.c b/lib_enc/ivas_masa_enc.c index feff99a7d2..6019ee03cc 100644 --- a/lib_enc/ivas_masa_enc.c +++ b/lib_enc/ivas_masa_enc.c @@ -1983,11 +1983,8 @@ void ivas_masa_enc_reconfigure( copy_encoder_config( st_ivas, st_ivas->hCPE[cpe_id]->hCoreCoder[n], 0 ); st_ivas->hCPE[cpe_id]->hCoreCoder[n]->total_brate = st_ivas->hCPE[cpe_id]->element_brate / ( st_ivas->nCPE > 1 ? 1 : CPE_CHANNELS ); /* dummy initialization for getting right pointers initialization of input buffers in init_coder_ace_plus() */ } -#ifdef FIX_863_REMOVE_REDUNDANCIES_OMASA + if ( ivas_total_brate - ism_total_brate < MIN_BRATE_MDCT_STEREO ) -#else - if ( ivas_total_brate - ism_total_brate < MASA_STEREO_MIN_BITRATE || ivas_total_brate - ism_total_brate < MIN_BRATE_MDCT_STEREO ) -#endif { st_ivas->hCPE[cpe_id]->element_mode = IVAS_CPE_DFT; } diff --git a/lib_enc/ivas_stereo_classifier.c b/lib_enc/ivas_stereo_classifier.c index 5f77e70cbd..01e7efba6e 100644 --- a/lib_enc/ivas_stereo_classifier.c +++ b/lib_enc/ivas_stereo_classifier.c @@ -124,11 +124,8 @@ int16_t select_stereo_mode( { stereo_switching_flag = 0; } -#ifdef FIX_863_REMOVE_REDUNDANCIES_OMASA + if ( hCPE->element_brate >= MIN_BRATE_MDCT_STEREO ) -#else - if ( hCPE->element_brate >= MIN_BRATE_MDCT_STEREO && !( hCPE->element_brate == IVAS_48k && ivas_total_brate == IVAS_32k ) ) /* the second condition for PARAM mode OMASA */ -#endif { hStereoClassif->prev_lrtd_mode = 0; hStereoClassif->lrtd_mode = 0; -- GitLab From 1187628002d5fecede0047f8239ddc490edf67ec Mon Sep 17 00:00:00 2001 From: vaclav Date: Tue, 24 Oct 2023 16:53:12 +0200 Subject: [PATCH 5/8] accept FIX_863_REMOVE_REDUNDANCIES_OMASA --- lib_com/options.h | 1 - lib_enc/ivas_stereo_classifier.c | 9 --------- 2 files changed, 10 deletions(-) diff --git a/lib_com/options.h b/lib_com/options.h index cf08df5396..fa067d94f3 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -161,7 +161,6 @@ #define NONBE_FIX_856_TCX_LTP_SYNTH_FILTER /* FhG: issue 856: correct filtering length for tcx-ltp synth filtering*/ #define NONBE_UNIFIED_DECODING_PATHS /* FhG: unify decoding paths */ -#define NONBE_FIX_861_MASA_CRASH_STEREO_SWITCHING /* VA: issue 861: fix MASA 2TC crash when switching from MDCT stereo to TD/DFT stereo */ #define BE_FIX_867_PARAMC_RECONFIG /* FhG: issue #867: fix ParamMC CLDFB buffer dealloc when reconfiguring */ #define NONBE_FIX_850_MASA_HBR_META_RATIO_DECODING /* Nokia: issue #850: Fixes rare non-valid diffuseness and energy ratio values in 2dir MASA. */ #define NONBE_FIX_MDCT_STEREO_DTX_MONO_OUT /* FhG: fix clicks in DTX -> active transition frames in MDCT-Stereo with mono output */ diff --git a/lib_enc/ivas_stereo_classifier.c b/lib_enc/ivas_stereo_classifier.c index 01e7efba6e..4735aaa582 100644 --- a/lib_enc/ivas_stereo_classifier.c +++ b/lib_enc/ivas_stereo_classifier.c @@ -112,11 +112,7 @@ int16_t select_stereo_mode( stereo_switching_flag = 1; -#ifdef NONBE_FIX_861_MASA_CRASH_STEREO_SWITCHING if ( hCPE->element_brate >= MIN_BRATE_MDCT_STEREO || ( ( ivas_format == MASA_FORMAT || ivas_format == MASA_ISM_FORMAT ) && ivas_total_brate < MASA_STEREO_MIN_BITRATE ) -#else - if ( hCPE->element_brate >= MIN_BRATE_MDCT_STEREO || ( ivas_format >= MASA_FORMAT && ivas_total_brate < MASA_STEREO_MIN_BITRATE ) -#endif #ifdef DEBUGGING || ( hCPE->stereo_mode_cmdl == IVAS_CPE_DFT || hCPE->stereo_mode_cmdl == IVAS_CPE_TD ) #endif @@ -136,12 +132,7 @@ int16_t select_stereo_mode( hStereoClassif->lrtd_mode = 0; element_mode = IVAS_CPE_DFT; - -#ifdef NONBE_FIX_861_MASA_CRASH_STEREO_SWITCHING if ( stereo_switching_flag == 1 && hCPE->element_brate > IVAS_13k2 && hCPE->hCoreCoder[0]->hSpMusClas->past_dlp[0] < 1.0f && hCPE->hCoreCoder[0]->hSpMusClas->wdlp_xtalk < -0.01f && hCPE->hCoreCoder[0]->vad_flag == 1 && ( hCPE->hStereoMdct->sw_uncorr || hStereoClassif->xtalk_decision ) ) -#else - if ( hCPE->element_brate > IVAS_13k2 && hCPE->hCoreCoder[0]->hSpMusClas->past_dlp[0] < 1.0f && hCPE->hCoreCoder[0]->hSpMusClas->wdlp_xtalk < -0.01f && hCPE->hCoreCoder[0]->vad_flag == 1 && ( hCPE->hStereoMdct->sw_uncorr || hStereoClassif->xtalk_decision ) ) -#endif { hStereoClassif->lrtd_mode = 1; element_mode = IVAS_CPE_TD; -- GitLab From e4276c5a5dc62a0c88acada021d40b790ed12551 Mon Sep 17 00:00:00 2001 From: vaclav Date: Tue, 24 Oct 2023 16:53:58 +0200 Subject: [PATCH 6/8] accept BE_FIX_867_PARAMC_RECONFIG --- lib_com/options.h | 1 - lib_dec/ivas_mc_param_dec.c | 18 ------------------ 2 files changed, 19 deletions(-) diff --git a/lib_com/options.h b/lib_com/options.h index fa067d94f3..1db4d615ff 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -161,7 +161,6 @@ #define NONBE_FIX_856_TCX_LTP_SYNTH_FILTER /* FhG: issue 856: correct filtering length for tcx-ltp synth filtering*/ #define NONBE_UNIFIED_DECODING_PATHS /* FhG: unify decoding paths */ -#define BE_FIX_867_PARAMC_RECONFIG /* FhG: issue #867: fix ParamMC CLDFB buffer dealloc when reconfiguring */ #define NONBE_FIX_850_MASA_HBR_META_RATIO_DECODING /* Nokia: issue #850: Fixes rare non-valid diffuseness and energy ratio values in 2dir MASA. */ #define NONBE_FIX_MDCT_STEREO_DTX_MONO_OUT /* FhG: fix clicks in DTX -> active transition frames in MDCT-Stereo with mono output */ #define NONBE_FIX_836_PARAMUPMIX_HEADROT /* Dlb: issue #836: Resolve "ParamUpmix MC to SBA conversion done on the already binaurlized output" */ diff --git a/lib_dec/ivas_mc_param_dec.c b/lib_dec/ivas_mc_param_dec.c index d11e846a84..3352a79781 100644 --- a/lib_dec/ivas_mc_param_dec.c +++ b/lib_dec/ivas_mc_param_dec.c @@ -982,26 +982,16 @@ ivas_error ivas_param_mc_dec_reconfig( { int16_t n_cldfb_slots; - if ( hParamMC->Cldfb_RealBuffer_tc != NULL ) { free( hParamMC->Cldfb_RealBuffer_tc ); hParamMC->Cldfb_RealBuffer_tc = NULL; } - -#ifdef BE_FIX_867_PARAMC_RECONFIG if ( hParamMC->Cldfb_ImagBuffer_tc != NULL ) { free( hParamMC->Cldfb_ImagBuffer_tc ); hParamMC->Cldfb_ImagBuffer_tc = NULL; } -#else - if ( hParamMC->Cldfb_RealBuffer_tc != NULL ) - { - free( hParamMC->Cldfb_RealBuffer_tc ); - hParamMC->Cldfb_RealBuffer_tc = NULL; - } -#endif n_cldfb_slots = DEFAULT_JBM_CLDFB_TIMESLOTS; if ( st_ivas->hDecoderConfig->Opt_tsm ) @@ -1027,19 +1017,11 @@ ivas_error ivas_param_mc_dec_reconfig( free( hParamMC->Cldfb_RealBuffer_tc ); hParamMC->Cldfb_RealBuffer_tc = NULL; } -#ifdef BE_FIX_867_PARAMC_RECONFIG if ( hParamMC->Cldfb_ImagBuffer_tc != NULL ) { free( hParamMC->Cldfb_ImagBuffer_tc ); hParamMC->Cldfb_ImagBuffer_tc = NULL; } -#else - if ( hParamMC->Cldfb_RealBuffer_tc != NULL ) - { - free( hParamMC->Cldfb_RealBuffer_tc ); - hParamMC->Cldfb_RealBuffer_tc = NULL; - } -#endif } } #endif -- GitLab From 41f8cb053836e3c56fd0d86db8a2db5e88f81fdd Mon Sep 17 00:00:00 2001 From: vaclav Date: Tue, 24 Oct 2023 16:54:40 +0200 Subject: [PATCH 7/8] accept NONBE_FIX_850_MASA_HBR_META_RATIO_DECODING --- lib_com/options.h | 1 - lib_dec/ivas_dirac_dec.c | 2 -- lib_dec/ivas_qmetadata_dec.c | 3 --- 3 files changed, 6 deletions(-) diff --git a/lib_com/options.h b/lib_com/options.h index 1db4d615ff..db95123e74 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -161,7 +161,6 @@ #define NONBE_FIX_856_TCX_LTP_SYNTH_FILTER /* FhG: issue 856: correct filtering length for tcx-ltp synth filtering*/ #define NONBE_UNIFIED_DECODING_PATHS /* FhG: unify decoding paths */ -#define NONBE_FIX_850_MASA_HBR_META_RATIO_DECODING /* Nokia: issue #850: Fixes rare non-valid diffuseness and energy ratio values in 2dir MASA. */ #define NONBE_FIX_MDCT_STEREO_DTX_MONO_OUT /* FhG: fix clicks in DTX -> active transition frames in MDCT-Stereo with mono output */ #define NONBE_FIX_836_PARAMUPMIX_HEADROT /* Dlb: issue #836: Resolve "ParamUpmix MC to SBA conversion done on the already binaurlized output" */ diff --git a/lib_dec/ivas_dirac_dec.c b/lib_dec/ivas_dirac_dec.c index 815422a182..fb8ab22a05 100644 --- a/lib_dec/ivas_dirac_dec.c +++ b/lib_dec/ivas_dirac_dec.c @@ -1260,14 +1260,12 @@ void ivas_qmetadata_to_dirac( hSpatParamRendCom->energy_ratio2[meta_write_index][b] = q_direction->band_data[band].energy_ratio[block]; hSpatParamRendCom->diffuseness_vector[meta_write_index][b] -= q_direction->band_data[band].energy_ratio[block]; -#ifdef NONBE_FIX_850_MASA_HBR_META_RATIO_DECODING /* Sanitize diffuseness for rare cases where floating point inaccuracy could result in negative diffuseness. */ if ( hSpatParamRendCom->diffuseness_vector[meta_write_index][b] < 0.0f ) { hSpatParamRendCom->diffuseness_vector[meta_write_index][b] = 0.0f; } -#endif if ( q_direction->coherence_band_data != NULL ) { hSpatParamRendCom->spreadCoherence2[meta_write_index][b] = q_direction->coherence_band_data[band].spread_coherence[block] / 255.0f; diff --git a/lib_dec/ivas_qmetadata_dec.c b/lib_dec/ivas_qmetadata_dec.c index 47d3d29fb1..c3134fa8a1 100644 --- a/lib_dec/ivas_qmetadata_dec.c +++ b/lib_dec/ivas_qmetadata_dec.c @@ -1104,7 +1104,6 @@ int16_t ivas_qmetadata_dec_decode_hr_384_512( } } -#ifdef NONBE_FIX_850_MASA_HBR_META_RATIO_DECODING /* Scale energy ratios that sum to over one */ for ( b = 0; b < hQMetaData->q_direction[0].cfg.nbands; b++ ) { @@ -1123,10 +1122,8 @@ int16_t ivas_qmetadata_dec_decode_hr_384_512( } } } -#endif } - #ifdef DEBUG_MODE_QMETADATA for ( d = 0; d < hQMetaData->no_directions; d++ ) { -- GitLab From dff6c5c20cccfc523abf76965c17ae0643387b9b Mon Sep 17 00:00:00 2001 From: vaclav Date: Tue, 24 Oct 2023 16:55:40 +0200 Subject: [PATCH 8/8] accept NONBE_FIX_MDCT_STEREO_DTX_MONO_OUT --- lib_com/options.h | 1 - lib_dec/ivas_stereo_switching_dec.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib_com/options.h b/lib_com/options.h index db95123e74..20d8ccce14 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -161,7 +161,6 @@ #define NONBE_FIX_856_TCX_LTP_SYNTH_FILTER /* FhG: issue 856: correct filtering length for tcx-ltp synth filtering*/ #define NONBE_UNIFIED_DECODING_PATHS /* FhG: unify decoding paths */ -#define NONBE_FIX_MDCT_STEREO_DTX_MONO_OUT /* FhG: fix clicks in DTX -> active transition frames in MDCT-Stereo with mono output */ #define NONBE_FIX_836_PARAMUPMIX_HEADROT /* Dlb: issue #836: Resolve "ParamUpmix MC to SBA conversion done on the already binaurlized output" */ /* ##################### End NON-BE switches ########################### */ diff --git a/lib_dec/ivas_stereo_switching_dec.c b/lib_dec/ivas_stereo_switching_dec.c index e98adfd60b..d311d7b419 100644 --- a/lib_dec/ivas_stereo_switching_dec.c +++ b/lib_dec/ivas_stereo_switching_dec.c @@ -1302,12 +1302,10 @@ void synchro_synthesis( } } -#ifdef NONBE_FIX_MDCT_STEREO_DTX_MONO_OUT if ( hCPE->element_mode == IVAS_CPE_MDCT && hCPE->nchan_out == 1 && !is_DTXrate( hCPE->element_brate ) && is_DTXrate( hCPE->last_element_brate ) ) { mvr2r( sts[0]->prev_synth_buffer, sts[1]->prev_synth_buffer, delay_comp_TD ); } -#endif nChannels = ( hCPE->element_mode == IVAS_CPE_MDCT ) ? 2 : hCPE->nchan_out; for ( n = 0; n < nChannels; n++ ) -- GitLab