From 6217bde6a712c3a697e730e08a0ac93f03528767 Mon Sep 17 00:00:00 2001 From: Erik Norvell Date: Wed, 10 Apr 2024 17:59:01 +0200 Subject: [PATCH 1/9] Change ivas-conformance to run on current branch --- .gitlab-ci.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3a0bf48e45..616b8aa989 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1343,17 +1343,11 @@ ivas-conformance: - 123 script: - *print-common-info-windows - # Prepare reference exec, use tests and scripts from reference - - $source_branch_commit_sha = $(git rev-parse HEAD) - - git checkout main # This should be set to a relevant reference - - git pull # Ensure to get the latest version - python .\scripts\strip_split_rendering.py - MSBuild.exe -maxcpucount .\Workspace_msvc\Workspace_msvc.sln /property:Configuration=Debug - cp -force IVAS_cod.exe IVAS_cod_ref.exe - cp -force IVAS_dec.exe IVAS_dec_ref.exe - cp -force IVAS_rend.exe IVAS_rend_ref.exe - - git restore . - - git checkout $source_branch_commit_sha # Reference creation - python tests/create_short_testvectors.py @@ -1423,16 +1417,10 @@ ivas-conformance-linux: - 123 script: - *print-common-info - # Prepare reference exec, use tests and scripts from reference - - source_branch_commit_sha=$(git rev-parse HEAD) - - git checkout main # This should be set to a relevant reference - - make -j - cp IVAS_cod IVAS_cod_ref - cp IVAS_dec IVAS_dec_ref - cp IVAS_rend IVAS_rend_ref - - git restore . - - git checkout $source_branch_commit_sha # Reference creation - python3 tests/create_short_testvectors.py -- GitLab From e261e5959dd9c7cb5a1bf15fbe78e31eaa50b306 Mon Sep 17 00:00:00 2001 From: norvell Date: Thu, 11 Apr 2024 13:29:24 +0000 Subject: [PATCH 2/9] Limit ivas-conformance to ericsson-windows-runner --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 616b8aa989..44f98d47b0 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1333,7 +1333,7 @@ test-be-to-release: ivas-conformance: tags: - - ivas-windows + - ericsson-windows-runner stage: test timeout: "60 minutes" rules: -- GitLab From 37117a31ae4362932f32925c93d16bd79f5f79b7 Mon Sep 17 00:00:00 2001 From: Erik Norvell Date: Thu, 11 Apr 2024 16:40:49 +0200 Subject: [PATCH 3/9] Shorten 2 test case names in self_test.prm. Add test script and job to prevent long test case names --- .gitlab-ci.yml | 11 +++++++ ci/check_self_test_names.py | 58 ++++++++++++++++++++++++++++++++++++ scripts/config/self_test.prm | 4 +-- 3 files changed, 71 insertions(+), 2 deletions(-) create mode 100644 ci/check_self_test_names.py diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 44f98d47b0..ed235e4bd6 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -379,6 +379,17 @@ branch-is-up-to-date-with-main-pre: - echo $commits_behind_count - if [ $commits_behind_count -eq 0 ]; then exit 0; else echo "Your branch is behind main, run 'git merge origin/main' to update."; exit 1; fi; +check-self-test-names-pre: + extends: + - .rules-merge-request + stage: prevalidate + needs: [] + tags: + - ivas-linux + script: + - python3 ci/check_self_test_names.py scripts/config/self_test.prm 135 + + branch-is-up-to-date-with-main-post: extends: - .rules-merge-request diff --git a/ci/check_self_test_names.py b/ci/check_self_test_names.py new file mode 100644 index 0000000000..a34f23922a --- /dev/null +++ b/ci/check_self_test_names.py @@ -0,0 +1,58 @@ +#!/usr/bin/env python3 +""" + (C) 2022-2024 IVAS codec Public Collaboration with portions copyright Dolby International AB, Ericsson AB, + Fraunhofer-Gesellschaft zur Foerderung der angewandten Forschung e.V., Huawei Technologies Co. LTD., + Koninklijke Philips N.V., Nippon Telegraph and Telephone Corporation, Nokia Technologies Oy, Orange, + Panasonic Holdings Corporation, Qualcomm Technologies, Inc., VoiceAge Corporation, and other + contributors to this repository. All Rights Reserved. + + This software is protected by copyright law and by international treaties. + The IVAS codec Public Collaboration consisting of Dolby International AB, Ericsson AB, + Fraunhofer-Gesellschaft zur Foerderung der angewandten Forschung e.V., Huawei Technologies Co. LTD., + Koninklijke Philips N.V., Nippon Telegraph and Telephone Corporation, Nokia Technologies Oy, Orange, + Panasonic Holdings Corporation, Qualcomm Technologies, Inc., VoiceAge Corporation, and other + contributors to this repository retain full ownership rights in their respective contributions in + the software. This notice grants no license of any kind, including but not limited to patent + license, nor is any license granted by implication, estoppel or otherwise. + + Contributors are required to enter into the IVAS codec Public Collaboration agreement before making + contributions. + + This software is provided "AS IS", without any express or implied warranties. The software is in the + development stage. It is intended exclusively for experts who have experience with such software and + solely for the purpose of inspection. All implied warranties of non-infringement, merchantability + and fitness for a particular purpose are hereby disclaimed and excluded. + + Any dispute, controversy or claim arising under or in relation to providing this software shall be + submitted to and settled by the final, binding jurisdiction of the courts of Munich, Germany in + accordance with the laws of the Federal Republic of Germany excluding its conflict of law rules and + the United Nations Convention on Contracts on the International Sales of Goods. +""" +import argparse +import sys + + +if __name__ == "__main__": + parser = argparse.ArgumentParser() + parser.add_argument("prm_file", type=str) + parser.add_argument("max_length", type=int) + args = parser.parse_args() + + skiplines = 8 + exceeded = [] + with open(args.prm_file,"r") as f: + for line in f: + if skiplines > 0: + skiplines = skiplines - 1 + else: + if("//" in line): + if len(line) > args.max_length: + exceeded.append(line) + + if exceeded: + print(f"Failed! *** Following tests cases exceeded the limit of {args.max_length} characters ***\n") + print("\n".join(exceeded)) + sys.exit(-1) + + print("All OK") + sys.exit(0) \ No newline at end of file diff --git a/scripts/config/self_test.prm b/scripts/config/self_test.prm index a444aea7fe..85a1534ff3 100644 --- a/scripts/config/self_test.prm +++ b/scripts/config/self_test.prm @@ -521,7 +521,7 @@ eid-xor -fer -vbr -bs g192 -ep g192 bit ../scripts/dly_error_profiles/ep_5pct.g1 ../IVAS_cod -dtx -ism 4 testv/stvISM1.csv NULL NULL testv/stvISM4.csv ../scripts/switchPaths/sw_24k4_256k.bin 48 testv/stv4ISM48n.wav bit ../IVAS_dec HOA3 48 bit testv/stv4ISM48n.wav_brate_sw_48-48_DTX_hoa3.tst -// 4 ISM with and without metadata bitrate switching from 24.4 kbps to 256 kbps, 48 kHz in, 48 kHz out, DTX on, BINAURAL_ROOM_IR out (Model from file) +// 4 ISM w and wo md br switching 24.4 kbps to 256 kbps, 48 kHz in, 48 kHz out, DTX on, BINAURAL_ROOM_IR out (Model from file) ../IVAS_cod -dtx -ism 4 testv/stvISM1.csv NULL NULL testv/stvISM4.csv ../scripts/switchPaths/sw_24k4_256k.bin 48 testv/stv4ISM48n.wav bit ../IVAS_dec -hrtf ../scripts/binauralRenderer_interface/binaural_renderers_hrtf_data/ivas_binaural_48kHz.bin BINAURAL_ROOM_IR 48 bit testv/stv4ISM48n.wav_brate_sw_48-48_DTX_hoa3.tst @@ -1702,7 +1702,7 @@ eid-xor -fer -vbr -bs g192 -ep g192 bit ../scripts/dly_error_profiles/ep_5pct.g1 ../IVAS_cod -ism_sba 4 3 testv/stvISM1.csv testv/stvISM2.csv testv/stvISM3.csv testv/stvISM4.csv ../scripts/switchPaths/sw_13k2_512k.bin 32 testv/stvOSBA_4ISM_3OA32c.wav bit ../IVAS_dec EXT 48 bit testv/stvOSBA_4ISM_3OA32c.wav_EXT_sw_13k2_512k_32-48.tst -// OSBA FOA 4ISM at bitrate switching 13.2 to 512 kbps, 48kHz in, 16kHz out, BINAURAL out (Model from file), FER at 5%, bandwidth switching +// OSBA FOA 4ISM at br sw 13.2 to 512 kbps, 48kHz in, 16kHz out, BINAURAL out (Model from file), FER at 5%, bandwidth switching ../IVAS_cod -max_band testv/ivas_bws_20fr_start_FB.txt -ism_sba 4 1 testv/stvISM1.csv testv/stvISM2.csv testv/stvISM3.csv testv/stvISM4.csv ../scripts/switchPaths/sw_13k2_512k.bin 48 testv/stvOSBA_4ISM_FOA48c.wav bit eid-xor -fer -vbr -bs g192 -ep g192 bit ../scripts/dly_error_profiles/ep_5pct.g192 bit_error ../IVAS_dec -hrtf ../scripts/binauralRenderer_interface/binaural_renderers_hrtf_data/ivas_binaural_16kHz.bin BINAURAL 16 bit_error testv/stvOSBA_4ISM_FOA48c.wav_BINAURAL_sw_48-48_FER5.tst -- GitLab From 2f6511a94f55d67862d6157b97f74da454524fdc Mon Sep 17 00:00:00 2001 From: Erik Norvell Date: Thu, 11 Apr 2024 17:09:59 +0200 Subject: [PATCH 4/9] Update copying commands and set to run on Nokia windows runner --- .gitlab-ci.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ed235e4bd6..2a15974a0c 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1344,7 +1344,7 @@ test-be-to-release: ivas-conformance: tags: - - ericsson-windows-runner + - nokia-windows-runner stage: test timeout: "60 minutes" rules: @@ -1378,15 +1378,15 @@ ivas-conformance: - mkdir testvec/testv - mkdir testvec/testv/renderer - mkdir testvec/bin - - cp -r -force -ErrorAction Ignore scripts/testv/* testvec/testv - - cp -r -force -ErrorAction Ignore scripts/ls_layouts testvec - - cp -r -force -ErrorAction Ignore scripts/switchPaths testvec - - cp -r -force -ErrorAction Ignore scripts/trajectories testvec - - cp -r -force -ErrorAction Ignore scripts/binauralRenderer_interface/binaural_renderers_hrtf_data testvec/binauralRenderer_interface - - cp -r -force -ErrorAction Ignore tests/ref testvec/testv/ref - - cp -r -force -ErrorAction Ignore tests/dut/* testvec/testv/ref - - cp -r -force -ErrorAction Ignore tests/renderer/cut testvec/testv/renderer/ref - - cp -r -force -ErrorAction Ignore tests/conformance-test testvec/ + - cp scripts/testv/* testvec/testv + - cp -r scripts/ls_layouts testvec + - cp -r scripts/switchPaths testvec + - cp -r scripts/trajectories testvec + - cp -r scripts/binauralRenderer_interface/binaural_renderers_hrtf_data testvec/binauralRenderer_interface + - cp -r tests/ref testvec/testv/ref + - cp -r tests/dut/* testvec/testv/ref + - cp -r tests/renderer/cut testvec/testv/renderer/ref + - cp -r tests/conformance-test testvec/ - cp Readme_IVAS_dec.txt testvec - cp Readme_IVAS_enc.txt testvec - cp Readme_IVAS_rend.txt testvec -- GitLab From 4d341286462d11e13842ab7303a5ec3df9309723 Mon Sep 17 00:00:00 2001 From: Erik Norvell Date: Thu, 11 Apr 2024 19:06:08 +0200 Subject: [PATCH 5/9] Restore copying commands --- .gitlab-ci.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 2a15974a0c..cb6e63c800 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1378,15 +1378,15 @@ ivas-conformance: - mkdir testvec/testv - mkdir testvec/testv/renderer - mkdir testvec/bin - - cp scripts/testv/* testvec/testv - - cp -r scripts/ls_layouts testvec - - cp -r scripts/switchPaths testvec - - cp -r scripts/trajectories testvec - - cp -r scripts/binauralRenderer_interface/binaural_renderers_hrtf_data testvec/binauralRenderer_interface - - cp -r tests/ref testvec/testv/ref - - cp -r tests/dut/* testvec/testv/ref - - cp -r tests/renderer/cut testvec/testv/renderer/ref - - cp -r tests/conformance-test testvec/ + - cp -force -ErrorAction Ignore scripts/testv/* testvec/testv + - cp -r -force -ErrorAction Ignore scripts/ls_layouts testvec + - cp -r -force -ErrorAction Ignore scripts/switchPaths testvec + - cp -r -force -ErrorAction Ignore scripts/trajectories testvec + - cp -r -force -ErrorAction Ignore scripts/binauralRenderer_interface/binaural_renderers_hrtf_data testvec/binauralRenderer_interface + - cp -r -force -ErrorAction Ignore tests/ref testvec/testv/ref + - cp -r -force -ErrorAction Ignore tests/dut/* testvec/testv/ref + - cp -r -force -ErrorAction Ignore tests/renderer/cut testvec/testv/renderer/ref + - cp -r -force -ErrorAction Ignore tests/conformance-test testvec/ - cp Readme_IVAS_dec.txt testvec - cp Readme_IVAS_enc.txt testvec - cp Readme_IVAS_rend.txt testvec -- GitLab From 0928e811678c2597b4b9e857d8a3da9799bb4b37 Mon Sep 17 00:00:00 2001 From: Erik Norvell Date: Thu, 11 Apr 2024 19:18:05 +0200 Subject: [PATCH 6/9] Add explicit cleaning of temporary output folders --- .gitlab-ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index cb6e63c800..ee6ff68bb9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1373,6 +1373,10 @@ ivas-conformance: # Copy input data and output ref data - if (Test-Path testvec) {rm -r -force testvec} + - if (Test-Path TMP_DEC) {rm -r -force TMP_DEC} + - if (Test-Path TMP_ENC) {rm -r -force TMP_ENC} + - if (Test-Path TMP_JBM) {rm -r -force TMP_JBM} + - if (Test-Path TMP_REND) {rm -r -force TMP_REND} - mkdir testvec - mkdir testvec/binauralRenderer_interface - mkdir testvec/testv -- GitLab From 18ea5408b5979651f0424708382a1095cfe4629d Mon Sep 17 00:00:00 2001 From: Erik Norvell Date: Fri, 12 Apr 2024 08:57:14 +0200 Subject: [PATCH 7/9] Set ivas-conformance to run on both windows runners. Add to main push pipeline --- .gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ee6ff68bb9..0e28e70257 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1344,11 +1344,12 @@ test-be-to-release: ivas-conformance: tags: - - nokia-windows-runner + - ivas-windows stage: test timeout: "60 minutes" rules: - if: ($CI_PIPELINE_SOURCE == 'web' || $CI_PIPELINE_SOURCE == 'trigger') && $MANUAL_PIPELINE_TYPE == 'ivas-conformance' + - if: $CI_PIPELINE_SOURCE == 'push' && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH allow_failure: exit_codes: - 123 -- GitLab From 83dfd0058d5aa32aec90821acb17ec43990c32c1 Mon Sep 17 00:00:00 2001 From: Erik Norvell Date: Fri, 12 Apr 2024 13:45:18 +0200 Subject: [PATCH 8/9] Align self_test_ltv.prm with self_test.prm --- scripts/config/self_test.prm | 2 +- scripts/config/self_test_ltv.prm | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/config/self_test.prm b/scripts/config/self_test.prm index 201763d92f..e3e1a31114 100644 --- a/scripts/config/self_test.prm +++ b/scripts/config/self_test.prm @@ -1320,7 +1320,7 @@ eid-xor -fer -vbr -bs g192 -ep g192 bit ../scripts/dly_error_profiles/ep_5pct.g1 ../IVAS_cod -mc 7_1_4 512000 48 testv/stv714MC48c.wav bit ../IVAS_dec -render_config testv/rend_config_ER_v2.cfg BINAURAL_ROOM_REVERB 48 bit testv/stv714MC48c.wav_MC714_512000_48-48_MC_ER_v2.tst -// Multi-channel 7_1_4 at 512 kbps, 48kHz in, 48kHz out, BINAURAL_ROOM_REVERB out Config early reflections, low complexity, listener origin +// Multi-channel 7_1_4 at 512 kbps, 48kHz in, 48kHz out, BINAURAL_ROOM_REVERB out Conf early refl, low complexity, listener origin ../IVAS_cod -mc 7_1_4 512000 48 testv/stv714MC48c.wav bit ../IVAS_dec -render_config testv/rend_config_ER_v3.cfg BINAURAL_ROOM_REVERB 48 bit testv/stv714MC48c.wav_MC714_512000_48-48_MC_ER_v3.tst diff --git a/scripts/config/self_test_ltv.prm b/scripts/config/self_test_ltv.prm index 690d3ed897..91cebec595 100644 --- a/scripts/config/self_test_ltv.prm +++ b/scripts/config/self_test_ltv.prm @@ -532,7 +532,7 @@ eid-xor -fer -vbr -bs g192 -ep g192 bit ../scripts/dly_error_profiles/ep_5pct.g1 ../IVAS_cod -dtx -ism 4 testv/ltvISM1.csv NULL NULL testv/ltvISM4.csv ../scripts/switchPaths/sw_24k4_256k.bin 48 testv/ltv48_4ISM.wav bit ../IVAS_dec HOA3 48 bit testv/ltv48_4ISM.wav_brate_sw_48-48_DTX_hoa3.tst -// 4 ISM with and without metadata bitrate switching from 24.4 kbps to 256 kbps, 48 kHz in, 48 kHz out, DTX on, BINAURAL_ROOM_IR out (Model from file) +// 4 ISM w and wo md br switching 24.4 kbps to 256 kbps, 48 kHz in, 48 kHz out, DTX on, BINAURAL_ROOM_IR out (Model from file) ../IVAS_cod -dtx -ism 4 testv/ltvISM1.csv NULL NULL testv/ltvISM4.csv ../scripts/switchPaths/sw_24k4_256k.bin 48 testv/ltv48_4ISM.wav bit ../IVAS_dec -hrtf ../scripts/binauralRenderer_interface/binaural_renderers_hrtf_data/ivas_binaural_48kHz.bin BINAURAL_ROOM_IR 48 bit testv/ltv48_4ISM.wav_brate_sw_48-48_DTX_hoa3.tst @@ -1283,7 +1283,7 @@ eid-xor -fer -vbr -bs g192 -ep g192 bit ../scripts/dly_error_profiles/ep_5pct.g1 ../IVAS_cod -mc 7_1 512000 48 testv/ltv48_MC71.wav bit ../IVAS_dec -render_config testv/rend_config_renderer.cfg BINAURAL_ROOM_REVERB 48 bit testv/ltv48_MC71.wav_MC71_512000_48-48_MC_Config_renderer.tst -// Multi-channel 5_1 at 80 kbps, 48kHz in, 32kHz out, BINAURAL_ROOM_REVERB out Config renderer +// Multi-channel 5_1 at 80 kbps, 48kHz in, 32kHz out, BINAURAL_ROOM_REVERB out Config renderer, HR ../IVAS_cod -mc 5_1 80000 48 testv/ltv48_MC51.wav bit ../IVAS_dec -render_config testv/rend_config_renderer.cfg -t ../scripts/trajectories/full-circle-4s.csv BINAURAL_ROOM_REVERB 32 bit testv/ltv48_MC51.wav_MC51_80000_48-32_MC_Config_renderer.tst @@ -1299,7 +1299,7 @@ eid-xor -fer -vbr -bs g192 -ep g192 bit ../scripts/dly_error_profiles/ep_5pct.g1 ../IVAS_cod -mc 5_1 160000 48 testv/ltv48_MC51.wav bit ../IVAS_dec -render_config testv/rend_config_recreation.cfg -t ../scripts/trajectories/full-circle-with-up-and-down-4s.csv BINAURAL_ROOM_REVERB 48 bit testv/ltv48_MC51.wav_M714_160000_48-48_MC_Config_recreation.tst -// Multi-channel 5_1_2 64 kbps, 48kHz in, 48kHz out, BINAURAL_ROOM_REVERB out Config renderer, HR +// Multi-channel 5_1_2 at 64 kbps, 48kHz in, 48kHz out, BINAURAL_ROOM_REVERB out Config renderer, HR ../IVAS_cod -mc 5_1_2 64000 48 testv/ltv48_MC512.wav bit ../IVAS_dec -render_config testv/rend_config_renderer.cfg -t testv/headrot_case04_3000_q.csv BINAURAL_ROOM_REVERB 48 bit testv/ltv48_MC512.wav_MC512_64000_48-48_MC_Config_renderer.tst @@ -1319,7 +1319,7 @@ eid-xor -fer -vbr -bs g192 -ep g192 bit ../scripts/dly_error_profiles/ep_5pct.g1 ../IVAS_cod -mc 7_1_4 512000 48 testv/ltv48_MC714.wav bit ../IVAS_dec -render_config testv/rend_config_ER_v2.cfg BINAURAL_ROOM_REVERB 48 bit testv/ltv48_MC714.wav_MC714_512000_48-48_MC_ER_v2.tst -// Multi-channel 7_1_4 at 512 kbps, 48kHz in, 48kHz out, BINAURAL_ROOM_REVERB out Config early reflections, low complexity, listener origin +// Multi-channel 7_1_4 at 512 kbps, 48kHz in, 48kHz out, BINAURAL_ROOM_REVERB out Conf early refl, low complexity, listener origin ../IVAS_cod -mc 7_1_4 512000 48 testv/ltv48_MC714.wav bit ../IVAS_dec -render_config testv/rend_config_ER_v3.cfg BINAURAL_ROOM_REVERB 48 bit testv/ltv48_MC714.wav_MC714_512000_48-48_MC_ER_v3.tst @@ -1725,7 +1725,7 @@ eid-xor -fer -vbr -bs g192 -ep g192 bit ../scripts/dly_error_profiles/ep_5pct.g1 ../IVAS_cod -ism_sba 4 3 testv/ltvISM1.csv testv/ltvISM2.csv testv/ltvISM3.csv testv/ltvISM4.csv ../scripts/switchPaths/sw_13k2_512k.bin 32 testv/ltv32_OSBA_4ISM_HOA3.wav bit ../IVAS_dec EXT 48 bit testv/ltv32_OSBA_4ISM_HOA3.wav_EXT_sw_13k2_512k_32-32.tst -// OSBA FOA 4ISM at bitrate switching 13.2 to 512 kbps, 48kHz in, 16kHz out, BINAURAL out (Model from file), FER at 5%, bandwidth switching +// OSBA FOA 4ISM at br sw 13.2 to 512 kbps, 48kHz in, 16kHz out, BINAURAL out (Model from file), FER at 5%, bandwidth switching ../IVAS_cod -max_band testv/ivas_bws_20fr_start_WB.txt -ism_sba 4 1 testv/ltvISM1.csv testv/ltvISM2.csv testv/ltvISM3.csv testv/ltvISM4.csv ../scripts/switchPaths/sw_13k2_512k.bin 48 testv/ltv48_OSBA_4ISM_FOA.wav bit eid-xor -fer -vbr -bs g192 -ep g192 bit ../scripts/dly_error_profiles/ep_5pct.g192 bit_error ../IVAS_dec -hrtf ../scripts/binauralRenderer_interface/binaural_renderers_hrtf_data/ivas_binaural_16kHz.bin BINAURAL 16 bit_error testv/ltv48_OSBA_4ISM_FOA.wav_BINAURAL_sw_48-48_FER5.tst -- GitLab From 56eeca020d0e040aa9212c8e9976eb1c0245b972 Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Thu, 25 Apr 2024 09:12:54 +0200 Subject: [PATCH 9/9] cleanup in python file --- ci/check_self_test_names.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/ci/check_self_test_names.py b/ci/check_self_test_names.py index a34f23922a..18943e918d 100644 --- a/ci/check_self_test_names.py +++ b/ci/check_self_test_names.py @@ -40,19 +40,20 @@ if __name__ == "__main__": skiplines = 8 exceeded = [] - with open(args.prm_file,"r") as f: + with open(args.prm_file, "r") as f: for line in f: if skiplines > 0: skiplines = skiplines - 1 else: - if("//" in line): - if len(line) > args.max_length: - exceeded.append(line) - + if "//" in line and len(line) > args.max_length: + exceeded.append(line) + if exceeded: - print(f"Failed! *** Following tests cases exceeded the limit of {args.max_length} characters ***\n") + print( + f"Failed! *** Following tests cases exceeded the limit of {args.max_length} characters ***\n" + ) print("\n".join(exceeded)) sys.exit(-1) - + print("All OK") - sys.exit(0) \ No newline at end of file + sys.exit(0) -- GitLab