From c44597ea039f5606dee07ecab1a5660594e84125 Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Thu, 27 Mar 2025 15:51:00 +0100 Subject: [PATCH] enable allowed failure for complexity changes this makes it possible to distinguish between changes in complexity numbers (which would turn job yellow) and crashes in the codec (which would turn job red) --- .gitlab-ci.yml | 3 +++ ci/complexity_measurements/getWmops.sh | 7 ++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 2ab15a78b6..e8ebf8062a 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -2464,6 +2464,9 @@ coverage-test-on-main-scheduled: - *print-common-info - *update-ltv-repo - *complexity-measurements-setup + allow_failure: + exit_codes: + - 123 artifacts: name: "$CI_JOB_NAME--$CI_COMMIT_REF_NAME--sha-$CI_COMMIT_SHA" when: always diff --git a/ci/complexity_measurements/getWmops.sh b/ci/complexity_measurements/getWmops.sh index 5c2225f875..148092eb1a 100755 --- a/ci/complexity_measurements/getWmops.sh +++ b/ci/complexity_measurements/getWmops.sh @@ -72,8 +72,6 @@ wmopsFilenameFlcLast=wmops_newsletter_${ivas_format_for_filename}_to_${output_fo wmopsFilenameFlcDir=${destDir}/wmops/logs wmopsFilenameFlc=${wmopsFilenameFlcDir}/${wmopsFilenameFlcLast} -ret_val=0 - mode_arg="" # for OSBA, there are just too many modes... -> only select HOA3 ones if [ "$ivas_format" == "OSBA" ]; then @@ -83,7 +81,7 @@ fi # instrument and build ./scripts/IvasBuildAndRunChecks.py $mode_arg_script -p $config_file --checks COMPLEXITY --create_complexity_tables ${wmopsFilenameFlc} -C $ivas_format $mode_arg -f ${ep} --oc $output_format -ret_val=$? +ret_val_script=$? # TODO: only split wmops and ram files ./ci/complexity_measurements/split_by_levels.py $(ls ${wmopsFilenameFlc}*.csv) @@ -137,8 +135,11 @@ else python3 ci/complexity_measurements/genWebpageData.py --wmops_per_op_log ${wmopsFilenameFlc}_WMOPS.csv --rom_log ${log_rom_all} fi +ret_val=0 python3 ${scriptDir}/check_for_changes.py --wmops_logfiles $(ls ${destDir}/wmops/log_wmops_all*.txt) --ram_logfiles $(ls ${destDir}/wmops/log_ram_all*.txt) --rom_logfile ${destDir}/wmops/log_rom_all.txt if [ "$?" != "0" ]; then + ret_val=123 +elif [ "$ret_val_script" != "0" ]; then ret_val=1 fi -- GitLab