From b9d295d16aa36e960adb55d0c0057b41f7589984 Mon Sep 17 00:00:00 2001 From: Tapani Pihlajakuja Date: Tue, 1 Aug 2023 05:38:31 +0000 Subject: [PATCH 1/2] Removes leftover refactor todo comments --- lib_rend/ivas_dirac_dec_binaural_functions.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib_rend/ivas_dirac_dec_binaural_functions.c b/lib_rend/ivas_dirac_dec_binaural_functions.c index 8a3f33b80b..e97143dd22 100644 --- a/lib_rend/ivas_dirac_dec_binaural_functions.c +++ b/lib_rend/ivas_dirac_dec_binaural_functions.c @@ -116,7 +116,6 @@ static void matrixMul( float Are[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float Ai static void matrixTransp2Mul( float Are[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float Aim[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float Bre[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float Bim[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float outRe[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float outIm[BINAURAL_CHANNELS][BINAURAL_CHANNELS] ); -// Todo Tapani refactor: Create separate init & render functions for MASA external renderer. The decoder versions would become too complex if generalized. /*------------------------------------------------------------------------- * ivas_dirac_dec_init_binaural_data() @@ -124,7 +123,6 @@ static void matrixTransp2Mul( float Are[BINAURAL_CHANNELS][BINAURAL_CHANNELS], f * Initialize parametric binaural renderer *------------------------------------------------------------------------*/ -// Todo Tapani refactor: To be moved to lib_dec ivas_error ivas_dirac_dec_init_binaural_data( Decoder_Struct *st_ivas, /* i/o: IVAS decoder structure */ HRTFS_PARAMBIN_HANDLE hHrtfParambin /* i : HRTF structure for rendering */ @@ -377,7 +375,6 @@ ivas_error ivas_dirac_dec_binaural_copy_hrtfs( * *------------------------------------------------------------------------*/ -// Todo Tapani refactor: To be moved to lib_dec void ivas_dirac_dec_binaural_render( Decoder_Struct *st_ivas, /* i/o: IVAS decoder handle */ const uint16_t nSamplesAsked, /* i : number of CLDFB slots requested */ @@ -447,7 +444,6 @@ void ivas_dirac_dec_binaural_render( * loudness correction for parametric binaural renderer *------------------------------------------------------------------------*/ -// Todo Tapani refactor: To be moved to lib_dec void ivas_dirac_dec_binaural_sba_gain( float output[][L_FRAME48k], /* i/o: synthesized core-coder transport channels/DirAC output */ const int16_t nchan_remapped, /* i : num channels after remapping of TCs */ @@ -482,7 +478,6 @@ void ivas_dirac_dec_binaural_sba_gain( * Parametric binaural renderer main function *------------------------------------------------------------------------*/ -// Todo Tapani refactor: To be moved to lib_dec void ivas_dirac_dec_binaural( Decoder_Struct *st_ivas, /* i/o: IVAS decoder structure */ COMBINED_ORIENTATION_HANDLE hCombinedOrientationData, /* i : combined orientation handle */ @@ -568,7 +563,6 @@ void ivas_dirac_dec_binaural( * Local functions *------------------------------------------------------------------------*/ -// Todo refactor: To be moved to lib_dec static void ivas_dirac_dec_binaural_internal( Decoder_Struct *st_ivas, COMBINED_ORIENTATION_HANDLE hCombinedOrientationData, -- GitLab From 30ac6c1cc480d0e41bbae206bd1bf7c2d16d8a57 Mon Sep 17 00:00:00 2001 From: Tapani Pihlajakuja Date: Tue, 1 Aug 2023 09:34:20 +0300 Subject: [PATCH 2/2] Apply clang format --- lib_rend/ivas_dirac_dec_binaural_functions.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib_rend/ivas_dirac_dec_binaural_functions.c b/lib_rend/ivas_dirac_dec_binaural_functions.c index e97143dd22..805c80c9f3 100644 --- a/lib_rend/ivas_dirac_dec_binaural_functions.c +++ b/lib_rend/ivas_dirac_dec_binaural_functions.c @@ -116,7 +116,6 @@ static void matrixMul( float Are[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float Ai static void matrixTransp2Mul( float Are[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float Aim[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float Bre[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float Bim[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float outRe[BINAURAL_CHANNELS][BINAURAL_CHANNELS], float outIm[BINAURAL_CHANNELS][BINAURAL_CHANNELS] ); - /*------------------------------------------------------------------------- * ivas_dirac_dec_init_binaural_data() * -- GitLab