From 78a84ed89a45fa74512e47683a74446b4de77f8f Mon Sep 17 00:00:00 2001 From: Archit Tamarapu Date: Mon, 19 Jun 2023 12:15:40 +0200 Subject: [PATCH 1/3] [fix] get __main__ handler always --- ivas_processing_scripts/__init__.py | 2 +- ivas_processing_scripts/generation/__init__.py | 2 +- ivas_processing_scripts/processing/processing.py | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/ivas_processing_scripts/__init__.py b/ivas_processing_scripts/__init__.py index f0bf5e41..e3858063 100755 --- a/ivas_processing_scripts/__init__.py +++ b/ivas_processing_scripts/__init__.py @@ -60,7 +60,7 @@ from ivas_processing_scripts.utils import ( def logging_init(args, cfg): """set up logging for a test file""" - logger = logging.getLogger("ivas_processing_scripts") + logger = logging.getLogger("__main__") logger.setLevel(logging.DEBUG) # console handler diff --git a/ivas_processing_scripts/generation/__init__.py b/ivas_processing_scripts/generation/__init__.py index fdb83197..e2862540 100755 --- a/ivas_processing_scripts/generation/__init__.py +++ b/ivas_processing_scripts/generation/__init__.py @@ -51,7 +51,7 @@ from ivas_processing_scripts.utils import create_dir def logging_init(args, cfg): """set up logging for a test file""" - logger = logging.getLogger("ivas_processing_scripts.generation") + logger = logging.getLogger("__main__") logger.setLevel(logging.DEBUG) # console handler diff --git a/ivas_processing_scripts/processing/processing.py b/ivas_processing_scripts/processing/processing.py index 2d21d665..6923e7ec 100755 --- a/ivas_processing_scripts/processing/processing.py +++ b/ivas_processing_scripts/processing/processing.py @@ -431,13 +431,12 @@ def process_item( chain, pairwise(processing_paths), processing_paths_meta[:-1] ): # setup logging for the output - item_logger = logger.getChild(output.stem) fh = logging.FileHandler(output.with_suffix(".log"), mode="w") fh.setLevel(logging.DEBUG) fh.setFormatter(logging.Formatter(LOGGER_FORMAT, datefmt=LOGGER_DATEFMT)) - item_logger.addHandler(fh) + logger.addHandler(fh) - p.process(input, output, input_meta, item_logger) + p.process(input, output, input_meta, logger) # copy output and metadata from final process to output file if not chain[-1].name == "processing_splitting_scaling": -- GitLab From 65141a1d75ac7d787774a9346de47e34ad928b7c Mon Sep 17 00:00:00 2001 From: Archit Tamarapu Date: Mon, 19 Jun 2023 13:46:37 +0200 Subject: [PATCH 2/3] [fix] remove bug introduced for per-item logging. a child logger must explicitly be used. --- ivas_processing_scripts/processing/processing.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ivas_processing_scripts/processing/processing.py b/ivas_processing_scripts/processing/processing.py index 6923e7ec..2d21d665 100755 --- a/ivas_processing_scripts/processing/processing.py +++ b/ivas_processing_scripts/processing/processing.py @@ -431,12 +431,13 @@ def process_item( chain, pairwise(processing_paths), processing_paths_meta[:-1] ): # setup logging for the output + item_logger = logger.getChild(output.stem) fh = logging.FileHandler(output.with_suffix(".log"), mode="w") fh.setLevel(logging.DEBUG) fh.setFormatter(logging.Formatter(LOGGER_FORMAT, datefmt=LOGGER_DATEFMT)) - logger.addHandler(fh) + item_logger.addHandler(fh) - p.process(input, output, input_meta, logger) + p.process(input, output, input_meta, item_logger) # copy output and metadata from final process to output file if not chain[-1].name == "processing_splitting_scaling": -- GitLab From c049e499f33082974cefd0dd57a00951e2fa8965 Mon Sep 17 00:00:00 2001 From: Archit Tamarapu Date: Mon, 19 Jun 2023 16:38:04 +0200 Subject: [PATCH 3/3] [fix] try to fix processes logging to same file --- ivas_processing_scripts/processing/processing.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ivas_processing_scripts/processing/processing.py b/ivas_processing_scripts/processing/processing.py index 2d21d665..f04414d1 100755 --- a/ivas_processing_scripts/processing/processing.py +++ b/ivas_processing_scripts/processing/processing.py @@ -438,6 +438,8 @@ def process_item( item_logger.addHandler(fh) p.process(input, output, input_meta, item_logger) + + item_logger.handlers.clear() # copy output and metadata from final process to output file if not chain[-1].name == "processing_splitting_scaling": -- GitLab