From 50208e9e624f80116b1b8e7ef95d10b736eaa07d Mon Sep 17 00:00:00 2001 From: Treffehn Date: Wed, 21 Jun 2023 14:40:11 +0200 Subject: [PATCH 1/2] changed run call in bs1770demo --- ivas_processing_scripts/audiotools/wrappers/bs1770.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ivas_processing_scripts/audiotools/wrappers/bs1770.py b/ivas_processing_scripts/audiotools/wrappers/bs1770.py index a808b2e6..0c79e982 100755 --- a/ivas_processing_scripts/audiotools/wrappers/bs1770.py +++ b/ivas_processing_scripts/audiotools/wrappers/bs1770.py @@ -33,7 +33,6 @@ import copy import logging import re -import subprocess as sp from pathlib import Path from tempfile import TemporaryDirectory from typing import Optional, Tuple, Union @@ -84,9 +83,8 @@ def bs1770demo( binary = find_binary("bs1770demo") # checking if the new binary (with '-rms') is used - result = sp.run(str(binary), shell=True, stdout=sp.PIPE, stderr=sp.PIPE) - result_stdout = result.stdout.decode("utf-8") - if "-rms" not in result_stdout: + result = run([str(binary)], check=False) + if "-rms" not in result.stdout: raise RuntimeError( 'An bs1770demo executable without RMS support (cmdl option "-rms") was detected. Please update the bs1770demo executable. See bin/README.md for details.' ) -- GitLab From f12333df0cd437fabcef6827ffdad72bd37a7b05 Mon Sep 17 00:00:00 2001 From: Treffehn Date: Wed, 21 Jun 2023 14:56:17 +0200 Subject: [PATCH 2/2] try to fix pipeline --- ivas_processing_scripts/audiotools/wrappers/bs1770.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ivas_processing_scripts/audiotools/wrappers/bs1770.py b/ivas_processing_scripts/audiotools/wrappers/bs1770.py index 0c79e982..a72398ed 100755 --- a/ivas_processing_scripts/audiotools/wrappers/bs1770.py +++ b/ivas_processing_scripts/audiotools/wrappers/bs1770.py @@ -83,8 +83,8 @@ def bs1770demo( binary = find_binary("bs1770demo") # checking if the new binary (with '-rms') is used - result = run([str(binary)], check=False) - if "-rms" not in result.stdout: + result_check = run([str(binary)], check=False) + if "-rms" not in result_check.stdout: raise RuntimeError( 'An bs1770demo executable without RMS support (cmdl option "-rms") was detected. Please update the bs1770demo executable. See bin/README.md for details.' ) -- GitLab