From 5f518d6d41f918896f0eab7de8fb675dca10c674 Mon Sep 17 00:00:00 2001 From: Vladimir Malenovsky Date: Fri, 8 Aug 2025 11:28:48 +0200 Subject: [PATCH 1/2] fix incorrect initialization of intermediate SBA object --- .../generation/generate_masa_items.py | 12 +++++++----- .../generation/generate_mc_items.py | 10 ++++++---- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/ivas_processing_scripts/generation/generate_masa_items.py b/ivas_processing_scripts/generation/generate_masa_items.py index 65b29761..4936f8d5 100644 --- a/ivas_processing_scripts/generation/generate_masa_items.py +++ b/ivas_processing_scripts/generation/generate_masa_items.py @@ -208,6 +208,7 @@ def generate_MASA_scene( # repeat for all source files offset = 0 + y_int = None for i in range(N_inputs): # parse parameters from the scene description source_file = ( @@ -269,9 +270,10 @@ def generate_MASA_scene( ) sys.exit(-1) - # initialize intermediate SBA object - y_int = audio.SceneBasedAudio(IR_fmt) - y_int.fs = cfg.fs + # initialize intermediate SBA object (based on the format of the IR file) + if y_int is None: + y_int = audio.SceneBasedAudio(IR_fmt) + y_int.fs = cfg.fs # read source file x = audio.fromfile("MONO", input_filename) @@ -325,13 +327,13 @@ def generate_MASA_scene( delta_offset = source_shift - offset if delta_offset > 0: # insert zeros to the output SBA signal to shift it right - audioarray.trim( + y_int.audio = audioarray.trim( y_int.audio, y_int.fs, limits=[-delta_offset, 0], samples=True ) offset = source_shift else: # insert zeros to the new SBA source signal to shift it right - audioarray.trim(x.audio, x.fs, limits=[delta_offset, 0], samples=True) + x.audio = audioarray.trim(x.audio, x.fs, limits=[delta_offset, 0], samples=True) # adjust the length of the audio source signal delta_length = len(x.audio) - len(y_int.audio) diff --git a/ivas_processing_scripts/generation/generate_mc_items.py b/ivas_processing_scripts/generation/generate_mc_items.py index bac49e0c..e3e85b22 100644 --- a/ivas_processing_scripts/generation/generate_mc_items.py +++ b/ivas_processing_scripts/generation/generate_mc_items.py @@ -208,6 +208,7 @@ def generate_MC_scene( # repeat for all source files offset = 0 + y_int = None for i in range(N_inputs): # parse parameters from the scene description source_file = ( @@ -270,8 +271,9 @@ def generate_MC_scene( sys.exit(-1) # initialize intermediate SBA object (based on the format of the IR file) - y_int = audio.SceneBasedAudio(IR_fmt) - y_int.fs = cfg.fs + if y_int is None: + y_int = audio.SceneBasedAudio(IR_fmt) + y_int.fs = cfg.fs # read source file x = audio.fromfile("MONO", input_filename) @@ -325,13 +327,13 @@ def generate_MC_scene( delta_offset = source_shift - offset if delta_offset > 0: # insert zeros to the output SBA signal to shift it right - audioarray.trim( + y_int.audio = audioarray.trim( y_int.audio, y_int.fs, limits=[-delta_offset, 0], samples=True ) offset = source_shift else: # insert zeros to the new SBA source signal to shift it right - audioarray.trim(x.audio, x.fs, limits=[delta_offset, 0], samples=True) + x.audio = audioarray.trim(x.audio, x.fs, limits=[delta_offset, 0], samples=True) # adjust the length of the audio source signal delta_length = len(x.audio) - len(y_int.audio) -- GitLab From de484f9d4bd764c5f286d4d57d395336e430b069 Mon Sep 17 00:00:00 2001 From: Vladimir Malenovsky Date: Fri, 8 Aug 2025 13:20:44 +0200 Subject: [PATCH 2/2] fix formatting --- ivas_processing_scripts/generation/generate_masa_items.py | 4 +++- ivas_processing_scripts/generation/generate_mc_items.py | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/ivas_processing_scripts/generation/generate_masa_items.py b/ivas_processing_scripts/generation/generate_masa_items.py index 4936f8d5..9d71d7c4 100644 --- a/ivas_processing_scripts/generation/generate_masa_items.py +++ b/ivas_processing_scripts/generation/generate_masa_items.py @@ -333,7 +333,9 @@ def generate_MASA_scene( offset = source_shift else: # insert zeros to the new SBA source signal to shift it right - x.audio = audioarray.trim(x.audio, x.fs, limits=[delta_offset, 0], samples=True) + x.audio = audioarray.trim( + x.audio, x.fs, limits=[delta_offset, 0], samples=True + ) # adjust the length of the audio source signal delta_length = len(x.audio) - len(y_int.audio) diff --git a/ivas_processing_scripts/generation/generate_mc_items.py b/ivas_processing_scripts/generation/generate_mc_items.py index e3e85b22..2b2da206 100644 --- a/ivas_processing_scripts/generation/generate_mc_items.py +++ b/ivas_processing_scripts/generation/generate_mc_items.py @@ -333,7 +333,9 @@ def generate_MC_scene( offset = source_shift else: # insert zeros to the new SBA source signal to shift it right - x.audio = audioarray.trim(x.audio, x.fs, limits=[delta_offset, 0], samples=True) + x.audio = audioarray.trim( + x.audio, x.fs, limits=[delta_offset, 0], samples=True + ) # adjust the length of the audio source signal delta_length = len(x.audio) - len(y_int.audio) -- GitLab