From df05117f05f1265c4de289043d1488fd616861db Mon Sep 17 00:00:00 2001 From: Archit Tamarapu Date: Fri, 29 Aug 2025 16:30:33 +0200 Subject: [PATCH 1/2] [fix] multiple processes overwrite the same file for ivas_combined conditions; files were written to wrong location --- ivas_processing_scripts/processing/ivas_combined.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ivas_processing_scripts/processing/ivas_combined.py b/ivas_processing_scripts/processing/ivas_combined.py index 6ab83794..680ab180 100755 --- a/ivas_processing_scripts/processing/ivas_combined.py +++ b/ivas_processing_scripts/processing/ivas_combined.py @@ -137,15 +137,15 @@ class IVASCombined(Processing): logger.debug(f"IVAS {in_file.absolute()} -> {out_file.absolute()}") # split into objects and spatial files - in_file_objects = in_file.with_suffix(f".objects{in_file.suffix}") - in_file_spatial = in_file.with_suffix(f".spatial{in_file.suffix}") + in_file_objects = out_file.with_suffix(f".objects{in_file.suffix}") + in_file_spatial = out_file.with_suffix(f".spatial{in_file.suffix}") in_audio, fs = read(in_file) write(in_file_objects, in_audio[:, : self.in_fmt.num_ism_channels], fs) write(in_file_spatial, in_audio[:, self.in_fmt.num_ism_channels :], fs) - out_file_objects = out_file.with_suffix(f".objects{out_file.suffix}") - out_file_spatial = out_file.with_suffix(f".spatial{out_file.suffix}") + out_file_objects = out_file.with_suffix(f".objects.ivas{out_file.suffix}") + out_file_spatial = out_file.with_suffix(f".spatial.ivas{out_file.suffix}") in_meta_objects = in_meta[: self.in_fmt.num_ism_channels] in_meta_spatial = in_meta[self.in_fmt.num_ism_channels :] -- GitLab From 65291358532ae9f60bf9aa876b738ba13a2d4c8c Mon Sep 17 00:00:00 2001 From: Archit Tamarapu Date: Fri, 29 Aug 2025 16:37:06 +0200 Subject: [PATCH 2/2] [fix] remove gain factor for OSBA --- ivas_processing_scripts/processing/ivas_combined.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/ivas_processing_scripts/processing/ivas_combined.py b/ivas_processing_scripts/processing/ivas_combined.py index 680ab180..b7374907 100755 --- a/ivas_processing_scripts/processing/ivas_combined.py +++ b/ivas_processing_scripts/processing/ivas_combined.py @@ -161,11 +161,6 @@ class IVASCombined(Processing): out_audio_objects, fs = read(out_file_objects) out_audio_spatial, fs = read(out_file_spatial) - # combine outputs, with gain factor if OSBA - if isinstance(self.in_fmt, audio.OSBAAudio): - out_audio_objects *= 0.5 - out_audio_spatial *= 0.5 - out_audio = out_audio_objects + out_audio_spatial write(out_file, out_audio, fs) -- GitLab