From 425b9c07dce19345570dedbd45be2ebfc83ecd74 Mon Sep 17 00:00:00 2001 From: Treffehn Date: Wed, 24 May 2023 11:33:52 +0200 Subject: [PATCH 1/3] removed random delay for background noise --- .../processing/preprocessing_2.py | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/ivas_processing_scripts/processing/preprocessing_2.py b/ivas_processing_scripts/processing/preprocessing_2.py index 0e84c447..e244edad 100644 --- a/ivas_processing_scripts/processing/preprocessing_2.py +++ b/ivas_processing_scripts/processing/preprocessing_2.py @@ -114,9 +114,6 @@ class Preprocessing2(Processing): def add_background_noise( self, audio_object: audio.Audio, in_meta, logger ) -> np.ndarray: - # range for random delay - max_delay = int(2400000 * audio_object.fs / 48000) - if self.background_noise.get("background_noise_path"): if not self.background_noise.get("background_noise_path").exists(): raise ValueError( @@ -136,10 +133,6 @@ class Preprocessing2(Processing): # if noise is too short raise error if len(noise_object.audio) < len(audio_object.audio): raise ValueError("Background noise too short for audio signal") - if len(noise_object.audio) - max_delay < len(audio_object.audio): - raise ValueError( - "Background noise may be to short for audio signal when considering the random delay" - ) # measure loudness of audio signal based on output format tmp_object = audio.fromtype(self.out_fmt) @@ -163,16 +156,8 @@ class Preprocessing2(Processing): # compute desired loudness of background noise loudness_noise = loudness_signal - self.background_noise["snr"] - # apply random delay and cut signal - rand_delay = random_seed( - range=(1, max_delay), - master_seed=self.background_noise["master_seed"], - prerun_seed=self.background_noise["seed_delay"], - hexa=False, - ) - noise_object.audio = delay( - noise_object.audio, delay=-rand_delay, samples=True, fs=noise_object.fs - )[: len(audio_object.audio)] + # cut noise signal + noise_object.audio = noise_object.audio[: len(audio_object.audio)] # scale background noise to desired loudness based on output format logger.debug( -- GitLab From adbc91ea21377d08b5355936c764d6b7cb3b66b1 Mon Sep 17 00:00:00 2001 From: Treffehn Date: Wed, 24 May 2023 13:51:16 +0200 Subject: [PATCH 2/3] formatting --- .../generation/process_ism_items.py | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/ivas_processing_scripts/generation/process_ism_items.py b/ivas_processing_scripts/generation/process_ism_items.py index cb8a46b8..ff123663 100644 --- a/ivas_processing_scripts/generation/process_ism_items.py +++ b/ivas_processing_scripts/generation/process_ism_items.py @@ -102,10 +102,22 @@ def generate_ism_items( # repeat for all source files for i in range(N_sources): # parse parameters from the scene description - source_file = scene["source"][i] if isinstance(scene["source"], list) else scene["source"] - source_azi = scene["azimuth"][i] if isinstance(scene["azimuth"], list) else scene["azimuth"] - source_ele = scene["elevation"][i] if isinstance(scene["elevation"], list) else scene["elevation"] - + source_file = ( + scene["source"][i] + if isinstance(scene["source"], list) + else scene["source"] + ) + source_azi = ( + scene["azimuth"][i] + if isinstance(scene["azimuth"], list) + else scene["azimuth"] + ) + source_ele = ( + scene["elevation"][i] + if isinstance(scene["elevation"], list) + else scene["elevation"] + ) + logger.info( f"Encoding {source_file} at position(s) {source_azi},{source_ele}" ) -- GitLab From fdb1ce0cacb4df0cb31d964acda0cc2caddd8c60 Mon Sep 17 00:00:00 2001 From: Treffehn Date: Wed, 24 May 2023 14:06:02 +0200 Subject: [PATCH 3/3] removed unnecessary imports --- ivas_processing_scripts/processing/preprocessing_2.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ivas_processing_scripts/processing/preprocessing_2.py b/ivas_processing_scripts/processing/preprocessing_2.py index e244edad..2a475db2 100644 --- a/ivas_processing_scripts/processing/preprocessing_2.py +++ b/ivas_processing_scripts/processing/preprocessing_2.py @@ -37,7 +37,7 @@ from warnings import warn import numpy as np from ivas_processing_scripts.audiotools import audio -from ivas_processing_scripts.audiotools.audioarray import delay, trim +from ivas_processing_scripts.audiotools.audioarray import trim from ivas_processing_scripts.audiotools.audiofile import write from ivas_processing_scripts.audiotools.metadata import ( add_remove_preamble, @@ -47,7 +47,6 @@ from ivas_processing_scripts.audiotools.wrappers.bs1770 import ( get_loudness, loudness_norm, ) -from ivas_processing_scripts.audiotools.wrappers.random_seed import random_seed from ivas_processing_scripts.processing.processing import Processing -- GitLab