Commit a8590985 authored by Jan Reimes's avatar Jan Reimes
Browse files

refactor(tests): fixing linter issues

parent abb5bb9c

tests/test_new_cli_flags.py

+0 −1
Original line number Diff line number Diff line
@@ -10,7 +10,6 @@ import pytest 
from typer.testing import CliRunner



from tdoc_crawler.cli.app import app

from tdoc_crawler.crawlers.tdocs import TDocCrawlResult

from tdoc_crawler.fetching import FetchMissingResult

from tdoc_crawler.models.tdocs import TDocMetadata

tests/test_portal_auth.py

+4 −6
Original line number Diff line number Diff line
@@ -95,8 +95,7 @@ def test_fetch_tdoc_metadata_invalid_tdoc(credentials: PortalCredentials) -> Non 
    tdoc_id = "S4-999999999"



    # Should raise PortalParsingError for non-existent TDoc

    with pytest.raises(PortalParsingError):

        with PortalSession(credentials=credentials, cache_dir=Path("."), timeout=30) as session:

    with pytest.raises(PortalParsingError), PortalSession(credentials=credentials, cache_dir=Path("."), timeout=30) as session:

        session.fetch_tdoc_metadata(tdoc_id)
@@ -106,6 +105,5 @@ def test_fetch_tdoc_metadata_invalid_credentials() -> None: 
    invalid_credentials = PortalCredentials(username="invalid_user", password="invalid_password")  # noqa: S106

    tdoc_id = "S4-251364"



    with pytest.raises(PortalAuthenticationError):

        with PortalSession(credentials=invalid_credentials, cache_dir=Path("."), timeout=30) as session:

    with pytest.raises(PortalAuthenticationError), PortalSession(credentials=invalid_credentials, cache_dir=Path("."), timeout=30) as session:

        session.fetch_tdoc_metadata(tdoc_id)

tests/test_targeted_fetch.py

+4 −8
Original line number Diff line number Diff line
@@ -7,15 +7,11 @@ from pathlib import Path 
from unittest.mock import MagicMock, patch



from conftest import insert_sample_meetings



from tdoc_crawler.cli.helpers import infer_working_groups_from_ids

from tdoc_crawler.crawlers import TDocCrawlResult

from tdoc_crawler.database import TDocDatabase

from tdoc_crawler.fetching import (

    FetchMissingResult,

    fetch_missing_tdocs,

    fetch_missing_tdocs_batch,

    fetch_via_whatthespec_batch,

)

from tdoc_crawler.fetching import fetch_missing_tdocs, fetch_missing_tdocs_batch

from tdoc_crawler.models import PortalCredentials, QueryConfig, TDocMetadata, WorkingGroup
@@ -225,7 +221,7 @@ class TestFetchMissingTdocs: 


        with TDocDatabase(test_db_path) as database:

            results = database.query_tdocs(config)

            result = fetch_missing_tdocs(

            fetch_missing_tdocs(

                database,

                test_db_path.parent,

                config,
@@ -291,7 +287,7 @@ class TestFetchMissingTdocs: 


        with TDocDatabase(test_db_path) as database:

            results = database.query_tdocs(config)

            result = fetch_missing_tdocs(

            fetch_missing_tdocs(

                database,

                test_db_path.parent,

                config,