From 52f227817f2daab6c65cbf5fcf2aff31e2e3f099 Mon Sep 17 00:00:00 2001 From: grahamj Date: Wed, 30 Apr 2025 15:00:37 +0000 Subject: [PATCH 1/7] Update file TS33128Payloads.asn --- 33128/r16/TS33128Payloads.asn | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/33128/r16/TS33128Payloads.asn b/33128/r16/TS33128Payloads.asn index 357171a3..58be9533 100644 --- a/33128/r16/TS33128Payloads.asn +++ b/33128/r16/TS33128Payloads.asn @@ -117,12 +117,14 @@ XIRIEvent ::= CHOICE aMFIdentifierAssocation [62] AMFIdentifierAssocation, mMEIdentifierAssocation [63] MMEIdentifierAssocation, - -- PDU to MA PDU session-related events, see clause 6.2.3.2.8 + -- PDU to MA PDU session-related events, see clause 6.2.3.2.8 sMFPDUtoMAPDUSessionModification [64] SMFPDUtoMAPDUSessionModification, + -- tags 64-165 are unused in this version of the specification + -- in release 16 versions 15 and 16, mMSConvertedFromEmail is tag 65 and mMSConvertedToEmail is tag 66 -- MMS-related events continued from choice 35 - mMSConvertedFromEmail [65] MMSConvertedFromEmail, - mMSConvertedToEmail [66] MMSConvertedToEmail + mMSConvertedFromEmail [165] MMSConvertedFromEmail, + mMSConvertedToEmail [166] MMSConvertedToEmail } -- ============== -- GitLab From 66801d4cbcb655ae8b94346ebfd05487772c128d Mon Sep 17 00:00:00 2001 From: grahamj Date: Wed, 30 Apr 2025 15:06:13 +0000 Subject: [PATCH 2/7] Update 2 files - /33128/r16/TS33128Payloads.asn - /testing/asn_lint_exceptions.json --- 33128/r16/TS33128Payloads.asn | 6 ++++-- testing/asn_lint_exceptions.json | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/33128/r16/TS33128Payloads.asn b/33128/r16/TS33128Payloads.asn index 58be9533..79c5ddc0 100644 --- a/33128/r16/TS33128Payloads.asn +++ b/33128/r16/TS33128Payloads.asn @@ -239,9 +239,11 @@ IRIEvent ::= CHOICE -- PDU to MA PDU session-related events, see clause 6.2.3.2.8 sMFPDUtoMAPDUSessionModification [64] SMFPDUtoMAPDUSessionModification, + -- tags 64-165 are unused in this version of the specification + -- in release 16 versions 15 and 16, mMSConvertedFromEmail is tag 65 and mMSConvertedToEmail is tag 66 -- MMS-related events continued from choice 35 - mMSConvertedFromEmail [65] MMSConvertedFromEmail, - mMSConvertedToEmail [66] MMSConvertedToEmail + mMSConvertedFromEmail [165] MMSConvertedFromEmail, + mMSConvertedToEmail [166] MMSConvertedToEmail } IRITargetIdentifier ::= SEQUENCE diff --git a/testing/asn_lint_exceptions.json b/testing/asn_lint_exceptions.json index 78c82247..8dc37d33 100644 --- a/testing/asn_lint_exceptions.json +++ b/testing/asn_lint_exceptions.json @@ -19,6 +19,8 @@ "Enumerations for MMStatusExtension start at 0, not 1", "Tag 2 missing in LALSReport", "Tag 6 missing in LALSReport" + "Tags 65-164 missing in XIRIEvent" + "Tags 65-164 missing in IRIEvent" ], "33128/r17/TS33128Payloads.asn" : [ "Tag 100 XIRIEvent field 'n9HRPDUSessionInfo' is not present in IRIEvent", -- GitLab From ab605fdbf075956e43d2b043f7662607becb6a25 Mon Sep 17 00:00:00 2001 From: grahamj Date: Wed, 30 Apr 2025 15:08:08 +0000 Subject: [PATCH 3/7] Update file asn_lint_exceptions.json --- testing/asn_lint_exceptions.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/testing/asn_lint_exceptions.json b/testing/asn_lint_exceptions.json index 8dc37d33..83976727 100644 --- a/testing/asn_lint_exceptions.json +++ b/testing/asn_lint_exceptions.json @@ -18,8 +18,8 @@ "Enumerations for MMSReplyCharging start at 0, not 1", "Enumerations for MMStatusExtension start at 0, not 1", "Tag 2 missing in LALSReport", - "Tag 6 missing in LALSReport" - "Tags 65-164 missing in XIRIEvent" + "Tag 6 missing in LALSReport", + "Tags 65-164 missing in XIRIEvent", "Tags 65-164 missing in IRIEvent" ], "33128/r17/TS33128Payloads.asn" : [ -- GitLab From 25d1bbd82cced2ee5cd84ff56db22b2b12f51c05 Mon Sep 17 00:00:00 2001 From: mark Date: Thu, 1 May 2025 14:11:00 +0100 Subject: [PATCH 4/7] Updates from comments --- 33128/r16/TS33128Payloads.asn | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/33128/r16/TS33128Payloads.asn b/33128/r16/TS33128Payloads.asn index 79c5ddc0..21b05f20 100644 --- a/33128/r16/TS33128Payloads.asn +++ b/33128/r16/TS33128Payloads.asn @@ -120,9 +120,10 @@ XIRIEvent ::= CHOICE -- PDU to MA PDU session-related events, see clause 6.2.3.2.8 sMFPDUtoMAPDUSessionModification [64] SMFPDUtoMAPDUSessionModification, - -- tags 64-165 are unused in this version of the specification + -- Tags 64 to 164 are not used in this version of the specification -- in release 16 versions 15 and 16, mMSConvertedFromEmail is tag 65 and mMSConvertedToEmail is tag 66 -- MMS-related events continued from choice 35 + mMSConvertedFromEmail [165] MMSConvertedFromEmail, mMSConvertedToEmail [166] MMSConvertedToEmail } @@ -239,9 +240,10 @@ IRIEvent ::= CHOICE -- PDU to MA PDU session-related events, see clause 6.2.3.2.8 sMFPDUtoMAPDUSessionModification [64] SMFPDUtoMAPDUSessionModification, - -- tags 64-165 are unused in this version of the specification + -- Tags 64-164 are not used in this version of the specification -- in release 16 versions 15 and 16, mMSConvertedFromEmail is tag 65 and mMSConvertedToEmail is tag 66 -- MMS-related events continued from choice 35 + mMSConvertedFromEmail [165] MMSConvertedFromEmail, mMSConvertedToEmail [166] MMSConvertedToEmail } -- GitLab From 956f39df66599842490106a8f67b4b4bd9b0ffb7 Mon Sep 17 00:00:00 2001 From: mark Date: Thu, 1 May 2025 14:13:34 +0100 Subject: [PATCH 5/7] Updates from comments --- 33128/r16/TS33128Payloads.asn | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/33128/r16/TS33128Payloads.asn b/33128/r16/TS33128Payloads.asn index 21b05f20..aa954cc0 100644 --- a/33128/r16/TS33128Payloads.asn +++ b/33128/r16/TS33128Payloads.asn @@ -121,6 +121,7 @@ XIRIEvent ::= CHOICE sMFPDUtoMAPDUSessionModification [64] SMFPDUtoMAPDUSessionModification, -- Tags 64 to 164 are not used in this version of the specification + -- in release 16 versions 15 and 16, mMSConvertedFromEmail is tag 65 and mMSConvertedToEmail is tag 66 -- MMS-related events continued from choice 35 @@ -241,9 +242,10 @@ IRIEvent ::= CHOICE sMFPDUtoMAPDUSessionModification [64] SMFPDUtoMAPDUSessionModification, -- Tags 64-164 are not used in this version of the specification + -- in release 16 versions 15 and 16, mMSConvertedFromEmail is tag 65 and mMSConvertedToEmail is tag 66 -- MMS-related events continued from choice 35 - + mMSConvertedFromEmail [165] MMSConvertedFromEmail, mMSConvertedToEmail [166] MMSConvertedToEmail } -- GitLab From 165856b16c7788f2653d8b179d8555c68a6ed227 Mon Sep 17 00:00:00 2001 From: mark Date: Thu, 1 May 2025 22:18:20 +0100 Subject: [PATCH 6/7] Updating comments from LM --- 33128/r16/TS33128Payloads.asn | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/33128/r16/TS33128Payloads.asn b/33128/r16/TS33128Payloads.asn index aa954cc0..825c4675 100644 --- a/33128/r16/TS33128Payloads.asn +++ b/33128/r16/TS33128Payloads.asn @@ -58,7 +58,7 @@ XIRIEvent ::= CHOICE -- tag 16 is reserved because there is no equivalent mDFCellSiteReport in XIRIEvent - -- MMS-related events, see clause 7.4.2 see also MMSConverted events ([65-66] below) + -- MMS-related events, see clause 7.4.2 see also MMSConverted events ([165-166] below) mMSSend [17] MMSSend, mMSSendByNonLocalTarget [18] MMSSendByNonLocalTarget, mMSNotification [19] MMSNotification, @@ -122,9 +122,11 @@ XIRIEvent ::= CHOICE -- Tags 64 to 164 are not used in this version of the specification - -- in release 16 versions 15 and 16, mMSConvertedFromEmail is tag 65 and mMSConvertedToEmail is tag 66 - -- MMS-related events continued from choice 35 - + -- In V16.18.0 (threeGPP(4) ts33128(19) r16(16) version16(16)), + -- tag 65 was mMSConvertedFromEmail (now tag 165) and + -- tag 66 was mMSConvertedToEmail (now tag 166). + -- These fields were renumbered in V16.19.0 (threeGPP(4) ts33128(19) r16(16) version17(17)) + -- to avoid conflict and permit interoperability with newer releases. mMSConvertedFromEmail [165] MMSConvertedFromEmail, mMSConvertedToEmail [166] MMSConvertedToEmail } @@ -179,7 +181,7 @@ IRIEvent ::= CHOICE -- MDF-related events, see clause 7.3.2 mDFCellSiteReport [16] MDFCellSiteReport, - -- MMS-related events, see clause 7.4.2 see also MMSConverted events ([65-66] below) + -- MMS-related events, see clause 7.4.2 see also MMSConverted events ([165-166] below) mMSSend [17] MMSSend, mMSSendByNonLocalTarget [18] MMSSendByNonLocalTarget, mMSNotification [19] MMSNotification, @@ -243,9 +245,11 @@ IRIEvent ::= CHOICE -- Tags 64-164 are not used in this version of the specification - -- in release 16 versions 15 and 16, mMSConvertedFromEmail is tag 65 and mMSConvertedToEmail is tag 66 - -- MMS-related events continued from choice 35 - + -- In V16.18.0 (threeGPP(4) ts33128(19) r16(16) version16(16)), + -- tag 65 was mMSConvertedFromEmail (now tag 165) and + -- tag 66 was mMSConvertedToEmail (now tag 166). + -- These fields were renumbered in V16.19.0 (threeGPP(4) ts33128(19) r16(16) version17(17)) + -- to avoid conflict and permit interoperability with newer releases. mMSConvertedFromEmail [165] MMSConvertedFromEmail, mMSConvertedToEmail [166] MMSConvertedToEmail } -- GitLab From f4e7b2ee973d49a53246efecacab328538981016 Mon Sep 17 00:00:00 2001 From: grahamj Date: Thu, 1 May 2025 18:41:40 +0000 Subject: [PATCH 7/7] Update file TS33128Payloads.asn --- 33128/r16/TS33128Payloads.asn | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/33128/r16/TS33128Payloads.asn b/33128/r16/TS33128Payloads.asn index 825c4675..de7cd62b 100644 --- a/33128/r16/TS33128Payloads.asn +++ b/33128/r16/TS33128Payloads.asn @@ -120,7 +120,7 @@ XIRIEvent ::= CHOICE -- PDU to MA PDU session-related events, see clause 6.2.3.2.8 sMFPDUtoMAPDUSessionModification [64] SMFPDUtoMAPDUSessionModification, - -- Tags 64 to 164 are not used in this version of the specification + -- Tags 65 to 164 are not used in this version of the specification -- In V16.18.0 (threeGPP(4) ts33128(19) r16(16) version16(16)), -- tag 65 was mMSConvertedFromEmail (now tag 165) and @@ -243,7 +243,7 @@ IRIEvent ::= CHOICE -- PDU to MA PDU session-related events, see clause 6.2.3.2.8 sMFPDUtoMAPDUSessionModification [64] SMFPDUtoMAPDUSessionModification, - -- Tags 64-164 are not used in this version of the specification + -- Tags 65-164 are not used in this version of the specification -- In V16.18.0 (threeGPP(4) ts33128(19) r16(16) version16(16)), -- tag 65 was mMSConvertedFromEmail (now tag 165) and -- GitLab