Commit 1839e0d6 authored by Fabian Bauer's avatar Fabian Bauer
Browse files

fix potential flaws

parent 0f2adfb1

lib_com/options.h

+1 −1
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ 
/* Note: each compile switch (FIX_1101_...) is independent from the other ones */



#define ISSUE_1796_replace_shl_o                             /* FhG: replace shl_ro by overflow-free alternatives - BE*/

#define ISSUE_1836_replace_overflow_libcom                   /* FhG: replace overflow operators by non-overflow-alternatives - BE */

#define ISSUE_1836_replace_overflow_libcom                   /* FhG: replace overflow operators by non-overflow-alternatives in lib_com - BE */

#define ISSUE_1836_replace_overflow_libcom__remnant          /* FhG: replace remaining overflow operators by non-overflow-alternatives in lib_com - BE */

#define ISSUE_1866_replace_overflow_libdec                   /* FhG: BE - Replace BASOPoverflow operators all over the lib_dec module if Overflow result is not used */

lib_com/swb_tbe_com_fx.c

+4 −4
Original line number Diff line number Diff line
@@ -1680,8 +1680,8 @@ void GenShapedWBExcitation_ivas_fx( 
                temp2 = round_fx_sat( L_shl_sat( Ltemp2, exp ) ); /* Q15 */ //??sat   //??sat

                FOR( j = 0; j < L_FRAME16k / 16; j++ )

                {

                    L_tmp = L_mult( temp1, exc4kWhtnd[k] );                                                            /* Q(16+Q_bwe_exc) */

                    L_tmp = L_add_sat( L_tmp, L_shl_sat( L_mult( temp2, exc4k_frac[k] ), sc ) ); /* Q(16+Q_bwe_exc) */ //??sat   //??sat

                    L_tmp = L_mult_sat( temp1, exc4kWhtnd[k] );                                                            /* Q(16+Q_bwe_exc) */

                    L_tmp = L_add_sat( L_tmp, L_shl_sat( L_mult_sat( temp2, exc4k_frac[k] ), sc ) ); /* Q(16+Q_bwe_exc) */ //??sat   //??sat

                    exc4kWhtnd[k] = round_fx_sat( L_tmp ); /* Q_bwe_exc */                                             //??sat

                    move16();

                    k++;
@@ -1987,8 +1987,8 @@ void GenShapedWBExcitation_fx( 
                temp2 = round_fx_sat( L_shl_sat( Ltemp2, exp ) ); /* Q15 */ //??sat //??sat

                FOR( j = 0; j < L_FRAME16k / 16; j++ )

                {

                    L_tmp = L_mult( temp1, exc4kWhtnd[k] );                                                            /* Q(16+Q_bwe_exc) */

                    L_tmp = L_add_sat( L_tmp, L_shl_sat( L_mult( temp2, exc4k_frac[k] ), sc ) ); /* Q(16+Q_bwe_exc) */ //??sat //??sat

                    L_tmp = L_mult_sat( temp1, exc4kWhtnd[k] );                                                            /* Q(16+Q_bwe_exc) */

                    L_tmp = L_add_sat( L_tmp, L_shl_sat( L_mult_sat( temp2, exc4k_frac[k] ), sc ) ); /* Q(16+Q_bwe_exc) */ //??sat //??sat

                    exc4kWhtnd[k] = round_fx_sat( L_tmp ); /* Q_bwe_exc */                                             //??sat

                    move16();

                    k = add( k, 1 );