Commit 27abfbb5 authored by multrus's avatar multrus
Browse files

[cleanup] accept FIX_BASOP_2329_UNINIT_VALUE

parent 1dd43b19

lib_com/options.h

+0 −1
Original line number Diff line number Diff line
@@ -87,7 +87,6 @@ 
#define FIX_2255_ISAR_RENDER_POSES                      /* VA: issue 2255: fix missing check in isar_render_poses() */

#define FIX_1904_HARM_GSC_ENC                           /* VA: #1904 Harmonization of EVS and IVAS GSC code */

#define FIX_1478_UNINIT_ON_BFI                          /* VA: Fix issue 1478 where a vector is partly un-initialized during bfi */

#define FIX_BASOP_2329_UNINIT_VALUE                     /* Nokia: basop issue 2329: Fix issue by checking for structure instead of length */

#define FIX_BASOP_2332_ASAN_OVERFLOW_IN_EXT_DIRAC_REND  /* Nokia: basop issue 2332: Uses predefined memory sizes instead computing wrong */

#define FIX_BASOP_2333_MCMASA_ANA_MEMORY_LEAK           /* Nokia: basop issue 2333: Add missing free for direction_vector_e to ivas_mcmasa_ana_fx.c */

#define HARM_COREDECODER_FUNCTIONS                      /* VA: basop issue 2347: Remove various duplicated code in core-decoder  */

lib_rend/ivas_dirac_rend_fx.c

+0 −2
Original line number Diff line number Diff line
@@ -860,11 +860,9 @@ ivas_error ivas_dirac_alloc_mem_fx( 
    /* Prototypes */

    hDirAC_mem->proto_direct_buffer_f_fx = NULL;

    hDirAC_mem->proto_diffuse_buffer_f_fx = NULL;

#ifdef FIX_BASOP_2329_UNINIT_VALUE

    hDirACRend->h_output_synthesis_psd_state.proto_direct_buffer_f_len = 0;

    hDirACRend->h_output_synthesis_psd_state.proto_diffuse_buffer_f_len = 0;

    hDirAC_mem->proto_diffuse_buffer_f_len = 0;

#endif

    test();

    test();

    IF( NE_32( renderer_type, RENDERER_BINAURAL_PARAMETRIC ) && NE_32( renderer_type, RENDERER_BINAURAL_PARAMETRIC_ROOM ) && NE_32( renderer_type, RENDERER_STEREO_PARAMETRIC ) )

lib_rend/lib_rend_fx.c

+0 −4
Original line number Diff line number Diff line
@@ -11265,11 +11265,7 @@ static void intermidiate_ext_dirac_render( 
            move16();

        }



#ifdef FIX_BASOP_2329_UNINIT_VALUE

        IF( hDirACRend->h_output_synthesis_psd_state.proto_diffuse_buffer_f_fx )

#else

        IF( hDirACRend->h_output_synthesis_psd_state.proto_diffuse_buffer_f_len > 0 )

#endif

        {

            Word16 shift, norm1, norm2;

            Word32 tmp1, tmp2;