Commit 6f4a8d4b authored by multrus's avatar multrus
Browse files

[cleanup] accept FIX_CLANG18_MSAN_IN_DEC_INIT_BY_MOVING_COMMON_INITS_TOGETHER

parent 46bddf8f

lib_com/options.h

+0 −1
Original line number Diff line number Diff line
@@ -85,7 +85,6 @@ 
#define FIX_1999_TEMPORARY_DISABLE_DIST_ATT_CHECK       /* Eri: Issue 1999: Range check on float values of distance attenuation, while the float values are not propagated to this function. The test is not correct, but configurable distance attenuation is not used in Characterization.*/

#define TMP_1342_WORKAROUND_DEC_FLUSH_BROKEN_IN_SR      /* FhG: Temporary workaround for incorrect implementation of decoder flush with split rendering */

#define NONBE_1122_KEEP_EVS_MODE_UNCHANGED              /* FhG: Disables fix for issue 1122 in EVS mode to keep BE tests green. This switch should be removed once the 1122 fix is added to EVS via a CR.  */

#define FIX_CLANG18_MSAN_IN_DEC_INIT_BY_MOVING_COMMON_INITS_TOGETHER /* FhG: fix CLANG18 MSAN error in decoder init */

#define FIX_1481_CLANG18_MSAN_INIT_LAST_ELEM_BRATE      /* FhG: initialize last_element_brate to avoid CLANG18 MSAN complaint */

#define FIX_1484_CLANG18_MSAN_INIT_ST_ELEM_BRATE        /* FhG: initialize st->element_brate per default */

#define FIX_1464_UBSAN_RC_CONTEXT_MAP                   /* FhG: BE UBSAN fix for float issue 1464 in the TCX range coder */

lib_dec/lib_dec_fx.c

+0 −15
Original line number Diff line number Diff line
@@ -232,7 +232,6 @@ ivas_error IVAS_DEC_Open( 
    move16();



    /* set high-level parameters */

#ifdef FIX_CLANG18_MSAN_IN_DEC_INIT_BY_MOVING_COMMON_INITS_TOGETHER

    st_ivas->codec_mode = 0; /* unknown before first frame */

    st_ivas->transport_config = IVAS_AUDIO_CONFIG_INVALID;

    st_ivas->intern_config = IVAS_AUDIO_CONFIG_INVALID;
@@ -244,15 +243,8 @@ ivas_error IVAS_DEC_Open( 
    move16();

    move16();



#endif

    IF( EQ_16( mode, IVAS_DEC_MODE_EVS ) )

    {

#ifndef FIX_CLANG18_MSAN_IN_DEC_INIT_BY_MOVING_COMMON_INITS_TOGETHER

        st_ivas->codec_mode = 0; /* unknown before first frame */

        st_ivas->transport_config = IVAS_AUDIO_CONFIG_INVALID;

        st_ivas->intern_config = IVAS_AUDIO_CONFIG_INVALID;

        st_ivas->writeFECoffset = 0;

#endif

        st_ivas->element_mode_init = EVS_MONO;

        st_ivas->ivas_format = MONO_FORMAT;

        hIvasDec->hasDecodedFirstGoodFrame = true; /* Functionality to suppress output for initial lost frames is disabled in EVS operation */
@@ -264,13 +256,6 @@ ivas_error IVAS_DEC_Open( 
    }

    ELSE IF( EQ_16( mode, IVAS_DEC_MODE_IVAS ) )

    {

#ifndef FIX_CLANG18_MSAN_IN_DEC_INIT_BY_MOVING_COMMON_INITS_TOGETHER

        st_ivas->codec_mode = 0; /* unknown before first frame */

        st_ivas->transport_config = IVAS_AUDIO_CONFIG_INVALID;

        st_ivas->intern_config = IVAS_AUDIO_CONFIG_INVALID;

        st_ivas->writeFECoffset = 0;

        st_ivas->sba_analysis_order = 0;

#endif

        st_ivas->element_mode_init = -1;

        st_ivas->ivas_format = UNDEFINED_FORMAT;

        st_ivas->renderer_type = RENDERER_DISABLE;