Commit 8a5fdcb9 authored by multrus's avatar multrus
Browse files

[cleanup] accept FIX_1209_SID_SIGNALING

parent 67c7dba9

lib_com/bitstream.c

+0 −8
Original line number Diff line number Diff line
@@ -4549,11 +4549,6 @@ ivas_error preview_indices( 
            case SID_ISM:

                st_ivas->ivas_format = ISM_FORMAT;

                break;

#ifndef FIX_1209_SID_SIGNALING

            case SID_MULTICHANNEL:

                st_ivas->ivas_format = MC_FORMAT;

                break;

#endif

            case SID_SBA_1TC:

                st_ivas->ivas_format = SBA_FORMAT;

                st_ivas->element_mode_init = IVAS_SCE;
@@ -4578,9 +4573,6 @@ ivas_error preview_indices( 
                }

                break;

            default:

#ifndef FIX_1209_SID_SIGNALING

                /* This should actually be impossible, since only 3 bits are read, so if this happens something is broken */

#endif

                return IVAS_ERROR( IVAS_ERR_INTERNAL_FATAL, "Invalid value %c found in SID format field.", st_ivas->sid_format );

        }

    }

lib_com/ivas_cnst.h

+0 −4
Original line number Diff line number Diff line
@@ -236,11 +236,7 @@ typedef enum 
#define SID_MDCT_STEREO                         0x1                         /*      1|      0|     0 */

#define SID_ISM                                 0x2                         /*      0|      1|     0 */

#define SID_MASA_1TC                            0x3                         /*      1|      1|     0 */

#ifdef FIX_1209_SID_SIGNALING

/*reserved*/                                  /*0x4*/                       /*      0|      0|     1 */

#else

#define SID_MULTICHANNEL                        0x4                         /*      0|      0|     1 */

#endif

#define SID_SBA_1TC                             0x5                         /*      1|      0|     1 */

#define SID_SBA_2TC                             0x6                         /*      0|      1|     1 */

#define SID_MASA_2TC                            0x7                         /*      1|      1|     1 */

lib_com/options.h

+0 −1
Original line number Diff line number Diff line
@@ -159,7 +159,6 @@ 
#define FIX_1129_EXT_REND_OUTPUT_HIGH                   /* Philips: issue 1129: External renderer BINAURAL_ROOM_REVERB format output level too high compared to internal rendering output */

#define NONBE_1244_FIX_SWB_BWE_MEMORY                   /* VA: issue 1244: fix to SWB BWE memory in case of switching from FB coding - pending a review by Huawei */

#define FIX_1113_CLDFB_REND_IN_ISAR                     /* issue 1113: fix the use of CLDFB renderer in split-rendering at the external renderer */

#define FIX_1209_SID_SIGNALING                          /* VA: issue 1209: remove dead code in IVAS SID signaling */

#define NONBE_1250_MCMASA_LS_OUTPUT                     /* VA: issue 1250: fix crash in McMASA to custom LS output decoding */

#define FIX_1158_FASTCONV_REVERB_HRTF                   /* Philips: issue 1158: Rendering with FastConv to BINAURAL_ROOM_REVERB uses BRIR convolution instead of HRTF */

#define NONBE_FIX_1176_OSBA_REVERB_JBM_ASAN_ERROR       /* Ericsson: Issue 1176, fix in TDREND_firfilt for subframes shorter than the filter length */

lib_dec/ivas_init_dec.c

+0 −14
Original line number Diff line number Diff line
@@ -92,7 +92,6 @@ static AUDIO_CONFIG ivas_set_audio_config_from_sba_order( 
}





#ifdef FIX_1209_SID_SIGNALING

/*---------------------------------------------------------------------*

 * ivas_dec_get_format( )

 *
@@ -455,7 +454,6 @@ ivas_error ivas_dec_get_format( 


    return IVAS_ERR_OK;

}

#endif





/*-------------------------------------------------------------------*
@@ -488,14 +486,10 @@ ivas_error ivas_dec_setup( 
     * Read IVAS format

     *-------------------------------------------------------------------*/



#ifdef FIX_1209_SID_SIGNALING

    if ( ( error = ivas_read_format( st_ivas, &num_bits_read ) ) != IVAS_ERR_OK )

    {

        return error;

    }

#else

    ivas_read_format( st_ivas, &num_bits_read );

#endif



    /*-------------------------------------------------------------------*

     * Read other signling (ISM/MC mode, number of channels, etc.)
@@ -1002,11 +996,6 @@ static ivas_error ivas_read_format( 
            case SID_ISM:

                st_ivas->ivas_format = ISM_FORMAT;

                break;

#ifndef FIX_1209_SID_SIGNALING

            case SID_MULTICHANNEL:

                st_ivas->ivas_format = MC_FORMAT;

                break;

#endif

            case SID_SBA_1TC:

                st_ivas->ivas_format = SBA_FORMAT;

                st_ivas->element_mode_init = IVAS_SCE;
@@ -1031,9 +1020,6 @@ static ivas_error ivas_read_format( 
                }

                break;

            default:

#ifndef FIX_1209_SID_SIGNALING

/* This should actually be impossible, since only 3 bits are read, so if this happens something is broken */

#endif

                return IVAS_ERROR( IVAS_ERR_INTERNAL_FATAL, "Invalid value %c found in SID format field.", st_ivas->sid_format );

        }

lib_enc/ivas_init_enc.c

+0 −5
Original line number Diff line number Diff line
@@ -164,11 +164,6 @@ void ivas_write_format_sid( 
        case ISM_FORMAT:

            ind = SID_ISM;

            break;

#ifndef FIX_1209_SID_SIGNALING

        case MC_FORMAT:

            ind = SID_MULTICHANNEL;

            break;

#endif

        case SBA_FORMAT:

            switch ( element_mode )

            {