Commit a63e9caa authored by Archit Tamarapu's avatar Archit Tamarapu
Browse files

[cleanup] accept NONBE_1199_OMASA_JBM_BRATE_SW_FLUSH

parent df7adc45

lib_com/options.h

+0 −1
Original line number Diff line number Diff line
@@ -183,7 +183,6 @@ 
#define FIX_1387_INIT_PRM_SQQ                           /* FhG: initialize pointer prm_sqQ, which might be uninitialized in case of bfi == 1 */

#define FIX_1349_TNS_CRASH                              /* FhG: Fix crash in TNS entropy coding, in case order of joint TNS coding is reduced to 0 */

#define NONBE_1300_TDREND_LARGE_ITD                     /* Eri: issue 1300: There was a bug feeding 1.25 ms frames to the TD renderer, causing out-of-buffer access. This was resolved. However, it is still possible that modeled HRTF with large ITDs could trigger out-of-buffer access. This adds a check to prevent this.*/

#define NONBE_1199_OMASA_JBM_BRATE_SW_FLUSH             /* VA: issue 1199: fix bug in renderer flush in OMASA JBM bitrate switching */

#define NONBE_1200_ISM_JBM_BRATE_SW_FLUSH               /* VA: issue 1200: fix bug in renderer flush in ISM JBM bitrate switching */

#define NONBE_1293_CRASH_FIRST_FRAME_LOST               /* VA: issue 1293: fix G.192 decoder crash when first frame is lost */

#define FIX_1384_MSAN_stereo_tcx_core_enc               /* VA: issue 1384: fix use-of-uninitialized value in stereo_tcx_core_enc() */

lib_dec/ivas_init_dec.c

+0 −4
Original line number Diff line number Diff line
@@ -565,9 +565,7 @@ ivas_error ivas_dec_setup( 
            }



            /* this should be non-zero if original input format was MASA_ISM_FORMAT */

#ifdef NONBE_1199_OMASA_JBM_BRATE_SW_FLUSH

            st_ivas->ism_mode = ISM_MODE_NONE;

#endif

            st_ivas->nchan_ism = st_ivas->bit_stream[( ivas_total_brate / FRAMES_PER_SEC ) - 3] + 2 * st_ivas->bit_stream[( ivas_total_brate / FRAMES_PER_SEC ) - 2];



            if ( st_ivas->nchan_ism > 0 )
@@ -804,14 +802,12 @@ ivas_error ivas_dec_setup( 
            }

        }



#ifdef NONBE_1199_OMASA_JBM_BRATE_SW_FLUSH

        if ( st_ivas->ini_frame > 0 && st_ivas->ivas_format == MASA_FORMAT )

        {

            st_ivas->nchan_ism = 0;

            st_ivas->ism_mode = ISM_MODE_NONE;

        }



#endif

        if ( st_ivas->ivas_format == ISM_FORMAT )

        {

            ISM_MODE last_ism_mode = st_ivas->ism_mode;

lib_dec/ivas_masa_dec.c

+0 −13
Original line number Diff line number Diff line
@@ -1477,19 +1477,6 @@ ivas_error ivas_masa_dec_reconfigure( 


    ivas_masa_set_elements( ivas_total_brate, st_ivas->mc_mode, st_ivas->nchan_transport, st_ivas->hQMetaData, &tmp, &tmp, &tmp, st_ivas->ivas_format, st_ivas->ism_mode, ism_total_brate );



#ifndef NONBE_1199_OMASA_JBM_BRATE_SW_FLUSH

    if ( st_ivas->ivas_format == MASA_FORMAT )

    {



        if ( st_ivas->hDecoderConfig->output_config != IVAS_AUDIO_CONFIG_EXTERNAL )

        {

            st_ivas->nchan_ism = 0; /* Initialization if it has not been already read from the end of the bitstream at the same time

                                    with reading of the format: nchan_ism is needed in MASA format because for the EXT output in

                                    MASA-only (pre-rendering mode of OMASA) the number of ISMs to output correct number of empty objects is needed */

        }

        st_ivas->ism_mode = ISM_MODE_NONE;

    }

#endif

    {

        int16_t tc_nchan_to_allocate;

        int16_t tc_nchan_transport;

lib_dec/lib_dec.c

+0 −12
Original line number Diff line number Diff line
@@ -1174,12 +1174,6 @@ ivas_error IVAS_DEC_ReadFormat( 
            // st_ivas->nchan_transport = nchan_transport_old; // ToDo: temporarily deactivated to keep FIX_HRTF_LOAD bit-exact but this is likely a bug in the main -> see issue #1200

#endif



#ifndef NONBE_1199_OMASA_JBM_BRATE_SW_FLUSH

            if ( st_ivas->ivas_format == MASA_FORMAT )

            {

                st_ivas->nchan_ism = 0; // ToDo: temporary hack to keep FIX_HRTF_LOAD bit-exact but this is likely a bug in the main -> see issue #1199

            }

#endif

            if ( st_ivas->hTcBuffer == NULL )

            {

                return IVAS_ERR_UNEXPECTED_NULL_POINTER;
@@ -1208,12 +1202,6 @@ ivas_error IVAS_DEC_ReadFormat( 
            st_ivas->nchan_transport = nchan_transport_old;

#else

            // st_ivas->nchan_transport = nchan_transport_old; // ToDo: temporarily deactivated to keep FIX_HRTF_LOAD bit-exact but this is likely a bug in the main -> see issue #1200

#endif

#ifndef NONBE_1199_OMASA_JBM_BRATE_SW_FLUSH

            if ( st_ivas->ivas_format == MASA_FORMAT )

            {

                st_ivas->nchan_ism = 0; // ToDo: temporary hack to keep FIX_HRTF_LOAD bit-exact but this is likely a bug in the main -> see issue #1199

            }

#endif

            if ( tc_granularity_new < st_ivas->hTcBuffer->n_samples_granularity )

            {