Commit b3f17252 authored by Sandesh Venkatesh's avatar Sandesh Venkatesh Committed by Manuel Jander
Browse files

Address review comments

parent 4714a44d

lib_com/cldfb.c

+6 −4
Original line number Diff line number Diff line
@@ -1365,7 +1365,7 @@ ivas_error openCldfb_ivas_fx( 
    CLDFB_TYPE type,                   /* i  : analysis or synthesis             */

    const Word32 sampling_rate,        /* i  : sampling rate                     */

    CLDFB_PROTOTYPE prototype,         /* i  : CLDFB version (1.25ms/5ms delay)  */

    CODE_TYPE code_type )

    const Word16 enc_dec )             /* i  : encoder/decoder flag            */

{

    HANDLE_CLDFB_FILTER_BANK hs;

    Word16 buf_len;
@@ -1379,14 +1379,17 @@ ivas_error openCldfb_ivas_fx( 
    move32();

    hs->prototype = prototype;

    move32();

    IF( code_type == IVAS_ENC )

    IF( enc_dec == ENC )

    {

        configureCldfb_ivas_enc_fx( hs, sampling_rate );

        hs->Q_cldfb_state = 0;

    }

    ELSE

    {

        configureCldfb_ivas_fx( hs, sampling_rate );

        hs->Q_cldfb_state = Q11;

    }

    move16();

    hs->memory32 = NULL;

    hs->FilterStates = NULL;

    hs->memory_length = 0;
@@ -1412,8 +1415,7 @@ ivas_error openCldfb_ivas_fx( 
    hs->cldfb_size = buf_len; /*for having original size at intermediatery conversion, will be removed on removing conversion*/

    move16();

    set32_fx( hs->cldfb_state_fx, 0, buf_len );

    hs->Q_cldfb_state = Q11;

    move16();



    *h_cldfb = hs;

    move16();

lib_com/cnst.h

+1 −5
Original line number Diff line number Diff line
@@ -803,11 +803,7 @@ typedef enum 
    CLDFB_ANALYSIS,

    CLDFB_SYNTHESIS

} CLDFB_TYPE;

typedef enum

{

    IVAS_ENC,

    IVAS_DEC_REND

} CODE_TYPE;



typedef enum

{

    CLDFB_PROTOTYPE_1_25MS,

lib_com/prot_fx.h

+1 −1
Original line number Diff line number Diff line
@@ -9804,7 +9804,7 @@ ivas_error openCldfb_ivas_fx( 
    CLDFB_TYPE type,                   /* i  : analysis or synthesis             */

    const Word32 sampling_rate,        /* i  : sampling rate                     */

    CLDFB_PROTOTYPE prototype,         /* i  : CLDFB version (1.25ms/5ms delay)  */

    CODE_TYPE code_type );

    const Word16 enc_dec );            /* i  : encoder/decoder flag            */















Word32 rand_gauss_fx(















    Word32 *x,

































lib_dec/init_dec_fx.c



+3
−3




























Original line number
Diff line number
Diff line








@@ -1447,13 +1447,13 @@ ivas_error init_decoder_ivas_fx(













    IF( ( idchan == 0 && NE_16( st_fx->element_mode, IVAS_CPE_MDCT ) ) || EQ_16( st_fx->element_mode, IVAS_CPE_TD ) )















    {















        /* open analysis for max. SR 48kHz */













        IF( NE_32( ( error = openCldfb_ivas_fx( &st_fx->cldfbAna, CLDFB_ANALYSIS, 48000, CLDFB_PROTOTYPE_1_25MS, IVAS_DEC_REND ) ), IVAS_ERR_OK ) )













        IF( NE_32( ( error = openCldfb_ivas_fx( &st_fx->cldfbAna, CLDFB_ANALYSIS, 48000, CLDFB_PROTOTYPE_1_25MS, DEC ) ), IVAS_ERR_OK ) )















        {















            return error;















        }































        /* open analysis BPF for max. SR 16kHz */













        IF( NE_32( ( error = openCldfb_ivas_fx( &st_fx->cldfbBPF, CLDFB_ANALYSIS, 16000, CLDFB_PROTOTYPE_1_25MS, IVAS_DEC_REND ) ), IVAS_ERR_OK ) )













        IF( NE_32( ( error = openCldfb_ivas_fx( &st_fx->cldfbBPF, CLDFB_ANALYSIS, 16000, CLDFB_PROTOTYPE_1_25MS, DEC ) ), IVAS_ERR_OK ) )















        {















            return error;















        }









@@ -1465,7 +1465,7 @@ ivas_error init_decoder_ivas_fx(













    }































    /* open synthesis for output SR */













    IF( NE_32( ( error = openCldfb_ivas_fx( &st_fx->cldfbSyn, CLDFB_SYNTHESIS, st_fx->output_Fs, CLDFB_PROTOTYPE_1_25MS, IVAS_DEC_REND ) ), IVAS_ERR_OK ) )













    IF( NE_32( ( error = openCldfb_ivas_fx( &st_fx->cldfbSyn, CLDFB_SYNTHESIS, st_fx->output_Fs, CLDFB_PROTOTYPE_1_25MS, DEC ) ), IVAS_ERR_OK ) )















    {















        return error;















    }

































lib_dec/ivas_corecoder_dec_reconfig_fx.c



+2
−2




























Original line number
Diff line number
Diff line








@@ -602,7 +602,7 @@ ivas_error ivas_cldfb_dec_reconfig_fx(













        /* create additional CLDFB synthesis instances */















        FOR( i = numCldfbAnalyses_old; i < numCldfbAnalyses; i++ )















        {













            IF( NE_32( ( error = openCldfb_ivas_fx( &( st_ivas->cldfbAnaDec[i] ), CLDFB_ANALYSIS, hDecoderConfig->output_Fs, CLDFB_PROTOTYPE_5_00MS, IVAS_DEC_REND ) ), IVAS_ERR_OK ) )













            IF( NE_32( ( error = openCldfb_ivas_fx( &( st_ivas->cldfbAnaDec[i] ), CLDFB_ANALYSIS, hDecoderConfig->output_Fs, CLDFB_PROTOTYPE_5_00MS, DEC ) ), IVAS_ERR_OK ) )















            {















                return error;















            }









@@ -622,7 +622,7 @@ ivas_error ivas_cldfb_dec_reconfig_fx(













        /* create additional CLDFB synthesis instances */















        FOR( i = numCldfbSyntheses_old; i < numCldfbSyntheses; i++ )















        {













            IF( NE_32( ( error = openCldfb_ivas_fx( &( st_ivas->cldfbSynDec[i] ), CLDFB_SYNTHESIS, hDecoderConfig->output_Fs, CLDFB_PROTOTYPE_5_00MS, IVAS_DEC_REND ) ), IVAS_ERR_OK ) )













            IF( NE_32( ( error = openCldfb_ivas_fx( &( st_ivas->cldfbSynDec[i] ), CLDFB_SYNTHESIS, hDecoderConfig->output_Fs, CLDFB_PROTOTYPE_5_00MS, DEC ) ), IVAS_ERR_OK ) )















            {















                return error;















            }