Commit bca0f0f2 authored by Archit Tamarapu's avatar Archit Tamarapu
Browse files

[cleanup] accept NONBE_1300_TDREND_LARGE_ITD

parent 3cf9196f

lib_com/options.h

+0 −1
Original line number Diff line number Diff line
@@ -178,7 +178,6 @@ 
#define FIX_1385_INIT_IGF_STOP_FREQ                     /* FhG: Initialize infoIGFStopFreq in init_igf_dec() */

#define FIX_1387_INIT_PRM_SQQ                           /* FhG: initialize pointer prm_sqQ, which might be uninitialized in case of bfi == 1 */

#define FIX_1349_TNS_CRASH                              /* FhG: Fix crash in TNS entropy coding, in case order of joint TNS coding is reduced to 0 */

#define NONBE_1300_TDREND_LARGE_ITD                     /* Eri: issue 1300: There was a bug feeding 1.25 ms frames to the TD renderer, causing out-of-buffer access. This was resolved. However, it is still possible that modeled HRTF with large ITDs could trigger out-of-buffer access. This adds a check to prevent this.*/

#define FIX_1384_MSAN_stereo_tcx_core_enc               /* VA: issue 1384: fix use-of-uninitialized value in stereo_tcx_core_enc() */

#define FIX_1384_MSAN_ivas_spar_dec_open                /* VA: issue 1386: fix use-of-uninitialized value in ivas_spar_dec_open() */

#define FIX_1388_MSAN_ivas_init_decoder                 /* VA: issue 1388: fix use-of-uninitialized value in ivas_init_decoder() */

lib_rend/ivas_objectRenderer.c

+0 −4
Original line number Diff line number Diff line
@@ -437,9 +437,7 @@ ivas_error TDREND_GetMix( 
    float hrf_left_delta[SFX_SPAT_BIN_MAX_FILTER_LENGTH];

    float hrf_right_delta[SFX_SPAT_BIN_MAX_FILTER_LENGTH];

    int16_t intp_count;

#ifdef NONBE_1300_TDREND_LARGE_ITD

    int16_t currShift, prevShift, transition_len, length_in2;

#endif



    error = IVAS_ERR_OK;
@@ -465,7 +463,6 @@ ivas_error TDREND_GetMix( 
        {

            TDREND_SRC_REND_UpdateFiltersFromSpatialParams( hBinRendererTd, SrcRend_p, SrcSpatial_p, Src_p->hrf_left_prev,

                                                            Src_p->hrf_right_prev, hrf_left_delta, hrf_right_delta, &intp_count, &Src_p->filterlength, &Src_p->itd, &Src_p->Gain, Src_p );

#ifdef NONBE_1300_TDREND_LARGE_ITD

            /* For large ITD values at lower sampling rate, check if the transition can be done */

            if ( Src_p->itd * Src_p->previtd < 0 )

            {
@@ -479,7 +476,6 @@ ivas_error TDREND_GetMix( 
                    Src_p->itd = 0;

                }

            }

#endif

        }



        /* Render source if needed */