Accept FIX_911_REMOVE_CREND_DUPLICATION (e4403854) · Commits · SA4 / Audio / IVAS BASOP

lib_com/options.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -182,7 +182,6 @@
		#endif
		#define NONBE_FIX_1058_DECODER_ERROR_WITH_REVERB_ROOM /* FhG: issue 1058: do not initialize EFAP when IntSetup is HOA3 */
		#define NONBE_FIX_943_RECONFIG_IGF_AFTER_SETTING_BW /* FhG: issue 943: fix crash in BW switchin from WB in MDCT-Stereo core encoder */
		#define FIX_911_REMOVE_CREND_DUPLICATION /* VA: issue 911: resolve duplication of CRend binaural external renderer function */
		#define FIX_938_GCC_12_WARNINGS /* VA: issue #938: remove set_f(.,.,0) call in which length is always 0 to remove GCC 12.0 warning */
		#define NONBE_FIX_944_FEC_OMASA_1SEP_OBJ_MASA /* Nokia: issue 944: fix FEC error in OMASA */

lib_rend/ivas_crend.c

+0 −143

Original line number	Diff line number	Diff line
		@@ -1738,149 +1738,6 @@ static ivas_error ivas_rend_crendConvolver(
		}


		#ifndef FIX_911_REMOVE_CREND_DUPLICATION
		/-----------------------------------------------------------------------------------------
		* Function ivas_rend_crendProcess()
		*
		* Process call for IVAS Crend renderer
		-----------------------------------------------------------------------------------------/

		ivas_error ivas_rend_crendProcess(
		const CREND_WRAPPER *pCrend,
		const AUDIO_CONFIG inConfig,
		const AUDIO_CONFIG outConfig,
		DECODER_CONFIG_HANDLE hDecoderConfig,
		COMBINED_ORIENTATION_HANDLE hCombinedOrientationData,
		IVAS_OUTPUT_SETUP_HANDLE hIntSetup,
		EFAP_HANDLE hEFAPdata,
		float output[], / i/o: input/output audio channels */
		const int32_t output_Fs,
		#ifdef SPLIT_REND_WITH_HEAD_ROT
		const int16_t num_subframes /* i : number of subframes to render */,
		const int16_t pos_idx
		#else
		const int16_t num_subframes /* i : number of subframes to render */
		#endif
		)
		{
		int16_t i, subframe_idx, subframe_len;
		int16_t nchan_out;
		float pcm_tmp[BINAURAL_CHANNELS][L_FRAME48k];
		float *p_pcm_tmp[BINAURAL_CHANNELS];
		IVAS_REND_AudioConfigType inConfigType;
		int8_t combinedOrientationEnabled;
		ivas_error error;
		CREND_HANDLE hCrend;

		#ifdef SPLIT_REND_WITH_HEAD_ROT
		hCrend = pCrend->hCrend[pos_idx];
		#else
		hCrend = pCrend->hCrend;
		#endif

		combinedOrientationEnabled = 0;
		if ( hCombinedOrientationData != NULL )
		{
		for ( subframe_idx = 0; subframe_idx < num_subframes; subframe_idx++ )
		{
		if ( hCombinedOrientationData->enableCombinedOrientation[subframe_idx] != 0 )
		{
		combinedOrientationEnabled = 1;
		break;
		}
		}
		}

		push_wmops( "ivas_rend_crendProcess" );
		inConfigType = getAudioConfigType( inConfig );

		if ( ( error = getAudioConfigNumChannels( outConfig, &nchan_out ) ) != IVAS_ERR_OK )
		{
		return error;
		}

		subframe_len = (int16_t) ( output_Fs / ( FRAMES_PER_SEC * MAX_PARAM_SPATIAL_SUBFRAMES ) );

		for ( i = 0; i < BINAURAL_CHANNELS; i++ )
		{
		p_pcm_tmp[i] = pcm_tmp[i];
		}

		for ( subframe_idx = 0; subframe_idx < num_subframes; subframe_idx++ )
		{
		/* Early Reflections */
		if ( hCrend->reflections != NULL )
		{
		if ( hCrend->reflections->use_er == 1 && hCrend->reflections->is_ready == 1 )
		{
		if ( ( error = ivas_er_process( hCrend->reflections, subframe_len, subframe_idx, output, inConfig ) ) != IVAS_ERR_OK )
		{
		return error;
		}
		}
		}

		if ( hDecoderConfig && combinedOrientationEnabled )
		{
		/* Orientation tracking */

		/* Rotation in SHD for:
		MC with elevation (5_1_2 / 5_1_4 / 7_1_4) -> BINAURAL
		SBA SPAR -> BINAURAL or BINAURAL_ROOM
		*/
		if ( inConfig == IVAS_AUDIO_CONFIG_FOA \|\| inConfig == IVAS_AUDIO_CONFIG_HOA2 \|\| inConfig == IVAS_AUDIO_CONFIG_HOA3 )
		{
		rotateFrame_shd( hCombinedOrientationData, output, subframe_len, *hIntSetup, subframe_idx );
		}
		/* Rotation in SD for MC -> BINAURAL_ROOM */
		else if ( ( hIntSetup != NULL ) && hIntSetup->is_loudspeaker_setup )
		{
		rotateFrame_sd( hCombinedOrientationData, output, subframe_len, *hIntSetup, hEFAPdata, subframe_idx );
		}
		}

		if ( inConfigType == IVAS_REND_AUDIO_CONFIG_TYPE_CHANNEL_BASED \|\| inConfigType == IVAS_REND_AUDIO_CONFIG_TYPE_AMBISONICS )
		{
		#ifdef SPLIT_REND_WITH_HEAD_ROT
		if ( ( error = ivas_rend_crendConvolver( pCrend, inConfig, outConfig, output, p_pcm_tmp, output_Fs, subframe_idx, pos_idx ) ) != IVAS_ERR_OK )
		#else
		if ( ( error = ivas_rend_crendConvolver( pCrend, inConfig, outConfig, output, p_pcm_tmp, output_Fs, subframe_idx ) ) != IVAS_ERR_OK )
		#endif
		{
		return error;
		}

		if ( hCrend->hReverb != NULL )
		{
		#ifdef SPLIT_REND_WITH_HEAD_ROT
		if ( ( error = ivas_reverb_process( pCrend->hCrend[pos_idx]->hReverb, inConfig, 1, output, p_pcm_tmp, subframe_idx ) ) != IVAS_ERR_OK )
		#else
		if ( ( error = ivas_reverb_process( pCrend->hCrend->hReverb, inConfig, 1, output, p_pcm_tmp, subframe_idx ) ) != IVAS_ERR_OK )
		#endif
		{
		return error;
		}
		}

		/* update combined orientation access index */
		ivas_combined_orientation_update_index( hCombinedOrientationData, subframe_len );
		}
		else
		{
		return IVAS_ERR_INVALID_INPUT_FORMAT;
		}
		}

		/* move to output */
		for ( i = 0; i < nchan_out; i++ )
		{
		mvr2r( pcm_tmp[i], output[i], num_subframes * subframe_len );
		}

		pop_wmops();
		return IVAS_ERR_OK;
		}
		#endif

		/-----------------------------------------------------------------------------------------
		* Function ivas_rend_crendProcessSubframe()

lib_rend/ivas_prot_rend.h

+0 −19

Original line number	Diff line number	Diff line
		@@ -888,25 +888,6 @@ ivas_error ivas_rend_initCrendWrapper(
		);


		#ifndef FIX_911_REMOVE_CREND_DUPLICATION
		ivas_error ivas_rend_crendProcess(
		const CREND_WRAPPER *pCrend,
		const AUDIO_CONFIG inConfig,
		const AUDIO_CONFIG outConfig,
		DECODER_CONFIG_HANDLE hDecoderConfig,
		COMBINED_ORIENTATION_HANDLE hCombinedOrientationData,
		IVAS_OUTPUT_SETUP_HANDLE hIntSetup,
		EFAP_HANDLE hEFAPdata,
		float output[], / i/o: input/output audio channels */
		const int32_t output_Fs,
		#ifdef SPLIT_REND_WITH_HEAD_ROT
		const int16_t num_subframes, /* i : number of subframes to render */
		const int16_t pos_idx /* i : pose index */
		#else
		const int16_t num_subframes /* i : number of subframes to render */
		#endif
		);
		#endif
		ivas_error ivas_rend_crendProcessSubframe(
		const CREND_WRAPPER pCrend, / i/o: Crend wrapper handle */
		const AUDIO_CONFIG inConfig, /* i : input audio configuration */