Skip to content

[BASOP] L_add_c erroneous / undeprecate DEPR_L_add_c?

Basic info

The L_add_c basic operator was marked as deprecated under BASOP_NOGLOB and renamed to DEPR_L_add_c. This was a mistake back then as only the L_sub_c operator was documented as having problems (see STL manual). It was then also spotted that an L_add_c operator remained in the code when BASOP_NOGLOB is activated (which does not use the carry flag. This is wrong and may have been an oversight. In the mid term it may be beneficial to allow the L_add_c operator again to allow optimization.

Proposal:

  • remove current L_add_c operator (which is wrong and not used in the code)
  • rename DEPR_L_add_c to L_add_c

~~Furthermore finding such issues is very cumbersome with the BASOP_NOGLOB macro in the basic operators all over the place. This would not have been seen by me if I wouldn't have activated BASOP_NOGLOB in my local copy. We now are anyway in the state that the BASOP_NOGLOB is known to work. There seems little benefit to keep it.

Proposal 2:

  • activate BASOP_NOGLOB~~

It is also proposed to activate BASOp_NOGLOB - but let's do this in another ticket for orthogonal MRs.

Edited by Stefan Doehla