lib_enc, ivas_band_cov(): IF vs if cleanup to gain WMOPS.
Basic info
There is a discrepancy between the WMOPS complexity of the float and main branches of the lib_enc. One of the reasons are some oversights in the usage of IF() statements, as opposed to classic if().
Float:
--- Complexity analysis [WMOPS] ---
|------ SELF ------| |--- CUMULATIVE ---|
routine calls min max avg min max avg
--------------- ------ ------ ------ ------ ------ ------ ------
ivas_enc 1.00 10.254 10.254 10.254 202.396 264.355 246.541
front_vad_SPAR 1.00 0.001 0.001 0.001 0.001 0.001 0.001
ivas_spar_enc_process 1.00 101.014 105.553 103.065 104.375 108.499 106.325
ivas_dirac_enc 1.00 0.797 1.570 1.281 2.752 3.551 3.260
dirac_enc_param_est 1.00 1.924 1.982 1.979 1.924 1.982 1.979
ivas_mct_enc 1.00 0.825 0.826 0.825 85.945 147.738 129.961
ivas_cpe_enc 2.00 2.849 2.858 2.851 76.333 93.019 82.897
front_vad 2.00 0.004 0.005 0.005 0.004 0.005 0.005
pre_proc_front 4.00 44.099 45.268 44.697 44.099 45.268 44.697
ivas_core_enc 2.00 0.279 0.281 0.279 28.885 45.151 35.345
pre_proc 4.00 0.648 6.125 0.656 0.648 6.125 0.656
mdct_core_whitening 2.00 27.957 43.143 34.409 27.957 43.143 34.409
mct_encoding 1.00 0.192 16.442 12.745 0.196 36.681 15.284
mct_core_enc_mct 1.00 0.004 2.538 2.505 0.004 22.358 2.539
mdct_core_Q 2.00 6.385 33.820 30.955 6.385 33.820 30.955
stereo_coder_tcx 0.00 13.176 20.726 16.951 13.176 20.726 16.951
--------------- ------ ------ ------ ------
total 1000.00 202.411 264.370 246.556BASOP:
--- Complexity analysis [WMOPS] ---
|------ SELF ------| |--- CUMULATIVE ---|
routine calls min max avg min max avg
--------------- ------ ------ ------ ------ ------ ------ ------
ivas_enc 1.00 52.369 54.277 52.530 390.561 424.649 401.692
front_vad_SPAR 1.00 0.001 0.001 0.001 0.001 0.001 0.001
ivas_spar_enc_process 1.00 155.277 164.110 156.671 161.827 170.824 163.264
ivas_dirac_enc 1.00 1.011 1.814 1.534 6.072 6.891 6.594
dirac_enc_param_est 1.00 4.719 5.085 5.059 4.719 5.085 5.059
ivas_mct_enc 1.00 4.468 4.480 4.473 173.674 209.227 185.898
ivas_cpe_enc 2.00 11.597 12.679 12.189 116.580 130.659 121.185
front_vad 2.00 0.003 0.003 0.003 0.003 0.003 0.003
pre_proc_front 4.00 58.521 60.095 59.433 58.521 60.095 59.433
ivas_core_enc 2.00 3.324 3.702 3.334 44.993 59.254 49.559
pre_proc 4.00 1.127 7.629 1.135 1.127 7.629 1.135
mdct_core_whitening 2.00 40.535 53.577 45.090 40.535 53.577 45.090
mct_encoding 1.00 11.325 22.052 18.866 15.682 50.815 23.214
mct_core_enc_mct 1.00 3.420 4.370 4.321 3.685 31.084 4.348
mdct_core_Q 2.00 28.283 40.109 37.026 28.283 40.109 37.026
stereo_coder_tcx 0.00 27.664 27.664 27.664 27.664 27.664 27.664
--------------- ------ ------ ------ ------
total 1000.00 390.561 424.649 401.692Bug description
Ways to reproduce
Box folder: ...\Box_EXTERNAL_IVAS_BASOP_VERIFICATION\issues\issue-xxxx
Edited by multrus