Admin message

WARNING! Gitlab maintenance operation scheduled for Monday, 20 April between 12:00 and 14:00 (CET). During this time window, short service interruptions (less than 5 minutes) may occur. Thank you in advance for your understanding.

wrong constant in TD stereo

Basic info

  • Fixed point:
    • Encoder (fixed): 20cb1008

Bug description

Two constant were wrong in the time domain stereo analysis, leading to a wrong down-mixing ratio / bit allocation

#define RATIO_MAX_FX_Q24 ( 2516582 ) /* 1.5f in Q24 */    /* Maximum correlation ratio */
#define RATIO_MAX_FX_Q23 ( 1258291 ) /* 1.5f in Q23 */    /* Maximum correlation ratio */

should be : 
#define RATIO_MAX_FX_Q24 ( 25165824 ) /* 1.5f in Q24 */    /* Maximum correlation ratio */
#define RATIO_MAX_FX_Q23 ( 12582912 ) /* 1.5f in Q23 */    /* Maximum correlation ratio */

probably a copy/paste error

Ways to reproduce

Assignee Loading
Time tracking Loading