Cleanup of pre-processor macros

Basic info

• Float reference: ceb8871f (Thu Mar 13 15:08:00 2025 +0000)
• Fixed point: 2d6aaa67 (Tue Mar 18 11:55:13 2025 +0000)

These switches are present in the basop main in the version indicated above. The corresponding switch in ivas-float-update, if it exists, is listed in the right column. The plan is to clean out switches that are not necessary, from both main and ivas-float-update.

@all, please indicate if you want to keep the switch by clicking the check-mark. The target is to review this by Friday March 21st.

main	ivas-float-update
IVAS_FLOAT_FIXED_CONVERSIONS
MSAN_FIX
FIX_TMP_714
BASOP_NOGLOB_TMP_715
EVS_FUNC_MODIFIED
REMOVE_IVAS_UNUSED_PARAMETERS_WARNING
MOD_BIT_ALLOC_ROM_TABLE
SIMPLIFY_CODE_BE
CR_2109_to_2112_cd0_ce0
FIX_QMETADATA_PENALTY
FIX_1013_CRASH_HQ_CORE_DEC
NONE_BE_FIX_BASOP_1044_OSBA_PRERENDER_MIX_GAINS	NONE_BE_FIX_BASOP_1044_OSBA_PRERENDER_MIX_GAINS
NONBE_1233_HQ_CLASSIFIER_DIV_BY_ZERO	NONBE_1233_HQ_CLASSIFIER_DIV_BY_ZERO
FIX_ISSUE_1062_AND_1068_TON_ENE_EST_FX
FIX_ISSUE_987
FIX_1054_IF_ELSE_CMPLX
FIX_1052_COPY_CMPLX_DISCREPANCY
FIX_1049_SHR_RO_COMPLEXITY
NONBE_IMPROVE_DIRAC_INTENSITY_PREC
FIX_1103_OPT_L_NORM_ARR
FIX_1105_OPT_MINIMUM_SL
FIX_1104_OPT_GETMINSCALEFAC
FIX_1106_SIMPLIFY_SET32FX
FIX_1107_VADDINC
FIX_1009_OPT_PARAMMC_RENDER
FIX_1109_OPTIM_MCT_STEREO_IGF_DEC
FIX_1110_OPTIM_DIRAC_DECORR_PROC
FIX_1127_IMPROVE_SBA_MLD
FIX_1100_REMOVE_LPC_RESCALING
FIX_1133_IMPROVE_MC_MLD
FIX_ISSUE_1122
FIX_ISSUE_1125
FIX_1132_STACK_CORRUPTION
FIX_ISSUE_1092
FIX_ISSUE_1135
FIX_ISSUE_1148
FIX_ISSUE_1147
FIX_ISSUE_1150
FIX_ISSUE_1151
FIX_ISSUE_1153
FIX_ISSUE_1154
FIX_ISSUE_1157
FIX_ISSUE_1152
FIX_ISSUE_1156
FIX_DISCLAIMER
FIX_ISSUE_1167
FIX_1009_REPLACE_DIV_SQRT_BY_ISQRT_LC
FIX_1113_OPT_DIRAC_BIN_REND
FIX_ISSUE_1187
FIX_ISSUE_1186
FIX_ISSUE_1165
FIX_ISSUE_1185
FIX_ISSUE_1209
FIX_ISSUE_1218
FIX_ISSUE_1290
IVAS_ISSUE_1188_EVS_CRASH
FIX_ISSUE_1155
FIX_1010_OPT_DIV
FIX_1010_OPT_SINGLE_RESCALE
FIX_1010_OPT_GIVENS
FIX_1010_OPT_GIVENS_INV
FIX_1010_OPT_NORM_NOSAT
FIX_1010_OPT_SEC_SINGLE_RESCALE
FIX_1072_SPEEDUP_matrixTransp2Mul_fx
FIX_1072_REDUCE_DIVS
FIX_ISSUE_1230
NONBE_1211_DTX_BR_SWITCHING	NONBE_1211_DTX_BR_SWITCHING
FIX_1189_GSC_IVAS_OMASA	NONBE_FIX_1189_GSC_IVAS_OMASA
NONBE_1273_ISM_METADATA_COUNTER	NONBE_1273_ISM_METADATA_COUNTER
NONBE_FIX_GSC_BSTR	NONBE_FIX_GSC_BSTR
FIX_1101_IVAS_SPAR_DEC_UPMIXER_SF
Note:
FIX_1101_IVAS_SPAR_DEC_UPMIXER_SF_USE_MADD_ADD_WEIGHTS
FIX_1101_IVAS_SPAR_DEC_UPMIXER_SF_SPLIT_LOOPS
FIX_1101_IVAS_SPAR_DEC_UPMIXER_SF_HQ_CONSTANTS
FIX_1101_IVAS_SPAR_DEC_UPMIXER_SF_USE_UNIQUE_SHL
FIX_11_1_IVAS_SPAR_DEC_UPMIXER_SF_RND_COEFFS
FIX_ISSUE_1237
FIX_ISSUE_1237_KEEP_EVS_BE
FIX_ISSUE_1214
FIX_881_HILBERT_FILTER
FIX_ISSUE_1245
FIX_ISSUE_1291
FIX_920_IGF_INIT_ERROR	FIX_920_IGF_INIT_ERROR
FIX_MINOR_SVD_WMOPS_MR1010X
FIX_USAN_ISSUES
SVD_WMOPS_OPT
NONBE_FIX_1087_OOB_SBA_DTX_RS	NONBE_FIX_1087_OOB_SBA_DTX_RS
FIX_ISSUE_1279
FIX_ISSUE_1247
NONBE_FIX_1087_OOB_SBA_DTX_RS	Note: occurs twice in main
FIX_1285_DECODER_CRASH
FIX_1072_SPEEDUP_gainpanning
FIX_1072_SPEEDUP_COMPUTEDIFUSENESS
FIX_1320_LOWRATE_ACELP
FIX_1297_OVERFLOW
FIX_1298
FIX_1300_ICA_SHIFT_QUANT_IMPROV
FIX_1301_CORRECT_TD_CNST
NONBE_FIX_1277_EVS_DTX_HIGH_RATE_THRESHOLD	NONBE_FIX_1277_EVS_DTX_HIGH_RATE_THRESHOLD
NONBE_FIX_708_OSBA_BR_SWITCHING_CRASH
OPT_STEREO_32KBPS_V1
DOT_PROD_CHOLESKY_64BIT
OPT_BASOP_ADD_v1
FIX_ISSUE_1327
NONBE_FIX_1402_WAVEADJUST
SUPPORT_FORCE_TCX10_TCX20	SUPPORT_FORCE_TCX10_TCX20
FIX_ISSUE_1376

The following switches are present in ivas-float-update in the version indicated above. These do not have any counterpart in the main, or at least none I could identify.

@all, please check the ones you would like to keep. The target is to review this by Friday March 21st.

ivas-float-update
NON_BE_FIX_1048_THRESHOLD_COH_BASOP
NONBE_FIX_1054_NEGATIVE_LVQ_INDEX
NONBE_FIX_738_QUATERNION_SLERP_PRECISION
FIX_1033_MEMORY_LEAK_OMASA
FIX_976_USAN_PVQ_ENC_DEC_EVS_CR
FIX_1027_GSC_INT_OVERFLOW
NONBE_FIX_1096_NAN_VALUES_IN_DIRAC_TO_STEREO
NON_BE_1055_RESET_LP_MEMORIES
NONBE_FIX_1069_SVD_TUNING
NONBE_FIX_1010_STEREO_CNG_DIV_BY_ZERO
NONBE_MDCT_ST_DTX_SKIP_DEWHITENING_OF_NOISE_SHAPES_ON_SID_FRAMES
NONBE_MDCT_ST_PLC_DO_NOT_SCALE_OLD_OUT_IF_FIRST_GOOD_IS_SID
NON_BE_FIX_1137_GSC_IVAS_FXFLT_DECODING
NONBE_FIX_1132_THRESHOLD_POW_IN_SWB_TBE
FIX_BASOP_812_NAN_COHSNR
NON_BE_FIX_807_MASA_DTX_BRSW
NON_BE_FIX_BASOP_819_THRESHOLD_MASA2TOTAL
FIX_828_PORT_1152_FROM_FLT_REPO
NONE_BE_FIX_816_LFE_PLC_FLOAT
FIX_835_PARAMMC_BUFFER_VALUES
NONBE_FIX_943_PORT_1208_DFT_STEREO_PLC_BURST
FIX_903_ZERO_OUT_IMDCT_BUFFERS_FOR_MCT_IGNORE
FIX_853_DECODE_MASA_ISM_AZIMUTH_PREC_FP
NONBE_FIX_1205_TD_STEREO_MOD_CT
NONBE_FIX_1213_SBA_DET_MAT_INV_3BY3
NONBE_FIX_1204_MDCT_STEREO_NOISE_EST_SCALING
NONBE_FIX_1189_GSC_IVAS_OMASA
NONBE_FIX_708_OSBA_BR_SWITCHING_CRASH
NONBE_1319_M2R_PRECISION_ALIGN
BASOP_NOGLOB

The following switches are present in main in the version indicated above. They are not in options.h, and the status of these is unclear. If they serve a purpose, I suggest they should be kept. If they are not used, they could be cleaned out.

@all, please check the ones you would like to keep. The target is to review this by Friday March 21st.

main
BASOP_NOGLOB_DECLARE_LOCAL
REMOVE_IVAS_UNUSED_PARAMETERS_WARNING
IVAS_CODE
NEW_IVAS_OPEN_DEC
IVAS_CODE_SWITCHING
IVAS_CODE_CNG_FIX185_PLC_FADEOUT
ADD_IVAS_HQ_CODE
ADD_IVAS_HQ_CODE_L_SPEC
ADD_IVAS_TBE_CODE
ADD_IVAS_GS_DEC_IMPR
ADD_IVAS_TNS
ADD_IVAS_TBE_CODE
ADD_IVAS_CLDFB
SOLVED_COMP_ENC_DEC
#if 0 … #endif
#if 1 … #endif
NON_BE_FIX_BASOP_819_THRESHOLD_MASA2TOTAL
DIFF_FLOAT_FIX PMT( "…" )