Skip to content

Port float MR 1374: Cleanup 20240207

Basic Info

  • Original merge request in float repo: ivas-codec-pc/ivas-codec!1374 (merged)

  • Switches with strikethrough did not apply to BASOP (already ported, solely in scripts)

  • Switches with ⚠️ need to be accepted later, once the new HRTF binary format is used

    BE

    • ⚠️ FIX_638_ENERGIE_IAC_ROM_TABLES - Orange: Missing left/right and coherence late reverb tables in binary format -> accept
    • FIX_WARNING_SPLIT_RENDER - Orange: fix warning on windows build vscode -> accept
    • ⚠️ FIX_INV_DIFFUSE_WEIGHT - Orange : Fix error in energy compensation in late binaural reverb -> accept
    • FIX_20_MS_FRAME_LEN_TABLES_CONVERTER - Orange : generate_tables_converter tools can generate rom for 5 and 20 ms frame length -> accept
    • FIX_955_FASTCONV_REND_IN_ISM - VA: put FastConv rendering call under DEBUGGING -> accept
    • FIX_969_USAN_IGF_ARITH - FhG: issue 969: fix USAN error in igf_sce_dec; same issue as #962 (closed) -> accept
    • FIX_959_MASA_LINEAR_REND - VA: issue 959: remove unused calling of ivas_sba_linear_renderer() in MASA rendering -> accept

    Non-BE

    • NONBE_FIX_BINARY_BINAURAL_READING - Orange: Add support for reading binaural binary file -> accept
    • ⚠️ NONBE_FIX_AVG_IAC_CLDFB_REVERB - Orange: Add computation avg energy and iac tables for rom and binaural binary file -> accept
    • NONBE_FIX_935_EARLY_REFLECTIONS_WRONG_ORDER - Qualcomm: issue 953: fix order or ER channels in LC mode -> accept
    • NONBE_FIX_935_SBA_REVERB - FhG: issue 935: fix MSAN error for SBA related to BINAURAL_ROOM_REVERB -> accept
    • NONBE_FIX_952_MC_PARAMUPMIX_5MS - Dlb : issue 952 : Differences between 5ms and 20ms rendering for ParamUpmix -> accept
    • NONBE_FIX_967_ISM_MONO_DMX - FhG: issue 967: accumulating energies in ISM mono DMX -> accept
    • NONBE_FIX_968_ISM_BRIR_WITH_HEADROTATION_5MS_FIX - FhG : issue #968 (closed): differences between 5ms and 20ms rendering for discrete ISM with BRIR and head rotation -> accept
    • NONBE_FIX_977_OSBA_GAIN_MISMATCH - Dlb : issue 977 : Output gain mismatch for different bit rates in OSBA -> accept
Edited by Archit Tamarapu