Skip to content

BASOP porting MR 107 - Port MR 1459 from float - 20240312 cleanup

Basic Info

Leftover / not accepted

  • ⚠️ FIX_638_ENERGIE_IAC_ROM_TABLES - Orange: Missing left/right and coherence late reverb tables in binary format -> accept
  • ⚠️ FIX_INV_DIFFUSE_WEIGHT - Orange : Fix error in energy compensation in late binaural reverb -> accept
  • ⚠️ NONBE_FIX_AVG_IAC_CLDFB_REVERB - Orange: Add computation avg energy and iac tables for rom and binaural binary file -> accept
  • ⚠️ NONBE_FIX_922_PRECOMPUTED_HRTF_PROPERTIES - Philips: Use pre-computed HRTF average L/R energies and IAC in all renderers -> accept
  • ⚠️ FIX_777_COMBI_RENDER_CONFIG_FILE - Philips: Fix for combined renderer config file support -> accept if !1416 (merged) passes
    • Pending testvector update in BASOP
  • ⚠️ NONBE_FIX_864_JBM_RENDER_FRAMESIZE - FhG: issue #864 (closed): fix different behaviour of JBM TSM with different render frame sizes ->
    • See MR 87, ported separately to main, will propagate to -pc branches. Cleanup once present here.

BE

  • From fl!1450
    • FIX_998_UNUSED_FUNCTION - FhG: issue 998: delete unused funtion ivas_dirac_dec_get_response_split_order -> accept
    • FIX_1009_ISM_NONDIEGETIC_PANNING - FhG: issue #1009 (closed): use correct object buffer for ISM1 non-diegetic pan -> accept
  • From fl!1459
    • FIX_1020_AEID_SELECTION_ERRORS - Philips: issue #1020 (closed): fix for acoustic environment ID selection errors -> accept
    • FIX_993_REMOVE_SBA_GET_ORDER - VA: issue 993: remove unused function ivas_sba_get_order() -> accept
    • FIX_1002_DEC_PHASE_ECU_USAN_OF_PHASE - Eri: issue #1002 (closed), usan-value-out-of-range-for-int16, kept BE for PLC-conditions -> ⚠️ N/A to BASOP, see MR 101
    • FIX_960_SYN_OUTPUT - VA: issue 960: unused function syn_output() is removed -> ⚠️ N/A to BASOP, see MR 100

Non-BE

  • From fl!1450
    • NONBE_FIX_1012_1013_JBM_FLUSH_BUFFER - FhG: issues #1012 (closed), 1013: JBM flush function uses wrong output buffer -> accept
    • NONBE_FIX_1004_USAN_DTX_MASA_NO_DIRS - Nokia: fix USAN error caused by non-setting of correctly the number of MASA directions in DTX -> accept
    • NONBE_FIX_1014_1015_1016_OSBA_JBM_STEREO - FhG: issues #1014 (closed), #1015 (closed), #1016 (closed): fix tc buffer info update in the discrete ism renderer -> accept
  • From fl!1459
    • NONBE_FIX_987_PARAMC_BINAURAL_REVERB_RENDERING - FhG: issue 987: solution b: downmix HOA3 to stereo a input for the reverberator -> accept
    • NONBE_FIX_1006_PAST_DMX_NRG_ERROR - Eri/FhG: Issue 1006: Bug fix in ivas_stereo_dft_dec not replicated in ivas_stereo_dft_dec_dmx -> accept
    • NONBE_FIX_1010_STEREO_CNG_DIV_BY_ZERO - Eri: Issue 1010: Division by zero in Stereo CNG -> ⚠️ See MR 98, already ported
Edited by Archit Tamarapu