Skip to content

Compilation warnings in BASOP

Basic info

Bug description

During the porting of float CRs to BASOP, a new compilation warning is sometimes introduced. How to address them, one by one by respective companies, in one extra maintenance commit, …?

Specifically, when compiled in MSVC, the current BASOP main reports:

Description File Line Compilation flag
'=': conversion from 'float' to 'Word32', possible loss of data

..\\lib_rend\\ivas_reverb_utils_fx.c

 167 FIX_1741_REVERB_TIMES_Q_FORMAT
'=': conversion from 'Word32' to 'Word16', possible loss of data

..\\lib_dec\\ivas_jbm_dec_fx.c

 3845 NONBE_FIX_1070_USAN_SEGFAULT_MC_TO_BIN_BTSW_HEADROT
'function': conversion from 'int' to 'const UWord16', possible loss of data

..\\lib_enc\\ivas_corecoder_enc_reconfig_fx.c

 699 NONBE_FIX_ISM_XOVER_BR

The second one can be handled as part of #1852 (closed) and I can take care of it.

Status - solved?

  • ivas_reverb_utils_fx.c
  • ivas_jbm_dec_fx.c
  • ivas_corecoder_enc_reconfig_fx.c
Edited by vaclav