renderer_struct - inconsistent variable naming BASOP - float
Basic info
Bug description
One of the members of struct renderer_struct
is named inconsistently between BASOP and float, making the code maintenance more difficult. It is about the member interpolator_length
or interpolator_len
.
ivas-float-update:
typedef struct renderer_struct
{
float prev_gains[MAX_NUM_OBJECTS][MAX_OUTPUT_CHANNELS];
float *interpolator;
int16_t interpolator_length;
float gains[MAX_NUM_OBJECTS][MAX_OUTPUT_CHANNELS];
} ISM_RENDERER_DATA, *ISM_RENDERER_HANDLE;
BASOP main:
typedef struct renderer_struct
{
Word32 prev_gains_fx[MAX_NUM_OBJECTS][MAX_OUTPUT_CHANNELS]; /*Q30*/
Word16 *interpolator_fx; /*Q15*/
Word16 interpolator_len;
Word32 gains_fx[MAX_NUM_OBJECTS][MAX_OUTPUT_CHANNELS]; /*Q30*/
} ISM_RENDERER_DATA, *ISM_RENDERER_HANDLE;
To be consistent, I would propose to rename interpolator_len
to interpolator_length_fx
in BASOP.