Object editing sanitizer issues
Basic info
- Fixed point:
- Encoder (fixed): main
- Decoder (fixed): main
Bug description
Documenting here the remaining sanitizer issues in object editing BAOSP port and then fixing them in a corresponding branch. These are probably oversights in porting work.
-
USAN in do_object_editing_fx(). There is normal multiplication instead of fixed-point one there.
apps/decoder.c:3490:176: runtime error: signed integer overflow: 536870912 * 536870912 cannot be represented in type 'int'
#0 0x44b650 in do_object_editing_fx /home/gitlab-runner/builds/KPcMtOgwK/0/rep/sa4/audio/ivas-basop/apps/decoder.c:3490:176
#1 0x43a872 in decodeVoIP /home/gitlab-runner/builds/KPcMtOgwK/0/rep/sa4/audio/ivas-basop/apps/decoder.c:3098:17
#2 0x42bb81 in main /home/gitlab-runner/builds/KPcMtOgwK/0/rep/sa4/audio/ivas-basop/apps/decoder.c:658:17
#3 0x7fe04927ed8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
#4 0x7fe04927ee3f in __libc_start_main csu/../csu/libc-start.c:392:3
#5 0x4045e4 in _start (/home/gitlab-runner/builds/KPcMtOgwK/0/rep/sa4/audio/ivas-basop/IVAS_dec+0x4045e4)
-
MSAN in ivas_dirac_dec_render_sf_fx for call to ivas_omasa_preProcessStereoTransportsForEditedObjects_fx.cldfb_buf_qis uninitialized and probably needs some other variable. -
MSAN in ivas_dirac_dec_binaural_internal_fx for call to ivas_omasa_preProcessStereoTransportsForEditedObjects_fx. This also happens from ivas_dirac_dec_render_sf_fx after above fis. No idea yet.
Ways to reproduce
Check the pipeline
Edited by Tapani Pihlajakuja